dandri/MeshCore-mqtt-observer
1
0
Fork 0
mirror of https://github.com/agessaman/MeshCore.git synced 2026-08-27 22:34:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Omit SNR/RSSI instead of publishing hardcoded 12.5/-65 when no radio data

Browse Source 
buildPacketJSON() (the no-raw-data path) passed hardcoded 12.5f / -65 to
buildPacketMessage(), so every packet published without fresh raw radio data
carried fabricated SNR/RSSI indistinguishable from real readings. Measured at
~3-20% of packets per observer on the live network (sampled via the CoreScope
aggregator), which silently pollutes network-wide RF analytics.

buildPacketMessage() now omits the SNR/RSSI fields when passed sentinel values
(<= -900); real measurements are always within sane radio ranges and format as
before. Consumers see an explicit gap instead of a fabricated reading.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
ACETyr
2026-06-14 19:00:57 +02:00
co-authored by Claude Opus 4.8
parent 3e8e70b6b8
commit 0a037040b1
1 changed files with 15 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/helpers/MQTTMessageBuilder.cpp
+15 -7
View File
@@ -107,9 +107,7 @@ int MQTTMessageBuilder::buildPacketMessage(
snprintf(len_str, sizeof(len_str), "%d", len);
snprintf(packet_type_str, sizeof(packet_type_str), "%d", packet_type);
snprintf(payload_len_str, sizeof(payload_len_str), "%d", payload_len);
snprintf(snr_str, sizeof(snr_str), "%.1f", snr);
snprintf(rssi_str, sizeof(rssi_str), "%d", rssi);
root["origin"] = origin;
root["origin_id"] = origin_id;
root["timestamp"] = timestamp;
@@ -122,8 +120,18 @@ int MQTTMessageBuilder::buildPacketMessage(
root["route"] = route;
root["payload_len"] = payload_len_str;
root["raw"] = raw;
root["SNR"] = snr_str;
root["RSSI"] = rssi_str;
// Only emit SNR/RSSI when a real radio measurement is available. Callers with no raw
// radio data pass sentinels (<= -900); omitting the fields is honest about the gap,
// whereas the previous hardcoded 12.5/-65 fabricated plausible-looking values that
// polluted downstream RF analytics. Real measurements are always within sane ranges.
if (snr > -900.0f) {
snprintf(snr_str, sizeof(snr_str), "%.1f", snr);
root["SNR"] = snr_str;
}
if (rssi > -900) {
snprintf(rssi_str, sizeof(rssi_str), "%d", rssi);
root["RSSI"] = rssi_str;
}
root["hash"] = hash;
if (path && strlen(path) > 0) {
@@ -226,8 +234,8 @@ int MQTTMessageBuilder::buildPacketJSON(
packet_type, route_str,
packet->payload_len,
raw_hex,
12.5f, // SNR - using reasonable default
-65, // RSSI - using reasonable default
-999.0f, // SNR unknown — this overload reconstructs from the packet with no raw radio
-999, // RSSI unknown — emitted by omitting the fields (was a fabricated 12.5/-65)
hash_str,
packet->isRouteDirect() ? path_str : nullptr,
buffer, buffer_size