mirror of
https://github.com/agessaman/MeshCore.git
synced 2026-08-28 18:58:16 +00:00
ci(beta): drop self-referencing env redeclarations
The build step redeclared OTA_MANIFEST_BASE_URL and OTA_CHANNEL_TAG as
${{ env.X }}, referencing the very variables it was setting. Workflow-level
env: is already inherited by every step, so this was redundant; had the
self-reference resolved empty it would have silently blanked the channel and
produced firmware with no manifest base. The verify step would have caught it,
but the risk is unnecessary.
This commit is contained in:
@@ -150,9 +150,10 @@ jobs:
|
||||
- name: Build Shard ${{ matrix.shard.idx }}
|
||||
env:
|
||||
FIRMWARE_BUILD_NUMBER: ${{ needs.enumerate.outputs.build_number }}
|
||||
# These two are what make the output a beta build; build.sh reads both.
|
||||
OTA_MANIFEST_BASE_URL: ${{ env.OTA_MANIFEST_BASE_URL }}
|
||||
OTA_CHANNEL_TAG: ${{ env.OTA_CHANNEL_TAG }}
|
||||
# OTA_MANIFEST_BASE_URL and OTA_CHANNEL_TAG (what actually make this a
|
||||
# beta build) come from the workflow-level env: above, which every step
|
||||
# inherits. Do NOT redeclare them as ${{ env.X }} here — that is a
|
||||
# self-reference, and if it resolved empty it would blank the channel.
|
||||
run: /usr/bin/env bash build.sh build-firmware ${{ matrix.shard.envs }}
|
||||
|
||||
- name: Verify beta channel is baked in
|
||||
|
||||
Reference in New Issue
Block a user