Address PR review feedback from oltaco

- Remove extra blank line in companion_radio main.cpp before NRF52/STM32 block
- Revert unintended STM32_PLATFORM ETHERNET_ENABLED branch (no STM32 ethernet target exists, and it incorrectly included nrf52 headers)
- Drop renovate annotations from rak4631 platformio.ini (no renovate config in this repo)
This commit is contained in:
Ryan Gregg
2026-04-26 20:22:35 +00:00
parent 2a2c7a171d
commit a3354db521
2 changed files with 2 additions and 11 deletions
+2 -8
View File
@@ -12,7 +12,6 @@ static uint32_t _atoi(const char* sp) {
return n;
}
#if defined(NRF52_PLATFORM) || defined(STM32_PLATFORM)
#include <InternalFileSystem.h>
#if defined(QSPIFLASH)
@@ -83,13 +82,8 @@ static uint32_t _atoi(const char* sp) {
ArduinoSerialInterface serial_interface;
#endif
#elif defined(STM32_PLATFORM)
#ifdef ETHERNET_ENABLED
#include <helpers/nrf52/SerialEthernetInterface.h>
SerialEthernetInterface serial_interface;
#else
#include <helpers/ArduinoSerialInterface.h>
ArduinoSerialInterface serial_interface;
#endif
#include <helpers/ArduinoSerialInterface.h>
ArduinoSerialInterface serial_interface;
#else
#error "need to define a serial interface"
#endif
-3
View File
@@ -65,7 +65,6 @@ build_src_filter = ${rak4631.build_src_filter}
+<../examples/simple_repeater>
lib_deps =
${rak4631.lib_deps}
# renovate: datasource=github-tags depName=RAK13800-W5100S packageName=RAKWireless/RAK13800-W5100S
https://github.com/RAKWireless/RAK13800-W5100S/archive/1.0.2.zip
[env:RAK_4631_repeater_bridge_rs232_serial1]
@@ -147,7 +146,6 @@ build_src_filter = ${rak4631.build_src_filter}
+<../examples/simple_room_server>
lib_deps =
${rak4631.lib_deps}
# renovate: datasource=github-tags depName=RAK13800-W5100S packageName=RAKWireless/RAK13800-W5100S
https://github.com/RAKWireless/RAK13800-W5100S/archive/1.0.2.zip
[env:RAK_4631_companion_radio_usb]
@@ -197,7 +195,6 @@ build_src_filter = ${rak4631.build_src_filter}
lib_deps =
${rak4631.lib_deps}
densaugeo/base64 @ ~1.4.0
# renovate: datasource=github-tags depName=RAK13800-W5100S packageName=RAKWireless/RAK13800-W5100S
https://github.com/RAKWireless/RAK13800-W5100S/archive/1.0.2.zip