A spoofed GPS signal can move a fixed node anywhere and set its clock to
any time; the clock only moves forward, so a time pushed into the future
breaks timestamps and replay protection until fixed by hand.
With GPS_GUARD, MicroNMEALocationProvider asks a GpsGuard before a fix is
stored as the last fix (satellites, HDOP, optional region box, fence
around the configured position, jump speed, N stable fixes) and before
GPS time is written to the clock (trusted fix current, not before the
build date, small steps once the clock is valid, drift-sized after the
first sync). Without a trusted fix no live position is reported.
CLI in CommonGpsPrefs: 'gps guard', 'gps guard accept', 'gps fence',
'gps ref'; CommonCLI keeps the reference on set lat/lon and gps setloc,
resets the time anchor on manual clock sets and adds 'time force'.
Ported from #3736 onto the GpsDriver/LocationProvider refactor.
Bytes arriving on the UART does not mean the baud rate is right: at the
wrong rate the parser only sees garbage and never gets a fix. Modules
such as the M5Stack GROVE GPS now default to 115200, while boards
configure 9600.
With GPS_BAUD_AUTODETECT, detect() probes common GNSS rates, starting
with the configured one, and keeps the first one that yields an NMEA
sentence with a valid checksum. The rate is stored in the driver, so
later power cycles reopen the UART with it. Without the flag nothing
changes.
Ported from #3729 onto the GpsDriver refactor.
Repeaters, room servers and sensors already let the battery ADC multiplier be tuned with 'set adc.multiplier' (CommonCLI). The companion firmware had no equivalent, so a board whose divider differs from the build default (common on DIY ProMicro / Faketec boards) always reported a wrong battery voltage.
Adds the same command to the companion CLI. The value is stored in the companion prefs (comp.adc_mult, 0 = board default) and applied at startup via MainBoard::setAdcMultiplier().
On a RAK19007 the RAK12501's supply is 3V3_S, switched by WB_IO2, so
gps off, periodic mode and shutdown left it powered. Pass WB_IO2 to the
NMEA driver as peripheralPower under GPS_RAIL_POWER_CONTROL, set by the
new RAK_4631_repeater_gps_power env. It is opt-in because the rail feeds
every slot module, and refused with ETHERNET_ENABLED (RAK13800).
The RAK12500 (I2C) driver keeps switching its own power pin, so this
only applies on the NMEA path.
RefCountedDigitalPin now sets OUTPUT on claim and release: WB_IO2 left
as an input (as probeRak12500() leaves it after a failed probe) keeps
3V3_S in its last state, so writing the latch alone did not cut it.
Measured with a KM003C, battery and panel out: gps off 40.5 -> 12.4 mA,
shutdown 29.7 -> 1.30 mA.
The refactor no longer calls Serial1.setPins() on nRF52, so Serial1 uses
PIN_SERIAL1_RX/TX directly. Those were swapped (the GPS transmits on
P0.20), so no data was received. Fix them and define PIN_GPS_TX/RX by the
gps module's side, as other variants do.
The ATGM336H keeps its NMEA output config across power cycles, and other
firmware may leave every sentence disabled. Re-enable GGA + RMC after each
power-up.
I used an LLM to review what changes the likelihood of a PR getting merged. I then asked it to select potential changes based on its findings. I selected from those options and carefully guided the LLM to produce several pull requests. I fed the subset of PRs that failed back into the skill and discovered additional missing factors.
Add a dimmed heartbeat for the SenseCAP Solar (P1 Pro) white LED in the
repeater firmware, implemented entirely as a SenseCapSolarBoard::loop()
override so no example main.cpp needs to be touched:
- 100 ms pulse every 5 s, dimmed to 10% brightness via hardware PWM
(NRF_PWM0 / HwPWM0, 1 kHz, COUNTERTOP 16000, compare 1600)
- during the 4.9 s off phase the PWM peripheral is stopped (ENABLE=0),
the pin is released (PSEL disconnect) and GPIO 11 is held LOW, so no
HFCLK is demanded between pulses
- on successful application-level "start ota" the PWM is stopped and the
white LED goes steady full-brightness while BLE OTA is advertised;
on failed start the heartbeat keeps blinking
- powerOff() stops/releases the heartbeat PWM before shutting the LED off
- non-blocking millis() timing with wrap-safe unsigned arithmetic
- gated by SENSECAP_SOLAR_WHITE_LED, defined only in the
SenseCap_Solar_repeater PlatformIO env, so the room-server and
companion firmwares sharing this board class are unaffected
No changes to LoRa/repeater forwarding, the blue TX LED, charging LEDs,
GPS, power management, config storage or the bootloader.
'sensor list' appended 'name=value' lines into the 160-byte CLI reply with
unbounded sprintf, only checking the position before each write (< 134).
A single long value (or several medium ones) could write past the end of
the buffer.
Write each entry with snprintf against the remaining space, keep room for
the '... next:N' paging hint, and move entries that do not fit to the next
page. Also guard against NULL names/values from a sensor manager.