dandri/ProtoPirate
1
0 Fork 0
mirror of https://protopirate.net/ProtoPirate/ProtoPirate.git synced 2026-10-23 17:13:17 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Merge pull request 'Fix Kia V1 "Wrong" CRC' (#24) from cthuwu/ProtoPirate:cthuwu-kia-v1-crc-fix into main

Browse Source 
Reviewed-on: http://protopirate.net/ProtoPirate/ProtoPirate/pulls/24
Reviewed-by: MMX <mmx@no-reply.protopirate.net>
This commit is contained in:
MMX committed 2026-03-22 03:01:08 -04:00
2 parents 7084577433 4616c853b8
commit 4754fb084b
1 file changed
+4 -20
Download Patch File Download Diff File Expand all files Collapse all files
protocols/kia_v1.c
+4 -20
View File
@@ -102,16 +102,8 @@ static void kia_v1_check_remote_controller(SubGhzProtocolDecoderKiaV1* instance)
char_data[4] = instance->generic.btn;
char_data[5] = instance->generic.cnt & 0xFF;
uint8_t crc;
if(cnt_high == 0) {
uint8_t offset = (instance->generic.cnt >= 0x098) ? instance->generic.btn : 1;
crc = kia_v1_crc4(char_data, 6, offset);
} else if(cnt_high >= 0x6) {
char_data[6] = cnt_high;
crc = kia_v1_crc4(char_data, 7, 1);
} else {
crc = kia_v1_crc4(char_data, 6, 1);
}
char_data[6] = cnt_high;
uint8_t crc = kia_v1_crc4(char_data, 7, 1);
instance->crc = cnt_high << 4 | crc;
instance->crc_check = (crc == (instance->generic.data & 0xF));
@@ -170,16 +162,8 @@ static void kia_protocol_encoder_v1_get_upload(SubGhzProtocolEncoderKiaV1* insta
char_data[4] = instance->generic.btn;
char_data[5] = instance->generic.cnt & 0xFF;
uint8_t crc;
if(cnt_high == 0) {
uint8_t offset = (instance->generic.cnt >= 0x098) ? instance->generic.btn : 1;
crc = kia_v1_crc4(char_data, 6, offset);
} else if(cnt_high >= 0x6) {
char_data[6] = cnt_high;
crc = kia_v1_crc4(char_data, 7, 1);
} else {
crc = kia_v1_crc4(char_data, 6, 1);
}
char_data[6] = cnt_high;
uint8_t crc = kia_v1_crc4(char_data, 7, 1);
instance->generic.data = (uint64_t)instance->generic.serial << 24 |
instance->generic.btn << 16 | (instance->generic.cnt & 0xFF) << 8 |