Restore n/a fallback in observer and IATA cells, scope the covering test

This commit is contained in:
MrAlders0n
2026-07-27 19:17:03 -04:00
parent 8795c360ff
commit 8bd0f92aff
2 changed files with 10 additions and 4 deletions
+2 -2
View File
@@ -54,10 +54,10 @@ export function PacketTableRow({ packet, expanded, isFresh, onToggle }: PacketTa
</span>
<span className="font-mono text-text-muted">×{packet.observationCount}</span>
<span className="text-text-normal truncate">
{observer ? (observer.displayName ?? observer.id.slice(0, 8)) : <span className="text-text-dim"></span>}
{observer ? (observer.displayName ?? observer.id.slice(0, 8)) : <span className="text-text-dim">n/a</span>}
</span>
<span className="font-mono font-bold text-primary tracking-wider">
{observer?.iata ?? <span className="text-text-dim font-normal"></span>}
{observer?.iata ?? <span className="text-text-dim font-normal">n/a</span>}
</span>
<span className="text-right text-text-muted">
<Timestamp value={packet.lastHeardAt} />
@@ -1,5 +1,5 @@
import { describe, it, expect, vi } from "vitest";
import { render, screen, fireEvent } from "@testing-library/react";
import { render, screen, fireEvent, within } from "@testing-library/react";
import { PacketTableRow } from "../../../src/features/packets/PacketTableRow";
import type { PacketSummary } from "../../../src/types/api";
@@ -25,7 +25,13 @@ describe("PacketTableRow", () => {
it("renders line 2 even when there is no path data, so row height is constant", () => {
render(<PacketTableRow packet={pkt()} expanded={false} onToggle={() => {}} />);
expect(screen.getByText("n/a")).toBeInTheDocument();
expect(screen.getAllByText("n/a")).toHaveLength(3);
});
it("falls back to n/a in the observer and IATA cells when there is no observer", () => {
render(<PacketTableRow packet={pkt()} expanded={false} onToggle={() => {}} />);
const line1 = within(screen.getByRole("button"));
expect(line1.getAllByText("n/a")).toHaveLength(2);
});
it("falls back to the observer id when there is no display name", () => {