dandri/continuwuity
1
0
Fork 0
mirror of https://forgejo.ellis.link/continuwuation/continuwuity/ synced 2026-10-08 15:17:57 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: Refuse to process >4096 servers and/or >8192 keys

Browse Source 
pending msc
This commit is contained in:
timedout
2026-10-04 03:53:14 +01:00
parent 09a7fba83b
commit 80dd7d5071
1 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/api/server/key.rs
+12 -4
View File
@@ -106,24 +106,32 @@ fn valid_until_ts() -> MilliSecondsSinceUnixEpoch {
MilliSecondsSinceUnixEpoch::from_system_time(timepoint).expect("UInt should not overflow")
}
const MAX_KEYS_PER_QUERY: usize = 16 * 1024;
const MAX_KEYS_PER_QUERY: usize = 8192;
const MAX_SERVERS_PER_QUERY: usize = 4096;
pub(crate) async fn get_remote_server_keys_batch_route(
State(services): State<crate::State>,
body: Ruma<get_remote_server_keys_batch::v2::Request>,
) -> Result<get_remote_server_keys_batch::v2::Response> {
let start = MilliSecondsSinceUnixEpoch::now();
if body.server_keys.is_empty() {
return Ok(get_remote_server_keys_batch::v2::Response::new(Vec::new()));
} else if body.server_keys.len() > MAX_SERVERS_PER_QUERY {
return Err!(Request(TooLarge(
"Too many server keys requested ({} > {MAX_SERVERS_PER_QUERY}",
body.server_keys.len()
)));
}
let total_queried_keys = body
.server_keys
.values()
.fold(body.server_keys.len(), |acc, q| acc.saturating_add(q.len()));
if total_queried_keys > MAX_KEYS_PER_QUERY {
return Err!(Request(Forbidden(
return Err!(Request(TooLarge(
"Too many keys requested ({total_queried_keys} > {MAX_KEYS_PER_QUERY})"
)));
} else if total_queried_keys == 0 {
return Ok(get_remote_server_keys_batch::v2::Response::new(Vec::new()));
}
debug_info!("Fetching {total_queried_keys} keys across {} servers", body.server_keys.len());