dandri/i2pd
1
0 Fork 0
mirror of https://github.com/PurpleI2P/i2pd.git synced 2026-10-22 19:41:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2576 from pobregat0/sam-version-overflow

Browse Source 
don't overflow int when parsing SAM version
This commit is contained in:
orignal authored and GitHub committed 2026-09-26 07:20:23 -04:00
2 parents bdac44084f 28c65b6d59
commit ed9135be69
2 files changed
+2
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

libi2pd_client/SAM.cpp
+1
View File
@@ -92,6 +92,7 @@ namespace client
{
if (ch >= '0' && ch <= '9')
{
if (version > MAX_SAM_VERSION_VALUE) continue; // don't overflow on a long number
version *= 10;
version += (ch - '0');
}
libi2pd_client/SAM.h
+1
View File
@@ -101,6 +101,7 @@ namespace client
const char SAM_PONG[] = "PONG %s\n";
constexpr int MAKE_SAM_VERSION_NUMBER (int major, int minor) { return major*10 + minor; }
constexpr int MAX_SAM_VERSION_VALUE = 99999; // stop parsing digits above that, any such version is out of range anyway
constexpr int MIN_SAM_VERSION = MAKE_SAM_VERSION_NUMBER (3, 0);
constexpr int MAX_SAM_VERSION = MAKE_SAM_VERSION_NUMBER (3, 3);
constexpr int SAM_VERSION_33 = MAKE_SAM_VERSION_NUMBER (3, 3); // SAM 3.3