dandri/livekit
1
0
Fork 0
mirror of https://github.com/livekit/livekit.git synced 2026-09-01 20:09:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Filter out context canceled errors from logging (#2492)

Browse Source 
* Filter out context canceled errors from logging

* move a few more warns to debug
This commit is contained in:
Raja Subramanian
2024-02-19 10:19:55 +05:30
committed by GitHub
parent 262b160464
commit 1e2da70122
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/rtc/participant.go
+3 -3
View File
@@ -1864,7 +1864,7 @@ func (p *ParticipantImpl) setTrackMuted(trackID livekit.TrackID, muted bool) *li
}
if !isPending && track == nil {
p.pubLogger.Warnw("could not locate track", nil, "trackID", trackID)
p.pubLogger.Debugw("could not locate track", "trackID", trackID)
}
return trackInfo
@@ -2379,7 +2379,7 @@ func (p *ParticipantImpl) onAnyTransportNegotiationFailed() {
func (p *ParticipantImpl) UpdateSubscribedQuality(nodeID livekit.NodeID, trackID livekit.TrackID, maxQualities []types.SubscribedCodecQuality) error {
track := p.GetPublishedTrack(trackID)
if track == nil {
p.pubLogger.Warnw("could not find track", nil, "trackID", trackID)
p.pubLogger.Debugw("could not find track", "trackID", trackID)
return errors.New("could not find published track")
}
@@ -2390,7 +2390,7 @@ func (p *ParticipantImpl) UpdateSubscribedQuality(nodeID livekit.NodeID, trackID
func (p *ParticipantImpl) UpdateMediaLoss(nodeID livekit.NodeID, trackID livekit.TrackID, fractionalLoss uint32) error {
track := p.GetPublishedTrack(trackID)
if track == nil {
p.pubLogger.Warnw("could not find track", nil, "trackID", trackID)
p.pubLogger.Debugw("could not find track", "trackID", trackID)
return errors.New("could not find published track")
}
pkg/service/utils.go
+5 -1
View File
@@ -15,6 +15,8 @@
package service
import (
"context"
"errors"
"net"
"net/http"
"regexp"
@@ -27,7 +29,9 @@ func handleError(w http.ResponseWriter, r *http.Request, status int, err error,
if r != nil && r.URL != nil {
keysAndValues = append(keysAndValues, "method", r.Method, "path", r.URL.Path)
}
logger.GetLogger().WithCallDepth(1).Warnw("error handling request", err, keysAndValues...)
if !errors.Is(err, context.Canceled) {
logger.GetLogger().WithCallDepth(1).Warnw("error handling request", err, keysAndValues...)
}
w.WriteHeader(status)
_, _ = w.Write([]byte(err.Error()))
}