dandri/livekit
1
0 Fork 0
mirror of https://github.com/livekit/livekit.git synced 2026-10-22 19:43:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reduce memory allocation in WritePaddingRTP / WriteProbePackets (#3288)

Browse Source 
* allocate memory once in WriteProbePackets

Signed-off-by: Artur Melanchyk <artur.melanchyk@gmail.com>

* allocate memory once in WritePaddingRTP

Signed-off-by: Artur Melanchyk <artur.melanchyk@gmail.com>

---------

Signed-off-by: Artur Melanchyk <artur.melanchyk@gmail.com>
This commit is contained in:
Artur Melanchyk authored and GitHub committed 2024-12-25 21:01:21 -06:00
1 parent 3ba379ab4c
commit 2eaf84ad66
1 file changed
+4 -2
Download Patch File Download Diff File Expand all files Collapse all files
pkg/sfu/downtrack.go
+4 -2
View File
@@ -1034,6 +1034,7 @@ func (d *DownTrack) WritePaddingRTP(bytesToSend int, paddingOnMute bool, forceMa
}
bytesSent := 0
payloads := make([]byte, RTPPaddingMaxPayloadSize*len(snts))
for i := 0; i < len(snts); i++ {
hdr := &rtp.Header{
Version: 2,
@@ -1046,7 +1047,7 @@ func (d *DownTrack) WritePaddingRTP(bytesToSend int, paddingOnMute bool, forceMa
}
d.addDummyExtensions(hdr)
payload := make([]byte, RTPPaddingMaxPayloadSize)
payload := payloads[i*RTPPaddingMaxPayloadSize : (i+1)*RTPPaddingMaxPayloadSize : (i+1)*RTPPaddingMaxPayloadSize]
// last byte of padding has padding size including that byte
payload[RTPPaddingMaxPayloadSize-1] = byte(RTPPaddingMaxPayloadSize)
@@ -2106,6 +2107,7 @@ func (d *DownTrack) WriteProbePackets(bytesToSend int, usePadding bool) int {
}
rtxExtSequenceNumber := d.rtxSequenceNumber.Inc()
payloads := make([]byte, RTPPaddingMaxPayloadSize*num)
for i := 0; i < num; i++ {
hdr := &rtp.Header{
Version: 2,
@@ -2118,7 +2120,7 @@ func (d *DownTrack) WriteProbePackets(bytesToSend int, usePadding bool) int {
}
d.addDummyExtensions(hdr)
payload := make([]byte, RTPPaddingMaxPayloadSize)
payload := payloads[i*RTPPaddingMaxPayloadSize : (i+1)*RTPPaddingMaxPayloadSize : (i+1)*RTPPaddingMaxPayloadSize]
// last byte of padding has padding size including that byte
payload[RTPPaddingMaxPayloadSize-1] = byte(RTPPaddingMaxPayloadSize)