Anunay feedback

pkg/rtc/transport.go

@@ -102,6 +102,7 @@ var (
 	ErrNoBundleMid                       = errors.New("could not get bundle mid")
 	ErrMidMismatch                       = errors.New("media mid does not match bundle mid")
 	ErrICECredentialMismatch             = errors.New("ice credential mismatch")
+	ErrUnsupportedRemoteTrackType        = errors.New("unsupported remote track type")
 )
 
 // -------------------------------------------------------------------------
@@ -982,6 +983,10 @@ func (t *PCTransport) AddRemoteTrackAndNegotiate(
 	publishDisabledCodecs []*livekit.Codec,
 	rtcpFeedbackConfig RTCPFeedbackConfig,
 ) error {
+	if ti.Type != livekit.TrackType_AUDIO && ti.Type != livekit.TrackType_VIDEO {
+		return ErrUnsupportedRemoteTrackType
+	}
+
 	rtpCodecType := webrtc.RTPCodecTypeVideo
 	if ti.Type == livekit.TrackType_AUDIO {
 		rtpCodecType = webrtc.RTPCodecTypeAudio

pkg/rtc/types/protocol_version.go

@@ -102,5 +102,5 @@ func (v ProtocolVersion) SupportsMoving() bool {
 }
 
 func (v ProtocolVersion) SupportsSinglePeerConnection() bool {
-	return v > 16
+	return v > MaxProtocolDualPeerConnection
 }

pkg/sfu/mime/mimetype.go

@@ -267,41 +267,6 @@ func (m MimeType) ReporterType() roomobs.MimeType {
 	return roomobs.MimeTypeUndefined
 }
 
-func MimeTypeFromString(mimeTypeString string) MimeType {
-	switch mimeTypeString {
-	case "MimeTypeUnknown":
-		return MimeTypeUnknown
-	case webrtc.MimeTypeH264:
-		return MimeTypeH264
-	case webrtc.MimeTypeH265:
-		return MimeTypeH265
-	case webrtc.MimeTypeOpus:
-		return MimeTypeOpus
-	case "audio/red":
-		return MimeTypeRED
-	case webrtc.MimeTypeVP8:
-		return MimeTypeVP8
-	case webrtc.MimeTypeVP9:
-		return MimeTypeVP9
-	case webrtc.MimeTypeAV1:
-		return MimeTypeAV1
-	case webrtc.MimeTypeG722:
-		return MimeTypeG722
-	case webrtc.MimeTypePCMU:
-		return MimeTypePCMU
-	case webrtc.MimeTypePCMA:
-		return MimeTypePCMA
-	case webrtc.MimeTypeRTX:
-		return MimeTypeRTX
-	case webrtc.MimeTypeFlexFEC:
-		return MimeTypeFlexFEC
-	case "video/ulpfec":
-		return MimeTypeULPFEC
-	}
-
-	return MimeTypeUnknown
-}
-
 func NormalizeMimeType(mime string) MimeType {
 	switch {
 	case strings.EqualFold(mime, webrtc.MimeTypeH264):