dandri/livekit
1
0
Fork 0
mirror of https://github.com/livekit/livekit.git synced 2026-07-15 03:58:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Omit rtx/out-of-order packets from forwarding delay measurement. (#4659)

Browse Source 
They could inflate because of the burst of NACK responses living in the
queue for a longer time.
This commit is contained in:
Raja Subramanian
2026-07-11 16:18:57 +05:30
committed by GitHub
parent 424c7a602a
commit 44323799bc
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/sfu/receiver_base.go
+7 -1
View File
@@ -1036,7 +1036,13 @@ func (r *ReceiverBase) forwardRTP(
}
// track delay/jitter
if writeCount.Load() > 0 && r.forwardStats != nil && !extPkt.IsBuffered {
//
// Out-of-order packets (retransmissions/late arrivals) are excluded. They
// tend to arrive in bursts (e.g. a NACK triggers a batch of retransmissions
// delivered back-to-back) which the single forwarder goroutine drains
// serially, inflating the measured transit for the tail of the burst. That
// reflects loss recovery rather than steady-state forwarding health.
if writeCount.Load() > 0 && r.forwardStats != nil && !extPkt.IsBuffered && !extPkt.IsOutOfOrder {
if latency, isHigh := r.forwardStats.Update(extPkt.Arrival, mono.UnixNano()); isHigh {
r.params.Logger.Debugw(
"high forwarding latency",