dandri/livekit
1
0
Fork 0
mirror of https://github.com/livekit/livekit.git synced 2026-03-30 22:05:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

prevent uint overflow setting packet not found count (#4169)

Browse Source
This commit is contained in:
Paul Wells
2025-12-17 06:54:23 -08:00
committed by GitHub
parent 5c841b8ea1
commit 462ec324be
2 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/sfu/rtpstats/rtpstats_receiver_test.go
View File

@@ -256,3 +256,11 @@ func Test_RTPStatsReceiver_Restart(t *testing.T) {
r.Stop()
}
func Test_RTPStatsSender_getIntervalStats(t *testing.T) {
t.Run("packetsNotFoundMetadata should match lost packets", func(t *testing.T) {
r := NewRTPStatsSender(RTPStatsParams{}, 1024)
stats := r.getIntervalStats(0, 10000, 10000)
require.EqualValues(t, 8977, stats.packetsNotFoundMetadata)
})
}

4
pkg/sfu/rtpstats/rtpstats_sender.go
View File

@@ -1274,9 +1274,9 @@ func (r *RTPStatsSender) getIntervalStats(
lowerBound = ehsn - n + 1
}
extStartInclusiveClamped := max(min(extStartInclusive, upperBound), lowerBound)
extEndExclusiveClamped := max(min(extEndExclusive, upperBound), extStartInclusive)
extEndExclusiveClamped := max(min(extEndExclusive, upperBound), extStartInclusiveClamped)
intervalStats.packetsNotFoundMetadata += (extEndExclusive - extStartInclusive) - (extEndExclusiveClamped - extStartInclusiveClamped)
intervalStats.packetsNotFoundMetadata = (extEndExclusive - extStartInclusive) - (extEndExclusiveClamped - extStartInclusiveClamped)
for esn := extStartInclusiveClamped; esn != extEndExclusiveClamped; esn++ {
slot := r.getSnInfoOutOfOrderSlot(esn, ehsn)