Disable vp9 for safari 18.4 (#3631)

* Disable vp9 for safari 18.4

safari 18.4's svc encoding is broken

* more flex on test timeout
This commit is contained in:
cnderrauber
2025-04-29 13:17:39 +08:00
committed by GitHub
parent f69ab68045
commit 847239c3f2
4 changed files with 15 additions and 3 deletions
+12 -1
View File
@@ -35,7 +35,18 @@ var StaticConfigurations = []ConfigurationItem{
},
},
},
Merge: false,
Merge: true,
},
{
Match: &ScriptMatch{Expr: `c.browser == "safari" && c.browser_version > "18.3"`},
Configuration: &livekit.ClientConfiguration{
DisabledCodecs: &livekit.DisabledCodecs{
Publish: []*livekit.Codec{
{Mime: mime.MimeTypeVP9.String()},
},
},
},
Merge: true,
},
{
Match: &ScriptMatch{Expr: `(c.device_model == "xiaomi 2201117ti" && c.os == "android") ||
+1 -1
View File
@@ -88,7 +88,7 @@ func (c *clientObject) IndexGet(index tengo.Object) (res tengo.Object, err error
case "browser":
return &tengo.String{Value: strings.ToLower(c.info.Browser)}, nil
case "browser_version":
return &tengo.String{Value: c.info.BrowserVersion}, nil
return &ruleSdkVersion{sdkVersion: c.info.BrowserVersion}, nil
case "address":
return &tengo.String{Value: c.info.Address}, nil
}
+1
View File
@@ -3183,6 +3183,7 @@ func (p *ParticipantImpl) setupEnabledCodecs(publishEnabledCodecs []*livekit.Cod
subscribeCodecs = append(subscribeCodecs, c)
}
p.enabledSubscribeCodecs = subscribeCodecs
p.params.Logger.Debugw("setup enabled codecs", "publish", p.enabledPublishCodecs, "subscribe", p.enabledSubscribeCodecs, "disabled", disabledCodecs)
}
func (p *ParticipantImpl) GetEnabledPublishCodecs() []*livekit.Codec {
@@ -23,7 +23,7 @@ func TestDataChannelWriter(t *testing.T) {
require.Equal(t, 2000, n)
t1 := time.Now()
mockDC.SetNextWriteCompleteAt(t0.Add(time.Second))
mockDC.SetNextWriteCompleteAt(t0.Add(time.Second * 3 / 2))
n, err = w.Write(buf[:10])
require.NoError(t, err)
require.Equal(t, 10, n)