dandri/livekit
1
0
Fork 0
mirror of https://github.com/livekit/livekit.git synced 2026-07-28 07:49:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use proto logger to get named enums in the logs. (#4679)

Browse Source
This commit is contained in:
Raja Subramanian
2026-07-16 23:50:13 +05:30
committed by GitHub
parent 38d7efca83
commit 8c14a617f5
2 changed files with 12 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/rtc/transportmanager.go
+1 -2
View File
@@ -770,14 +770,13 @@ func (t *TransportManager) handleConnectionFailed(isShortLived bool) {
return
}
lastSignalSince := time.Since(t.lastSignalAt)
signalValid := t.signalSourceValid.Load()
if !t.hasRecentSignalLocked() || !signalValid {
// the failed might cause by network interrupt because signal closed or we have not seen any signal in the time window,
// so don't switch to next candidate type
t.params.Logger.Debugw(
"ignoring prefer candidate check by ICE failure because signal connection interrupted",
"lastSignalSince", lastSignalSince,
"sinceLastSignal", time.Since(t.lastSignalAt),
"signalValid", signalValid,
)
t.failureCount = 0
pkg/service/rtcservice.go
+11 -11
View File
@@ -518,13 +518,13 @@ func (s *RTCService) serve(w http.ResponseWriter, r *http.Request, needsJoinRequ
switch m := res.Message.(type) {
case *livekit.SignalResponse_Offer:
pLogger.Debugw("sending offer", "offer", m)
pLogger.Debugw("sending offer", "offer", logger.Proto(res))
case *livekit.SignalResponse_Answer:
pLogger.Debugw("sending answer", "answer", m)
pLogger.Debugw("sending answer", "answer", logger.Proto(res))
case *livekit.SignalResponse_Join:
pLogger.Debugw("sending join", "join", m)
pLogger.Debugw("sending join", "join", logger.Proto(res))
signalStats.ResolveRoom(m.Join.GetRoom())
signalStats.ResolveParticipant(m.Join.GetParticipant())
@@ -534,11 +534,11 @@ func (s *RTCService) serve(w http.ResponseWriter, r *http.Request, needsJoinRequ
roomID = updateRoomID
resolveLogger(false)
}
pLogger.Debugw("sending room update", "roomUpdate", m)
pLogger.Debugw("sending room update", "roomUpdate", logger.Proto(res))
signalStats.ResolveRoom(m.RoomUpdate.GetRoom())
case *livekit.SignalResponse_Update:
pLogger.Debugw("sending participant update", "participantUpdate", m)
pLogger.Debugw("sending participant update", "participantUpdate", logger.Proto(res))
case *livekit.SignalResponse_RoomMoved:
resetLogger()
@@ -555,10 +555,10 @@ func (s *RTCService) serve(w http.ResponseWriter, r *http.Request, needsJoinRequ
signalStats.ResolveRoom(m.RoomMoved.GetRoom())
signalStats.ResolveParticipant(m.RoomMoved.GetParticipant())
pLogger.Debugw("sending room moved", "roomMoved", m)
pLogger.Debugw("sending room moved", "roomMoved", logger.Proto(res))
default:
pLogger.Debugw("sending signal response", "response", m)
pLogger.Debugw("sending signal response", "response", logger.Proto(res))
}
if count, err := sigConn.WriteResponse(res); err != nil {
@@ -612,13 +612,13 @@ func (s *RTCService) serve(w http.ResponseWriter, r *http.Request, needsJoinRequ
}
}
switch m := req.Message.(type) {
switch req.Message.(type) {
case *livekit.SignalRequest_Offer:
pLogger.Debugw("received offer", "offer", m)
pLogger.Debugw("received offer", "offer", logger.Proto(req))
case *livekit.SignalRequest_Answer:
pLogger.Debugw("received answer", "answer", m)
pLogger.Debugw("received answer", "answer", logger.Proto(req))
default:
pLogger.Debugw("received signal request", "request", m)
pLogger.Debugw("received signal request", "request", logger.Proto(req))
}
if err := cr.RequestSink.WriteMessage(req); err != nil {