dandri/livekit
1
0
Fork 0
mirror of https://github.com/livekit/livekit.git synced 2026-04-18 18:55:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace reflect.Equal with generic sliceEqual (#2494)

Browse Source 
* Replace reflect.Equal with generic sliceEqual

* Use library function
This commit is contained in:
cnderrauber
2024-02-20 11:57:38 +08:00
committed by GitHub
parent e4acf02853
commit 91c320770b
1 changed files with 4 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
pkg/sfu/dependencydescriptor/dependencydescriptorwriter.go
View File

@@ -16,7 +16,8 @@ package dependencydescriptor
import (
"fmt"
"reflect"
"golang.org/x/exp/slices"
)
type TemplateMatch struct {
@@ -126,26 +127,11 @@ func (w *DependencyDescriptorWriter) findBestTemplate() error {
return nil
}
// TODO: uncomment this when go 1.18 enabled
// func sliceEqual[T comparable](a, b []T) bool {
// if len(a) != len(b) {
// return false
// }
// for i, v := range a {
// if v != b[i] {
// return false
// }
// }
// return true
// }
func (w *DependencyDescriptorWriter) calculateMatch(idx int, template *FrameDependencyTemplate) TemplateMatch {
var result TemplateMatch
result.TemplateIdx = idx
result.NeedCustomFdiffs = w.descriptor.FrameDependencies.FrameDiffs != nil && !reflect.DeepEqual(w.descriptor.FrameDependencies.FrameDiffs, template.FrameDiffs)
result.NeedCustomDtis = w.descriptor.FrameDependencies.DecodeTargetIndications != nil && !reflect.DeepEqual(w.descriptor.FrameDependencies.DecodeTargetIndications, template.DecodeTargetIndications)
result.NeedCustomFdiffs = w.descriptor.FrameDependencies.FrameDiffs != nil && !slices.Equal(w.descriptor.FrameDependencies.FrameDiffs, template.FrameDiffs)
result.NeedCustomDtis = w.descriptor.FrameDependencies.DecodeTargetIndications != nil && !slices.Equal(w.descriptor.FrameDependencies.DecodeTargetIndications, template.DecodeTargetIndications)
for i := 0; i < w.structure.NumChains; i++ {
if w.activeChains&(1<<i) != 0 && (len(w.descriptor.FrameDependencies.ChainDiffs) <= i || len(template.ChainDiffs) <= i || w.descriptor.FrameDependencies.ChainDiffs[i] != template.ChainDiffs[i]) {