dandri/livekit
1
0
Fork 0
mirror of https://github.com/livekit/livekit.git synced 2026-08-27 22:34:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Adding UT to cover case found with padding only packets (#1024)

Browse Source 
Confirmed that it fails before change to fix it and it is good now.
This commit is contained in:
Raja Subramanian
2022-09-21 09:40:26 +05:30
committed by GitHub
parent 1e20786521
commit a523b929a9
1 changed files with 123 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/sfu/rtpmunger_test.go
+123
View File
@@ -278,6 +278,129 @@ func TestGapInSequenceNumber(t *testing.T) {
require.True(t, ok)
require.Equal(t, uint16(0), offset)
}
// a padding only packet should be dropped
params = &testutils.TestExtPacketParams{
SequenceNumber: 2,
Timestamp: 0xabcdef,
SSRC: 0x12345678,
}
extPkt, _ = testutils.GetTestExtPacket(params)
tpExpected = TranslationParamsRTP{
snOrdering: SequenceNumberOrderingContiguous,
}
tp, err = r.UpdateAndGetSnTs(extPkt)
require.ErrorIs(t, err, ErrPaddingOnlyPacket)
require.Equal(t, tpExpected, *tp)
require.True(t, r.highestIncomingSN == 2)
require.True(t, r.lastSN == 1)
require.Equal(t, uint16(1), r.snOffset)
// a packet with a gap should be adding to missing cache
params = &testutils.TestExtPacketParams{
SequenceNumber: 4,
Timestamp: 0xabcdef,
SSRC: 0x12345678,
PayloadSize: 22,
}
extPkt, _ = testutils.GetTestExtPacket(params)
tpExpected = TranslationParamsRTP{
snOrdering: SequenceNumberOrderingGap,
sequenceNumber: 3,
timestamp: 0xabcdef,
}
tp, err = r.UpdateAndGetSnTs(extPkt)
require.NoError(t, err)
require.Equal(t, tpExpected, *tp)
require.True(t, r.highestIncomingSN == 4)
require.True(t, r.lastSN == 3)
require.Equal(t, uint16(1), r.snOffset)
// another contiguous padding only packet should be dropped
params = &testutils.TestExtPacketParams{
SequenceNumber: 5,
Timestamp: 0xabcdef,
SSRC: 0x12345678,
}
extPkt, _ = testutils.GetTestExtPacket(params)
tpExpected = TranslationParamsRTP{
snOrdering: SequenceNumberOrderingContiguous,
}
tp, err = r.UpdateAndGetSnTs(extPkt)
require.ErrorIs(t, err, ErrPaddingOnlyPacket)
require.Equal(t, tpExpected, *tp)
require.True(t, r.highestIncomingSN == 5)
require.True(t, r.lastSN == 3)
require.Equal(t, uint16(2), r.snOffset)
// a packet with a gap should be adding to missing cache
params = &testutils.TestExtPacketParams{
SequenceNumber: 7,
Timestamp: 0xabcdef,
SSRC: 0x12345678,
PayloadSize: 22,
}
extPkt, _ = testutils.GetTestExtPacket(params)
tpExpected = TranslationParamsRTP{
snOrdering: SequenceNumberOrderingGap,
sequenceNumber: 5,
timestamp: 0xabcdef,
}
tp, err = r.UpdateAndGetSnTs(extPkt)
require.NoError(t, err)
require.Equal(t, tpExpected, *tp)
require.True(t, r.highestIncomingSN == 7)
require.True(t, r.lastSN == 5)
require.Equal(t, uint16(2), r.snOffset)
// check the missing packets
params = &testutils.TestExtPacketParams{
SequenceNumber: 6,
Timestamp: 0xabcdef,
SSRC: 0x12345678,
}
extPkt, _ = testutils.GetTestExtPacket(params)
tpExpected = TranslationParamsRTP{
snOrdering: SequenceNumberOrderingOutOfOrder,
sequenceNumber: 4,
timestamp: 0xabcdef,
}
tp, err = r.UpdateAndGetSnTs(extPkt)
require.NoError(t, err)
require.Equal(t, tpExpected, *tp)
require.True(t, r.highestIncomingSN == 7)
require.True(t, r.lastSN == 5)
require.Equal(t, uint16(2), r.snOffset)
params = &testutils.TestExtPacketParams{
SequenceNumber: 3,
Timestamp: 0xabcdef,
SSRC: 0x12345678,
}
extPkt, _ = testutils.GetTestExtPacket(params)
tpExpected = TranslationParamsRTP{
snOrdering: SequenceNumberOrderingOutOfOrder,
sequenceNumber: 2,
timestamp: 0xabcdef,
}
tp, err = r.UpdateAndGetSnTs(extPkt)
require.NoError(t, err)
require.Equal(t, tpExpected, *tp)
require.True(t, r.highestIncomingSN == 7)
require.True(t, r.lastSN == 5)
require.Equal(t, uint16(2), r.snOffset)
}
func TestUpdateAndGetPaddingSnTs(t *testing.T) {