dandri/livekit
1
0
Fork 0
mirror of https://github.com/livekit/livekit.git synced 2026-07-28 07:49:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add status code for twirp request latency prometheus metric (#4621)

Browse Source 
* Add status code for twirp request latency prometheus metric

* Drop the twirp error codes as that adds a lot of coardinality
This commit is contained in:
Ninad Pundalik
2026-07-22 15:52:30 +05:30
committed by GitHub
parent 13e4aaec2b
commit afb9142c1e
2 changed files with 31 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/service/twirp.go
+28 -20
View File
@@ -143,9 +143,10 @@ func loggerResponseSent(ctx context.Context, twirpLoggerPool *sync.Pool) {
r.fields = append(r.fields, "code", r.error.Code())
}
statusFamily, _ := twirpResponseStatus(ctx, r.error)
serviceMethod := "API " + r.service + "." + r.method
prometheus.RecordTwirpRequestLatency(r.service, r.method, duration, statusFamily)
utils.GetLogger(ctx).WithComponent(utils.ComponentAPI).Infow(serviceMethod, r.fields...)
prometheus.RecordTwirpRequestLatency(r.service, r.method, duration)
// reset fields and return to pool
r.reset()
@@ -197,31 +198,38 @@ func statusReporterRequestRouted(ctx context.Context) (context.Context, error) {
return ctx, nil
}
func twirpResponseStatus(ctx context.Context, err twirp.Error) (statusFamily string, code twirp.ErrorCode) {
if statusCode, ok := twirp.StatusCode(ctx); ok {
statusFamily = httpStatusFamily(statusCode)
}
if err != nil {
code = err.Code()
}
return
}
func httpStatusFamily(statusCode string) string {
var statusFamily string
if status, err := strconv.Atoi(statusCode); err == nil {
switch {
case status >= 400 && status <= 499:
statusFamily = "4xx"
case status >= 500 && status <= 599:
statusFamily = "5xx"
default:
statusFamily = statusCode
}
}
return statusFamily
}
func statusReporterResponseSent(ctx context.Context) {
r, ok := ctx.Value(statusReporterKey{}).(*twirpRequestFields)
if !ok || r == nil {
return
}
var statusFamily string
if statusCode, ok := twirp.StatusCode(ctx); ok {
if status, err := strconv.Atoi(statusCode); err == nil {
switch {
case status >= 400 && status <= 499:
statusFamily = "4xx"
case status >= 500 && status <= 599:
statusFamily = "5xx"
default:
statusFamily = statusCode
}
}
}
var code twirp.ErrorCode
if r.error != nil {
code = r.error.Code()
}
statusFamily, code := twirpResponseStatus(ctx, r.error)
prometheus.RecordTwirpRequestStatus(r.service, r.method, statusFamily, code)
}
pkg/telemetry/prometheus/node.go
+3 -3
View File
@@ -90,7 +90,7 @@ func Init(nodeID string, nodeType livekit.NodeType) error {
ConstLabels: prometheus.Labels{"node_id": nodeID, "node_type": nodeType.String()},
Buckets: []float64{5, 10, 25, 50, 100, 250, 500, 1000, 2500, 5000, 10000, 30000, 60000},
},
[]string{"service", "method"},
[]string{"service", "method", "status"},
)
promSysPacketGauge = prometheus.NewGaugeVec(
@@ -305,6 +305,6 @@ func RecordTwirpRequestStatus(service string, method string, statusFamily string
promTwirpRequestStatusCounter.WithLabelValues(service, method, statusFamily, string(code)).Add(1)
}
func RecordTwirpRequestLatency(service, method string, duration time.Duration) {
promTwirpRequestLatency.WithLabelValues(service, method).Observe(float64(duration.Milliseconds()))
func RecordTwirpRequestLatency(service, method string, duration time.Duration, statusFamily string) {
promTwirpRequestLatency.WithLabelValues(service, method, statusFamily).Observe(float64(duration.Milliseconds()))
}