dandri/livekit
1
0
Fork 0
mirror of https://github.com/livekit/livekit.git synced 2026-08-29 07:39:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

baseFlags do not need to be set (#1127)

Browse Source
This commit is contained in:
Mathew Kamkar
2022-10-26 14:20:13 -07:00
committed by GitHub
parent 7223d9c132
commit b2493b49f7
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/config/config.go
+2 -2
View File
@@ -473,8 +473,8 @@ func (conf *Config) updateFromCLI(c *cli.Context, baseFlags []cli.Flag) error {
for _, flag := range c.App.Flags {
flagName := flag.Names()[0]
// the `len(baseFlags) > 0` check is needed because `c.IsSet(...)` is always false in unit tests
if !c.IsSet(flagName) && len(baseFlags) > 0 {
// the `c.App.Name != "test"` check is needed because `c.IsSet(...)` is always false in unit tests
if !c.IsSet(flagName) && c.App.Name != "test" {
continue
}
pkg/config/config_test.go
+1
View File
@@ -38,6 +38,7 @@ func TestGeneratedFlags(t *testing.T) {
require.NoError(t, err)
app := cli.NewApp()
app.Name = "test"
app.Flags = append(app.Flags, generatedFlags...)
set := flag.NewFlagSet("test", 0)