dandri/livekit
1
0
Fork 0
mirror of https://github.com/livekit/livekit.git synced 2026-05-15 00:55:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Check for Firefox in rtc config. (#3336)

Browse Source
This commit is contained in:
Raja Subramanian
2025-01-15 20:45:37 +05:30
committed by GitHub
parent 8c62f9b2fa
commit b82f77eb87
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/rtc/config.go
+6 -5
View File
@@ -118,12 +118,13 @@ func NewWebRTCConfig(conf *config.Config) (*WebRTCConfig, error) {
PacketBufferSizeAudio: rtcConf.PacketBufferSizeAudio,
},
Publisher: publisherConfig,
Subscriber: getSubscriberConfig(rtcConf.CongestionControl),
Subscriber: getSubscriberConfig(rtcConf.CongestionControl.UseSendSideBWEInterceptor || rtcConf.CongestionControl.UseSendSideBWE),
}, nil
}
func (c *WebRTCConfig) UpdateCongestionControl(ccConf config.CongestionControlConfig) {
c.Subscriber = getSubscriberConfig(ccConf)
func (c *WebRTCConfig) UpdateCongestionControl(ccConf config.CongestionControlConfig, clientInfo ClientInfo) {
enableTWCC := (ccConf.UseSendSideBWEInterceptor || ccConf.UseSendSideBWE) && !clientInfo.isFirefox()
c.Subscriber = getSubscriberConfig(enableTWCC)
}
func (c *WebRTCConfig) SetBufferFactory(factory *buffer.Factory) {
@@ -131,7 +132,7 @@ func (c *WebRTCConfig) SetBufferFactory(factory *buffer.Factory) {
c.SettingEngine.BufferFactory = factory.GetOrNew
}
func getSubscriberConfig(ccConf config.CongestionControlConfig) DirectionConfig {
func getSubscriberConfig(enableTWCC bool) DirectionConfig {
subscriberConfig := DirectionConfig{
RTPHeaderExtension: RTPHeaderExtensionConfig{
Video: []string{
@@ -154,7 +155,7 @@ func getSubscriberConfig(ccConf config.CongestionControlConfig) DirectionConfig
},
},
}
if ccConf.UseSendSideBWEInterceptor || ccConf.UseSendSideBWE {
if enableTWCC {
subscriberConfig.RTPHeaderExtension.Video = append(subscriberConfig.RTPHeaderExtension.Video, sdp.TransportCCURI)
subscriberConfig.RTCPFeedback.Video = append(subscriberConfig.RTCPFeedback.Video, webrtc.RTCPFeedback{Type: webrtc.TypeRTCPFBTransportCC})
} else {