Squelch only the log, not the error return. (#2379)

This commit is contained in:
Raja Subramanian
2024-01-12 16:58:23 +05:30
committed by GitHub
parent 2fe2a9c9f2
commit bf0e88dea4

View File

@@ -504,9 +504,12 @@ func (m *SubscriptionManager) subscribe(s *trackSubscription) error {
}
subTrack, err := track.AddSubscriber(m.params.Participant)
if err != nil && !errors.Is(err, errAlreadySubscribed) && !errors.Is(err, ErrTrackNotAttached) && !errors.Is(err, ErrNoReceiver) {
// ignore errors: already subscribed OR waiting for track resolve
m.params.Logger.Warnw("add subscriber failed", err, "trackID", trackID)
if err != nil && !errors.Is(err, errAlreadySubscribed) {
// ignore error(s): already subscribed
if !errors.Is(err, ErrTrackNotAttached) && !errors.Is(err, ErrNoReceiver) {
// as track resolution could take some time, not logging errors due to waiting for track resolution
m.params.Logger.Warnw("add subscriber failed", err, "trackID", trackID)
}
return err
}
if err == errAlreadySubscribed {