dandri/livekit
1
0
Fork 0
mirror of https://github.com/livekit/livekit.git synced 2026-03-30 13:25:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

remove close check in downtrack.bind (#819)

Browse Source 
* remove close check in downtrack.bind

* return nil but do nothing
This commit is contained in:
cnderrauber
2022-07-08 10:59:09 +08:00
committed by GitHub
parent 8315a547a8
commit cf88bdebc2
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
pkg/sfu/downtrack.go
View File

@@ -260,9 +260,6 @@ func NewDownTrack(
// This asserts that the code requested is supported by the remote peer.
// If so it sets up all the state (SSRC and PayloadType) to have a call
func (d *DownTrack) Bind(t webrtc.TrackLocalContext) (webrtc.RTPCodecParameters, error) {
if d.IsClosed() {
return webrtc.RTPCodecParameters{}, ErrDownTrackClosed
}
if d.bound.Load() {
return webrtc.RTPCodecParameters{}, ErrDownTrackAlreadyBound
}
@@ -278,8 +275,14 @@ func (d *DownTrack) Bind(t webrtc.TrackLocalContext) (webrtc.RTPCodecParameters,
if codec.MimeType == "" {
return webrtc.RTPCodecParameters{}, webrtc.ErrUnsupportedCodec
}
d.logger.Debugw("DownTrack.Bind", "codecs", d.upstreamCodecs, "matchCodec", codec)
// if a downtrack is closed before bind, it already unsubscribed from client, don't do subsequent operation and return here.
if d.IsClosed() {
d.logger.Debugw("DownTrack closed before bind")
return codec, nil
}
d.logger.Debugw("DownTrack.Bind", "codecs", d.upstreamCodecs, "matchCodec", codec)
d.ssrc = uint32(t.SSRC())
d.payloadType = uint8(codec.PayloadType)
d.writeStream = t.WriteStream()