dandri/livekit
1
0
Fork 0
mirror of https://github.com/livekit/livekit.git synced 2026-07-28 07:49:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prefer QDisc.Stats till go-tc addresses QDisc.Stats2 parsing (#4685)

Browse Source
This commit is contained in:
Raja Subramanian
2026-07-17 16:39:25 +05:30
committed by GitHub
parent 14aeeb3c56
commit f0ac6ce200
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/telemetry/prometheus/node_linux.go
+8 -7
View File
@@ -41,13 +41,14 @@ func getTCStats() (packets, drops uint32, err error) {
// Newer kernels report stats via TCA_STATS2 (Stats2), while older kernels
// only populate the legacy TCA_STATS attribute (Stats). Prefer Stats2 and
// fall back to Stats so counters are collected on both.
switch {
case qdisc.Stats2 != nil:
packets = packets + qdisc.Stats2.Packets
drops = drops + qdisc.Stats2.Drops
case qdisc.Stats != nil:
packets = packets + qdisc.Stats.Packets
drops = drops + qdisc.Stats.Drops
//
// However, go-tc (through v0.4.8 and current main) mis-parses the nested TCA_STATS2
// as a flat struct, so Stats2.Packets/.Drops are garbage. The legacy
// TCA_STATS blob is a real flat struct and is parsed correctly, and modern
// kernels populate BOTH — so prefer Stats.
if qdisc.Stats != nil {
packets += qdisc.Stats.Packets
drops += qdisc.Stats.Drops
}
}