Allow playout delay even when sync stream isn't used. (#2133)

The two options should function independently. Users could still improve
video jitter by using up to 100ms of playout delay.
This commit is contained in:
David Zhao authored and GitHub committed 2023-10-06 14:51:11 -07:00
1 parent 4253845505
commit f40a97fd3e
2 files changed
+3 -3

No files matched your search

+2 -2
View File
@@ -1114,7 +1114,7 @@ func (p *ParticipantImpl) setupTransportManager() error {
TCPFallbackRTTThreshold: p.params.TCPFallbackRTTThreshold,
AllowUDPUnstableFallback: p.params.AllowUDPUnstableFallback,
TURNSEnabled: p.params.TURNSEnabled,
AllowPlayoutDelay: p.params.PlayoutDelay.GetEnabled() && p.SupportsSyncStreamID(),
AllowPlayoutDelay: p.params.PlayoutDelay.GetEnabled(),
Logger: p.params.Logger.WithComponent(sutils.ComponentTransport),
})
if err != nil {
@@ -2291,7 +2291,7 @@ func (p *ParticipantImpl) SendDataPacket(dp *livekit.DataPacket, data []byte) er
err := p.TransportManager.SendDataPacket(dp, data)
if err != nil {
if (err == sctp.ErrStreamClosed || err == io.ErrClosedPipe) && p.params.ReconnectOnDataChannelError {
if (errors.Is(err, sctp.ErrStreamClosed) || errors.Is(err, io.ErrClosedPipe)) && p.params.ReconnectOnDataChannelError {
p.params.Logger.Infow("issuing full reconnect on data channel error")
p.IssueFullReconnect(types.ParticipantCloseReasonDataChannelError)
}
+1 -1
View File
@@ -252,7 +252,7 @@ func (p *ParticipantImpl) configurePublisherAnswer(answer webrtc.SessionDescript
opusPT, err := parsed.GetPayloadTypeForCodec(sdp.Codec{Name: "opus"})
if err != nil {
p.pubLogger.Infow("failed to get opus payload type", "error", err, "trakcID", ti.Sid)
p.pubLogger.Infow("failed to get opus payload type", "error", err, "trackID", ti.Sid)
continue
}