dandri/livekit
1
0
Fork 0
mirror of https://github.com/livekit/livekit.git synced 2026-03-30 15:35:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Disable SCTP zero checksum for old go client (#3319)

Browse Source 
Old go-sdks with old pion/sctp version can't
process unknown parameters.
This commit is contained in:
cnderrauber
2025-01-09 13:22:23 +08:00
committed by GitHub
parent 0d9bad489c
commit f846c7719b
3 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/rtc/clientinfo.go
View File

@@ -102,7 +102,7 @@ func (c ClientInfo) SupportErrorResponse() bool {
}
func (c ClientInfo) SupportSctpZeroChecksum() bool {
return !(c.isGo() && c.compareVersion("2.1.3") <= 0)
return !(c.isGo() && c.compareVersion("2.4.0") < 0)
}
// compareVersion compares a semver against the current client SDK version

2
pkg/rtc/config.go
View File

@@ -69,8 +69,6 @@ func NewWebRTCConfig(conf *config.Config) (*WebRTCConfig, error) {
// we don't want to use active TCP on a server, clients should be dialing
webRTCConfig.SettingEngine.DisableActiveTCP(true)
webRTCConfig.SettingEngine.EnableSCTPZeroChecksum(true)
if rtcConf.PacketBufferSize == 0 {
rtcConf.PacketBufferSize = 500
}

4
pkg/rtc/transport.go
View File

@@ -306,6 +306,10 @@ func newPeerConnection(params TransportParams, onBandwidthEstimator func(estimat
se.SetFireOnTrackBeforeFirstRTP(true)
}
if params.ClientInfo.SupportSctpZeroChecksum() {
se.EnableSCTPZeroChecksum(true)
}
//
// Disable SRTP replay protection (https://datatracker.ietf.org/doc/html/rfc3711#page-15).
// Needed due to lack of RTX stream support in Pion.