Commit Graph

2453 Commits

Author SHA1 Message Date
David Colburn 1cf04e3511 add egress proxy proto (#2570) 2024-03-11 21:53:12 -04:00
Raja Subramanian 610d68a409 Clean up using publisher side clock rate. (#2568)
It is not used any more.
2024-03-11 12:25:07 +05:30
Raja Subramanian 50c48ff29d Ignore out-of-order receiver side sender reports. (#2567) 2024-03-11 11:30:01 +05:30
Raja Subramanian 93c7d1f4fb Adjust first packet time on down track resume. (#2566)
Allows subscriber sender report to line up better quicker.
2024-03-11 00:40:16 +05:30
Raja Subramanian bdbc9dcbc7 Use start time stamp to calculate down stream sender report. (#2564)
* Use start time stamp to calculate down stream sender report.

With first packet time adjustment, using the first time stamp is more
accurate.

This still suffers if the up stream clock rate changes (happens in cases
like noise suppression which is not well understood). Will be looking at
pass through of sender report from publisher to subscriber.

* similar log strings

* avoid early sender reports

* log messages

* Reduce first packet adjustment threshold to 15 seconds
2024-03-10 23:18:54 +05:30
Raja Subramanian a08b058abc Structured logging for sender report data. (#2563) 2024-03-10 01:29:37 +05:30
David Colburn 13f8191cc8 update protocol (#2560) 2024-03-08 11:11:32 -08:00
Raja Subramanian 666b912dd3 Fix test (#2557)
Have no idea how last PR was ready to merge without this.
2024-03-08 20:31:58 +05:30
Raja Subramanian 324c5f35cb handle nil resolver. (#2556) 2024-03-08 19:06:28 +05:30
renovate[bot] 063b9d57cc Update pion deps (#2534)
Generated by renovateBot

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-03-07 09:12:21 -08:00
Alexandr Rastopchin 7d39711084 fix issue 2539, do not kill the keepaliveWorker task when the ping timeout occurs (#2555) 2024-03-07 09:11:36 -08:00
Raja Subramanian 6c94185aa6 Bring back soft close. (#2553)
Remote media track needs it.
2024-03-07 12:52:48 +05:30
Paul Wells d87f8aa299 use departure timeout (#2549)
* use departure timeout

* deps

* default

* remove constants

* deps

* protoproxy cache

* add sample
2024-03-05 09:05:42 -08:00
Raja Subramanian 0618cb39df Logging time and rtp diff for easier debugging (#2548) 2024-03-05 20:31:44 +05:30
cnderrauber 95001dfe54 remove warning log of unexpected rtcp fb (#2546)
* remove warning log of unexpected rtcp fb

* Add log for high playout delay

* don't create delay controller for audio
2024-03-05 10:35:28 +08:00
Raja Subramanian 108594a0b9 Notify migration on migration out node. (#2543)
It is possible that migration could trigger without migrating out node
knowing about it. So, when a migration started notification comes in,
set up migration timer if not already set.
2024-03-04 19:43:54 +05:30
Raja Subramanian 46257c1d24 Skip large RR intervals. (#2544) 2024-03-04 19:12:53 +05:30
Raja Subramanian fdd76c8734 Post a PLI check request on connected. (#2542)
Otherwise, it gets delayed by timer and could wait upto to interval
(which could be 200 ms when there is no RTT information yet).
2024-03-04 14:41:35 +05:30
cnderrauber 8c5d8730b1 Check ssrc for rtcp packets (#2541)
* Check ssrc for rtcp packets

* Add warn log if rtcp fb has unknown ssrc
2024-03-04 16:36:57 +08:00
Raja Subramanian 56dcd0b025 Process matching sender report only. (#2540) 2024-03-04 13:11:57 +05:30
Paul Wells ad341d41f5 start telemetry participant worker to collect signal stats (#2538)
* start telemetry participant worker to collect signal stats

* format

* resolve room

* tidy
2024-03-03 02:47:51 -08:00
cnderrauber b58307f144 Support XR request/response for rtt calculation (#2536)
* Support XR request/response for rtt calculation

* Update pkg/sfu/downtrack.go

Co-authored-by: David Zhao <dz@livekit.io>

---------

Co-authored-by: David Zhao <dz@livekit.io>
2024-03-03 12:34:49 +08:00
renovate[bot] cbc1d1b1ce Update go deps (#2529)
Generated by renovateBot

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-03-02 10:03:57 -08:00
Raja Subramanian dbe2af3886 Remove subscriber if track closed while adding subscriber. (#2537)
* Remove subscriber if track closed while adding subscriber.

It is possible that the track is closed when subscriber add is
processed. That subscriber would have been dangling off a closed track.

Check again after adding subscriber if track is closed.
If it is, remove the subscriber and return error so that subscription
manager re-resolves.

* oops, wrong unlock
2024-03-02 23:12:20 +05:30
Denys Smirnov 9a6d25674d Validate SIP trunks and rules when creating new ones. (#2535) 2024-03-01 19:29:32 +02:00
Raja Subramanian 6a0b72c357 Use SubscriberID() is calls to DeleteDownTrack. (#2533)
Thank you @cnderrauber for catching this.
2024-03-01 15:21:00 +05:30
Raja Subramanian 9e334c7510 Refactoring channel handling (#2532)
* Refactoring channel handling

* Add a version to SubscriberID()
2024-03-01 15:08:07 +05:30
Raja Subramanian 95011d64f8 Annotate max subscribe layer change with events. (#2531)
Using events to understand what is causing max subscribed layer changes.
Seeing an edge case where all layers are disabled incorrectly.
2024-03-01 11:27:26 +05:30
Jeff 00db7bc79b Update README.md (#2530)
* Update README.md

Link to non-deprecated repo

* Cleanup
2024-02-29 21:11:24 -08:00
Raja Subramanian d40041d013 Use the correct snapshot id for PPS. (#2528)
* Use the correct snapshot id for PPS.

That caused connection quality to operate on small windows.

* remove debug
2024-02-29 22:48:36 +05:30
Raja Subramanian ea66eae9f5 Start moving things to structured logging (#2527) 2024-02-29 14:35:19 +05:30
Raja Subramanian af79224e30 Check on copy. (#2525)
Should not happen, but just being defensive.
2024-02-29 10:25:52 +05:30
cnderrauber a435368278 use dynamic bucket size (#2524) 2024-02-28 16:24:23 +08:00
Raja Subramanian 6519c7596a Demote some logs. (#2523)
When a fallback is not applied, it is due to signal interruption.
ICE connection failing happens. And every time there is error, it is due
to "no selected pair".

Move all of it to `Debugw`. `setting ICE config` is the definitive log
which says if a different ICE config was applied.
2024-02-28 12:11:40 +05:30
David Colburn 098b12981f fix pli throttle locking (#2521)
* fix pli throttle locking

* UpdatePliAndTime still used in cloud
2024-02-27 20:22:38 -08:00
cnderrauber 20ac7fb416 Confirm migrated tracks info before declare migration completed (#2522)
* Confirm migrated tracks info before declare migration completed

* log expected mid
2024-02-28 12:16:34 +08:00
renovate[bot] 5326263d44 Update module github.com/prometheus/client_golang to v1.19.0 (#2514)
Generated by renovateBot

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-02-27 18:33:15 -08:00
David Zhao 13151b24a0 Re-enable static check (#2520) 2024-02-27 17:58:56 -08:00
Denys Smirnov f5eb6c8a95 Update usage of core.Fuse. (#2519) 2024-02-28 03:48:58 +02:00
Raja Subramanian 7649e4ffab Post data and signal stats once in 5 minutes (#2518) 2024-02-27 15:45:32 +05:30
Raja Subramanian fb5595880a Missed lock in codec translate (#2516) 2024-02-27 12:23:40 +05:30
Raja Subramanian 8442b2b37c Maintain subscription count. (#2515)
* Maintain subscription count.

Does not affect function as it is not decremented only if limits are
configured. But, good to maintain proper count anyway.

* wire
2024-02-27 12:11:24 +05:30
Raja Subramanian 22474e0f5d Remove unused interface method (#2513)
* Remove unused interface method

* cleanup
2024-02-26 20:55:41 +05:30
Raja Subramanian ef4bc0b46d Support no dynacast pause. (#2512) 2024-02-26 15:15:04 +05:30
Russ d'Sa 8b6fc9ae53 Update README.md (#2511) 2024-02-25 15:44:38 -08:00
Russ d'Sa de08de1a14 Update README.md (#2510) 2024-02-25 15:28:45 -08:00
renovate[bot] 2066bf1154 Update go deps (#2480)
Generated by renovateBot

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-02-25 15:24:42 -08:00
Raja Subramanian 6696c1e63d Close published track always. (#2508)
Simplify and close published track always. Avoid the round about path of
unbind to close.
2024-02-25 13:46:55 +05:30
Raja Subramanian eed457d8be Do not need pending migration tracks. (#2507)
Simplify a bit. Pending migratiion tracks need not be maintained as when
a migrated track is added, it is added to up track manager and treated
as a published track. When up track manager closes, published tracks
will close. So, no need to maintain a separate list.
2024-02-25 01:31:04 +05:30
Paul Wells e5b8e25064 use shared psrpc utils (#2506)
* use shared psrpc utils

* fix

* deps
2024-02-24 00:38:49 -08:00