dandri/livekit
1
0
Fork 0
mirror of https://github.com/livekit/livekit.git synced 2026-07-20 07:01:22 +00:00
Code Issues Packages Projects Releases Wiki Activity
3,489 Commits 68 Branches 151 Tags
2317c29531c8a8ae5ec2b08ccf76eb76145c9646
Commit Graph
3489 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Raja SubramanianandGitHub 2317c29531 Fix panic while removing track from room track manager. (#4153) 
Cannot range and use `slices.Delete` in the loop.
 2025-12-12 14:19:18 +05:30
Raja SubramanianandGitHub a0a28ac5e3 Avoid duplicate track add to room track manager. (#4152) 
* Avoid duplicate track add to room track manager.

Don't have proof that this happens, but in the leak chase, this is
another component at room level and holds references to tracks. Guessing
this is not cleaning tracks till room is closed.

* add a report
 2025-12-12 12:42:04 +05:30
Raja SubramanianandGitHub f01008f876 Revert telemetry stats worker wait configuration. (#4151) 
Mostly reverting https://github.com/livekit/livekit/pull/4148. Leaving
the one bit to pass in a wait time to `Flush`.
 2025-12-12 10:56:25 +05:30
Raja SubramanianandGitHub ca4b56d2d5 Handle case of sequence number jump just after start. (#4150) 
It is possible that the stream stops just after start and
restarts much later introducing a large gap in sequence number.
That could look like an unhandled case because the wrap back handler
does not have enough packets yet.

Let other checks based on time stamp gap take effect and only if that
also leaves the sequence number unhandled, drop the packet.
 2025-12-12 00:29:15 +05:30
Raja SubramanianandGitHub 97099cae3e Configurable telemetry stats worker clean up wait. (#4148) 
* Configurable telemetry stats worker clean up wait.

* make worker clean up wait setting atomic
 2025-12-11 11:25:32 +05:30
changgesiandGitHub d7db7cb389 chore: fix a large number of spelling issues (#4147) 
Signed-off-by: changgesi <changgesi@outlook.com>
 2025-12-11 09:34:13 +05:30
Raja SubramanianandGitHub cadf2ad9d8 Release v1.9.8 (#4145) 
Mainly to pick up leak fixes.
v1.9.8 		2025-12-10 15:32:12 +05:30
Raja SubramanianandGitHub 498304cdd9 defensive nil check (#4144) 2025-12-10 13:33:08 +05:30
Raja SubramanianandGitHub 20f6a49780 Store ddParser in atomic.Pointer (#4143) 
* Store ddParser in atomic.Pointer

as release is handled outside lock

* log space

* make non-struct methods to release packets
 2025-12-10 13:01:17 +05:30
Raja SubramanianandGitHub 037cb9062f release ext packet if patching fails (#4142) 2025-12-10 12:09:49 +05:30
Raja SubramanianandGitHub dd598ef23f Release ExtPacket if dependency descriptor or other parsing fails (#4141) 2025-12-10 11:05:19 +05:30
Raja SubramanianandGitHub 35b0e2bc21 update webrtc to 4.1.8 to pick up DTLS fingerprint check during handshake (#4140) 2025-12-10 00:03:32 +05:30
Raja SubramanianandGitHub 1c1a836c3c Mark RTCP buffer Write as noinline. (#4138) 
Seeing a bunch of objects in ReadStreamSRTP.write which does not make
a lot of sense as the function does not allocate anything
(https://github.com/pion/srtp/blob/8fe528a0c4ebb5c46d40a9fd5b77e5b6655fa919/stream_srtp.go#L68-L77)

RTP buffer was marked noinline in an easrlier PR.
Marking RTCP buffer write also as noinline to check if heap reporting
changes.
 2025-12-08 22:30:30 +05:30
Raja SubramanianandGitHub ea9b217738 protocol deps to get inactive file adjusted memory usage. (#4137) 2025-12-08 22:07:24 +05:30
Raja SubramanianandGitHub 64f3d1e972 switch participant callbacks to room to listener interface (#4136) 
* switch participant callbacks to room to listener interface

* mage generate

* clean up

* clear listener

* clean up

* use interface in up data track manager

* tweaks

* Paul feedback - should reduce the diff as this keeps the room handlers as is except making methods for a couple of anonymous handlers

* clean up
 2025-12-08 15:59:45 +05:30
Paul WellsandGitHub c6e6c0215f add debug metric for tracking references (#4134) 2025-12-07 11:39:21 -08:00
Raja SubramanianandGitHub a30c79fa6d Use isEnding to indicate if down track could be resumed. (#4132) 
There is no need to cache down track if participant is going away.
 2025-12-06 19:55:20 +05:30
Raja SubramanianandGitHub 8c241ecf12 Fix RTCP reader leak in DownTrack. (#4131) 
When a participant is closing, RTCP readers should be cleaned up from
factory even if the participant is expected to resume. The resumed
participant will be a new participant session and peer connection(s) and
everything will be set up again.
 2025-12-06 17:49:23 +05:30
Raja SubramanianandGitHub 3eef869a68 Do not pause rid in SDP (#4129) 2025-12-05 15:57:31 +05:30
Raja SubramanianandGitHub 8e01e595b8 Release 1.9.7 (#4128) 
Mainly to get the concurrent map access fix.
v1.9.7 		2025-12-05 11:13:05 +05:30
Raja SubramanianandGitHub 7c1a0fab7c Fix concurrent map access. (#4127) 
https://github.com/livekit/livekit/issues/4126
 2025-12-05 10:48:10 +05:30
Raja SubramanianandGitHub 14446b1cc1 Let participant close remove the published tracks. (#4125) 2025-12-04 22:37:08 +05:30
cnderrauberandGitHub fa0633aa3e move utils.WrapAround to mediatransportutil (#4124) 2025-12-04 17:45:11 +08:00
Raja SubramanianandGitHub f8706cd470 Update pion/ice to stop gather first on close (#4123) 
* Update pion/ice to stop gather first on close

* fix data race in test
 2025-12-04 12:22:52 +05:30
Raja SubramanianandGitHub 7954748d7a Data tracks (#4089) 
* WIP

* WIP

* Starting to add some signalling integration testing.

* Working tests.

* fix tests

* Forward data packets (#4096)

* WIP commit

* WIP

* WIP

* fix forwarding

* address PR comments

* move some methods from LocalParticipant to Participant interface

* handle subscription update

* add extensions and tests

* more packet tests

* add test for replace extension and fix a bug

* update protocol and add config
 2025-12-04 10:44:34 +05:30
Raja SubramanianandGitHub 7158d98366 log bucket growth (#4122) 2025-12-03 18:48:02 +05:30
Raja SubramanianandGitHub 04b35eb626 Release v1.9.6 (#4121) 
* Release v1.9.6

Marking v1.9.5 as scratched.

* typo
v1.9.6 		2025-12-01 12:41:10 +05:30
Raja SubramanianandGitHub ebdcead511 Update mediatransportutil to get bucket packet size limit. (#4120) 2025-12-01 11:31:37 +05:30
Raja SubramanianandGitHub 411b09f6ca Release v1.9.5 (#4119) 2025-12-01 10:51:07 +05:30
Raja SubramanianandGitHub 8dcf235a02 Update pion/ice - attempt to address tcp packet conn close hang (#4116) 2025-11-30 20:06:19 +05:30
Raja SubramanianandGitHub 64c651431e Update mediatransportutil (#4115) 
- New bucket API to pass in max packet size and sequence number offset
  and seequence number size generic type
- Move OWD estimator to mediatransportutil.
 2025-11-28 21:51:53 +05:30
Raja SubramanianandGitHub 0a2943bbc5 Clean up bits added to debug peer connection close hang. (#4114) 2025-11-28 10:30:39 +05:30
Raja SubramanianandGitHub 9c483a693a Use released version v1.8.41 of pion/sctp (#4113) 2025-11-27 21:01:00 +05:30
Raja SubramanianandGitHub 35c79a57d7 Update SCTP hash, had the wrong one in previous PR (#4111) 2025-11-27 15:52:45 +05:30
Raja SubramanianandGitHub e0fbbef1cd Update pion/sctp with RFC9260 revert (#4110) 2025-11-27 15:32:10 +05:30
Raja SubramanianandGitHub f3c8091797 Try SCTP with read deadline to unblock abort. (#4109) 2025-11-27 13:18:06 +05:30
Raja SubramanianandGitHub bd5382daaa Splitting transport close timeout logs. (#4108) 
After adding more fields in
https://github.com/livekit/livekit/pull/4105/files, it was not even
logging. Access to one of the added fields must have ended up waiting on
a lock and blocked.

Unfotunately, the deadlock fix in https://github.com/pion/ice/pull/840
did not address the peer connection close hang.

Splitting the logs so that the base log still happens. Ordering after
looking at the code and guessing what could still log to see if we get
more of the logs and learn more about the state and which lock ends up
the first blocking one.
 2025-11-27 10:02:01 +05:30
Raja SubramanianandGitHub 6d4154b8a7 Update pion/ice. (#4107) 
Hopefully this solves the peer connection close hang.
 2025-11-27 00:54:49 +05:30
Raja SubramanianandGitHub a6418ae219 Log more peer conenction state on close timeout. (#4105) 2025-11-26 19:58:31 +05:30
Raja SubramanianandGitHub 06d999748f Check for cancel on unsubscription/source track going away. (#4104) 2025-11-25 21:32:21 +05:30
Raja SubramanianandGitHub 7f10e18bac Record join/publish/subscribe cancellations. (#4102) 
To get better picture of success/failure rate.
 2025-11-25 14:06:02 +05:30
Raja SubramanianandGitHub 402936324c Clear stereo=1 if stereo is not enabled. (#4101) 2025-11-24 21:31:56 +05:30
Raja SubramanianandGitHub 70f6def39d Add checks for participant and sub-components close. (#4100) 
* Add checks for participant and sub-components close.

Looks like there might be some memory leak with participant sessions not
getting closed properly. Adding checks (to be cleaned up later) to see
if there is a consistent place where things might hang.

* init with right type

* Remove unnecessary goroutine, thank you @milos-lk

* clean up
 2025-11-24 18:07:33 +05:30
Raja SubramanianandGitHub ffbabcc772 Switch forwarding latency log to Debugw (#4098) 2025-11-23 11:22:10 +05:30
aleb_the_flashandGitHub 27d82a724e Fix "address" typo in transport logs (addddress → address) (#4097) 
Correct triple-d spelling of "address" field in transport logs.

I’m not sure whether this was intentional, but I noticed it
while creating Grafana queries and filters. This matters because
anyone filtering logs using the correct spelling may
unintentionally miss relevant data, leading to incomplete or
misleading analysis.
 2025-11-22 21:30:02 +05:30
Raja SubramanianandGitHub 37a06821e2 logger proto redaction. (#4090) 
Unfortunately, this could not be used for twirp/analytics redaction.

Probably worth writing a proto clone utility which will filter out based
on tags.
 2025-11-18 14:15:17 +05:30
cnderrauberandGitHub 54cf7d46c8 Control latency of lossy data channel (#4088) 
* Control latency of lossy data channel

* remove log

* test
 2025-11-18 16:30:16 +08:00
Raja SubramanianandGitHub 5175c1afa1 Lock x/tools at 0.37.0 (#4085) 2025-11-15 19:14:03 +05:30
Raja SubramanianandGitHub d510fff1e7 Downgrade x/tools to be able to make a release (#4084) v1.9.4 2025-11-15 18:56:22 +05:30
Raja SubramanianandGitHub c3ea5890d5 Prepare release v1.9.4. (#4083) 
- Removing x/tools replace for release script to work. Will add it after
  the release.
 2025-11-15 17:08:17 +05:30