cnderrauber
6d16f061de
Suppress negotiation timout log if signal disconnect ( #1433 )
...
* Suppress negotiation timout log if signal disconnect
* solve comment
2023-02-17 15:40:35 +08:00
cnderrauber
30834791fa
Fix data stats bitrate calculate ( #1432 )
2023-02-17 12:33:28 +08:00
David Zhao
c16eb66925
Fix race condition with unsubscribing from a republished track ( #1429 )
2023-02-16 15:11:23 -08:00
shishirng
8856ce6422
Bump up interval for sending telemetry stats to 30 seconds ( #1430 )
...
Signed-off-by: shishir gowda <shishir@livekit.io >
2023-02-16 15:53:58 -05:00
Raja Subramanian
14a94fe693
Fix panic when closing room ( #1428 )
2023-02-16 11:59:13 +05:30
Raja Subramanian
6cb46107c8
Delete signal de-duper. ( #1427 )
...
Not a good design. There is not an easy way to filter messages
before it hits media node. Without that, there is not a lot
of advantage.
And there are sequences that are not handled correctly in this
deleted implementation.
So, deleting code to prevent use.
2023-02-16 09:32:48 +05:30
David Colburn
10c53e0ebb
Move psrpc to protocol ( #1426 )
...
* move psrpc to protocol
* update checks
* update protocol
* update protocol ref
* blank line
2023-02-15 16:47:38 -08:00
Dan McFaul
1848a21eda
add configurable environment value ( #1421 )
...
* add configurable prometheus env label
* Update pkg/config/config.go
Co-authored-by: Mathew Kamkar <578302+matkam@users.noreply.github.com >
* Update cmd/server/main.go
Co-authored-by: Mathew Kamkar <578302+matkam@users.noreply.github.com >
* Update config-sample.yaml
Co-authored-by: Mathew Kamkar <578302+matkam@users.noreply.github.com >
* set config.Environment value to dev when in dev mode
* be more precise for config-sample
---------
Co-authored-by: Mathew Kamkar <578302+matkam@users.noreply.github.com >
2023-02-15 14:41:44 -07:00
cnderrauber
4367e93855
parallel writing for data packet broadcast ( #1425 )
2023-02-15 17:18:43 +08:00
David Zhao
4f6fda586c
Do not unsubscribe from track if it's been republished ( #1424 )
...
thank you @boks1971 for the debugging
2023-02-14 23:12:08 -08:00
Raja Subramanian
610c37f51a
Log switch point of feed SSRC for debugging. ( #1423 )
2023-02-15 12:34:40 +05:30
Paul Wells
24d8ad0da9
add compare function to timedversion ( #1422 )
...
* add compare function to timedversion
* cleanup
2023-02-14 21:05:55 -08:00
David Colburn
c133b9f2e3
fix panic when output is missing ( #1420 )
2023-02-14 10:23:46 -08:00
Raja Subramanian
3309c6fff0
Log feed SSRC ( #1419 )
2023-02-14 18:05:20 +05:30
Raja Subramanian
7857af4a66
Send unpublished callback unconditionally. ( #1418 )
...
Even if an add track has been queued and can be used immediately
when the previous incarnation unpublishes, send the unpublished
callback as the track was technically unpublished and republished.
The re-publish will pick the same track SID when the pending track
is queued as it will get the SID from an existing published track.
2023-02-14 13:17:54 +05:30
David Zhao
ea12e1477f
Update to go-redis v9. Fixed Redis cluster support ( #1415 )
...
* Update to go-redis v9. Fixed Redis cluster support
2023-02-12 22:22:21 -08:00
cnderrauber
e6eabb3a03
Prevent force tcp when client left between ice and dtls ( #1414 )
2023-02-13 13:57:50 +08:00
Raja Subramanian
2006359a97
move SDP to Debugw ( #1413 )
2023-02-12 22:56:43 +05:30
Raja Subramanian
481b4abbe5
Adding a debug log for track unpublish ( #1412 )
2023-02-11 09:38:58 +05:30
Mathew Kamkar
937256d89e
don't error when get tc stats fails ( #1386 )
2023-02-10 10:05:45 -08:00
Trey Hakanson
ce07914e44
Allow for strict ACKs to be disabled or subscriber peer connections ( #1410 )
2023-02-10 22:51:03 +05:30
David Zhao
3e08ff1043
version 1.3.4 ( #1411 )
v1.3.4
2023-02-09 23:31:42 -08:00
David Zhao
9a7ea7a2fa
Close previous request channels when during initial retry ( #1409 )
...
So we don't leave abandoned requests hanging on the media instance
2023-02-09 17:27:33 -08:00
renovate[bot]
aebec26ace
Update docker/build-push-action action to v4 ( #1405 )
...
Generated by renovateBot
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-02-09 15:39:05 -08:00
Dan McFaul
ad7e075c18
exit after panic ( #1392 )
...
* let panics crash
* Revert "let panics crash"
This reverts commit 8027cccadd .
* catch and log panics then os.Exit
* Recover only recovers, caller can exit
* only exit on pacic, still need Recover calls in goroutines
2023-02-09 16:33:22 -07:00
renovate[bot]
bee4bcc158
Update golang Docker tag to v1.20 ( #1403 )
...
Generated by renovateBot
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-02-09 15:29:53 -08:00
David Colburn
d2f0496223
list egress by id ( #1404 )
...
* list egress by id
* update proto ref
2023-02-09 00:10:54 -08:00
David Colburn
403c23ef82
Update renovate config ( #1399 )
...
* update renovate config
* group pion deps
* pion
2023-02-08 16:38:45 -08:00
Raja Subramanian
8a7478fd0e
Send stream state paused only when it is paused due to bandwidth limitation. ( #1391 )
...
* WIP commit
* Send stream state paused only when it is paused due to bandwidth limitation.
When stream is resumed after a stream is paused, an active update is
sent. Note that this means if there are intervening events like
mute/unmute between pause and resume, resume will be sent.
2023-02-08 20:03:32 +05:30
Raja Subramanian
95bc5b9849
Trigger max layer switch when downgrading. ( #1398 )
...
When downgrading (could be due to overshoot or opportunistically
locking to a higher layer), need to check if the max layer notification
needs to be done so that dynacast has the right max layer for the
participant corresponding to this downtrack.
2023-02-08 18:54:54 +05:30
cnderrauber
a04e7ce647
Fix panic by CreateSenderReport before bind completed ( #1397 )
2023-02-08 17:02:19 +08:00
Raja Subramanian
4d8def2eb7
Ignore errors on closed connection. ( #1396 )
2023-02-08 13:41:04 +05:30
Raja Subramanian
a1338b149c
Limit layer to num advertised. ( #1395 )
...
* Limit layer to num advertised.
Otherwise, this leads to invalid layer for non-simulcast tracks.
* need to subtrack 1
* fix test
2023-02-08 11:28:32 +05:30
cnderrauber
5161dba873
Filter mdns candidate if not mdns not enabled ( #1393 )
...
* Filter mdns candidate if not mdns not enabled
* log target
2023-02-08 10:27:24 +08:00
cnderrauber
2393a559c4
ensuare onPacket is not nil in rtcpreader callback ( #1390 )
2023-02-07 15:49:32 +08:00
cnderrauber
524e8985c6
silent frame for muted audio downtrack ( #1389 )
...
send silent frame for subscribe to a muted audio downtrack (opus)
write blank frames for red audio track
2023-02-07 15:29:38 +08:00
Raja Subramanian
9d32c6065d
Include track priority in de-duper checks ( #1388 )
2023-02-07 11:57:29 +05:30
cnderrauber
470a6fc9f1
Revert "Send silent frame for muted audio downtrack ( #1385 )" ( #1387 )
...
This reverts commit 0e699d6ed0 .
2023-02-07 14:10:39 +08:00
cnderrauber
0e699d6ed0
Send silent frame for muted audio downtrack ( #1385 )
...
* Send silent frame for muted audio downtrack
* Don't drop audio packets on pub muted
* don't inject blank audio frames for muted track
2023-02-07 13:12:50 +08:00
David Zhao
2851a8ac98
Improved robustness of subscription stack ( #1382 )
...
UpdateSubscription had a shortcoming where when it couldn't find the
participant, it ignored the request.
This PR further removes the reliance of current publisher state from
subscribers.
- SubscribeToTrack only takes in a trackID
- Introduced RoomTrackManager to maintain all published tracks to a room
- Added TrackUnpublished event to clearly indicate when a track has been removed
- SubscribeRequested event no longer include information about the publisher
2023-02-06 18:08:26 -08:00
Raja Subramanian
aaba402ada
Log messages processed by signal de-duper. ( #1384 )
...
This will get noisy. Will revert once we have some data to analyse.
2023-02-06 10:55:42 +05:30
cnderrauber
8b6dab780c
Add reconnect reason and signal rtt calculation ( #1381 )
...
* Add connect reason and signal rtt calculate
* Update protocol
* solve comment
2023-02-06 11:12:25 +08:00
Raja Subramanian
d67cdb6141
Return early if already subscribed. ( #1377 )
...
* Return early if already subscribed.
When already subscribed, returned `subTrack` is nil.
Return early, but do not return an error.
* check for nil subTrack
* check for nil as well
2023-02-04 13:47:35 +05:30
David Zhao
add9962655
Avoid triggering subscription failed handler unnecessarily. ( #1379 )
...
Certain errors are not at fault of the subscriber. For these errors
the reconciler should keep trying instead of giving up.
2023-02-03 01:06:04 -08:00
Raja Subramanian
1c697a073c
Re-initialise reference layer on a resume. ( #1376 )
...
* Re-initialise reference layer on a resume.
It is possible for a down track to resume from seeded state.
But, storing reference layer means it is storing something that
is dependent on up track. On a resume, if the up track does not
produce the reference layer, RTCP sender reports will not be sent.
So, remove that up track dependency and re-initialise the reference
layer on a resume.
This could affect A/V sync, but it should not be bad.
But, need to observe the effects.
* min difference of 1
2023-02-03 10:38:49 +05:30
David Zhao
15edd4d86e
Fix potentially nil access in buffer ( #1374 )
2023-02-02 14:56:07 -08:00
David Zhao
be4764b93b
Improve panic recovery to use participant logger. ( #1375 )
...
Also made IssueFullReconnect public
2023-02-02 14:55:50 -08:00
Raja Subramanian
501fb0860e
correct test name, only latest version is used ( #1373 )
2023-02-03 03:50:45 +05:30
Raja Subramanian
037ae572d9
Ensure older participant session update does not go out after a newer ( #1372 )
...
* Ensure older participant session update does not go out after a newer
session has joined.
* fix tests
* change comment
* do not send older version
2023-02-03 00:30:11 +05:30
David Zhao
8c513a1fc5
Improve SubscriptionManagerTest resilience ( #1370 )
...
This check fails on GH Actions occasionally due to timing differences.
2023-02-01 22:55:57 -08:00