Commit Graph

6619 Commits

Author SHA1 Message Date
Devon Hudson 7cbc010437 Bump opa-wasm and wasmtime 2026-01-27 11:36:49 -07:00
Quentin Gliech 378f24b118 Clear out last active IP on each sessions after 30 days (#5448) 2026-01-26 13:57:01 +01:00
Quentin Gliech dbdb2970ed Refactor inactive IP cleanup to use pagination
This should avoid dead many dead tuples when processing batches of
sessions to cleanup
2026-01-23 18:52:33 +01:00
Quentin Gliech b0e836eb44 Cleanup finished user/browser sessions (#5444) 2026-01-23 18:27:45 +01:00
Quentin Gliech 40cb5b0094 Cleanup finished OAuth 2.0 sessions (#5443) 2026-01-23 18:23:55 +01:00
Quentin Gliech f842f33a66 Re-enable the upstream authentication sessions cleanup job (#5439) 2026-01-23 18:17:11 +01:00
Quentin Gliech 8e6061bf04 Developer documentation about the various cleanup jobs (#5447) 2026-01-23 18:16:11 +01:00
Quentin Gliech af81a6cf78 Clean up leftovers in the database schema, part 2 (#5408) 2026-01-23 18:13:29 +01:00
Quentin Gliech 2d929278c1 Minor reword in the cleanup jobs documentation
Co-authored-by: Olivier 'reivilibre' <oliverw@element.io>
2026-01-23 17:43:13 +01:00
Quentin Gliech 69f324e4e8 Clean up unsupported threepids from already deactivated users (#5407) 2026-01-23 17:42:46 +01:00
Quentin Gliech bcdaae7103 Add cleanup jobs developer documentation 2026-01-23 16:37:52 +01:00
Quentin Gliech 5abc7f3f69 Include pagination params in the tracing fields of cleanup methods 2026-01-23 16:30:26 +01:00
Quentin Gliech 26caee7c99 Add cleanup jobs for inactive session IP addresses
This adds three new scheduled cleanup jobs that clear the last_active_ip
field from sessions that have been inactive for more than 30 days:

- CleanupInactiveOAuth2SessionIpsJob
- CleanupInactiveCompatSessionIpsJob
- CleanupInactiveUserSessionIpsJob

This helps with data minimization by not retaining IP addresses longer
2026-01-23 16:29:29 +01:00
Quentin Gliech 5bca9726b6 Add cleanup job for finished user sessions
Implements hard deletion of user/browser sessions that have been finished for more than 30 days, but only after all child sessions are cleaned up.

User sessions can only be deleted when no child sessions exist, ensuring backchannel logout propagation continues to work correctly.
2026-01-22 15:44:57 +01:00
Quentin Gliech 700007dbfd Fix FK constraint to preserve backchannel logout chain
Change compat_sessions.user_session_id FK from ON DELETE SET NULL to ON DELETE NO ACTION. This prevents deletion of user_sessions while compat_sessions still reference them, which is critical for backchannel logout propagation.

When an upstream IdP sends a backchannel logout, MAS must trace through:
  upstream_oauth_authorization_sessions -> user_sessions -> compat_sessions

If user_session_id links are SET NULL, logout propagation fails.

Uses two-step migration (DROP+ADD NOT VALID, then VALIDATE) to minimize table locking during deployment.
2026-01-22 15:44:57 +01:00
Quentin Gliech a66d652a70 Add cleanup job for finished OAuth2 sessions
Implements hard deletion of OAuth2 sessions that have been finished for more than 30 days, including their associated access and refresh tokens.
2026-01-22 15:44:56 +01:00
matrixbot ebcefc6ab5 Automatic merge back to main (#5441) 2026-01-21 16:04:19 +01:00
github-actions[bot] a7ca1d477b 1.10.0-rc.0 v1.10.0-rc.0 2026-01-21 14:56:30 +00:00
Quentin Gliech c4c001bbd5 Translations updates for main (#5440) 2026-01-21 15:55:30 +01:00
github-actions[bot] b089c35aa8 Translations updates 2026-01-21 14:45:17 +00:00
Quentin Gliech c29c4c3a5e Re-enable upstream OAuth session cleanup job
It should be safe to run now
2026-01-21 14:50:03 +01:00
Quentin Gliech 0486c6e05d Use the user_session_id on upstream authorisations for filtering instead
of authentications

This makes it one less table to read
2026-01-21 14:49:07 +01:00
Quentin Gliech c4c85978fe Add trigger and backfill for upstream OAuth user session tracking
Introduce a new trigger and a backfill migration to populate the
`user_session_id` column in `upstream_oauth_authorization_sessions`
based on `user_session_authentications`. This ensures historical data is
consistent and aids in backward compatibility.
2026-01-21 14:49:07 +01:00
Quentin Gliech 3834cbc105 Add index on the user_session_id foreign key for upstream auth sessions 2026-01-21 14:49:07 +01:00
Quentin Gliech da164a8c43 Do not cleanup upstream OAuth sessions that may still be useful (#5437) 2026-01-21 13:20:38 +01:00
Quentin Gliech 1bd11e7656 Disable cleanup of upstream OAuth sessions
This job is temporarily disabled due to pending database backfill work.
It will be re-enabled in a future release.
2026-01-21 12:28:19 +01:00
Quentin Gliech e095938da5 Only cleanup orphan upstream authorization sessions
This includes sessions that were never completed, and sessions where
user_session was cleaned up. This is to avoid breaking features like
OIDC Backchannel Logout after 30 days.
2026-01-21 12:25:42 +01:00
Quentin Gliech 39adf61089 Track user session authenticated through upstream auth sessions
This will help us avoid clearing upstream authorization sessions that
might still be useful to keep around for OIDC Backchannel Logouts
2026-01-21 12:19:05 +01:00
Quentin Gliech 1d536bca72 Consume upstream authorization sessions later in the user registration
flow

The main goal of this is to allow tracking user sessions authed by an
upstream authorization session, but this also has the nice side effect
of allowing 'going back' in browser history within the registration flow
2026-01-21 12:15:09 +01:00
Quentin Gliech 65b223a27f build(deps): bump @vector-im/compound-web from 8.3.1 to 8.3.5 in /frontend (#5431) 2026-01-20 16:41:46 +01:00
Quentin Gliech 2defccf6f0 Update test snapshots 2026-01-20 16:34:22 +01:00
Quentin Gliech 775cb13c23 Add support for the unstable prefix of MSC3824 (#5434) 2026-01-20 16:32:43 +01:00
Quentin Gliech c924ec24c9 Fix foreign key constraint when cleaning up upstream OAuth 2.0 links (#5432) 2026-01-20 16:30:41 +01:00
Quentin Gliech 2662631be2 Handle deleted and invalid post-auth actions (#5433) 2026-01-20 16:23:54 +01:00
olivierdelcroix bf7d2b53a0 add unstable prefix for MSC3824 2026-01-20 15:34:47 +01:00
Quentin Gliech 1fd5fb958f Handle deleted and invalid post-auth actions 2026-01-20 14:42:02 +01:00
Quentin Gliech 0d5cc65c52 Fix foreign key constraint when cleaning up upstream OAuth 2.0 links
https://sentry.tools.element.io/organizations/element/issues/11222736/
2026-01-20 14:29:27 +01:00
Quentin Gliech c5ce9d0307 Cleanup old completed jobs from the database (#5427) 2026-01-19 16:57:09 +01:00
dependabot[bot] 980e2ef1f0 build(deps): bump @vector-im/compound-web in /frontend
Bumps [@vector-im/compound-web](https://github.com/element-hq/compound-web) from 8.3.1 to 8.3.5.
- [Release notes](https://github.com/element-hq/compound-web/releases)
- [Commits](https://github.com/element-hq/compound-web/compare/v8.3.1...v8.3.5)

---
updated-dependencies:
- dependency-name: "@vector-im/compound-web"
  dependency-version: 8.3.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-01-19 15:52:41 +00:00
Quentin Gliech dbf3c351f4 Mark the next attempt foreign key as initially not valid 2026-01-19 15:44:22 +01:00
Quentin Gliech 5116d104e7 Cleanup old upstream OAuth sessions and unlinked links (#5426) 2026-01-19 15:14:12 +01:00
Quentin Gliech ffdf22ac19 Cleanup old email authentications & account recoveries (#5425) 2026-01-19 15:12:02 +01:00
Quentin Gliech a41975da0e Cleanup old OAuth grants (#5424) 2026-01-19 15:11:48 +01:00
Quentin Gliech 7272813925 Implement cleanup job for queue jobs
Add scheduled cleanup job that removes old completed and failed queue
jobs after 30 days. Jobs are kept for debugging purposes.

Includes migration to change the next_attempt_id FK constraint from NO
ACTION to SET NULL, allowing cleanup of retry chains without breaking
foreign key constraints.

One caveat is that cleanup is based on their creation time, *not* when
they got completed/failed. This means that if the job takes a long time
(as in, several days) to get scheduled, it might get cleared as soon as
it runs. This is fine for now, we may want to revisit this if we start
scheduling jobs far in the future
2026-01-19 12:25:04 +01:00
Quentin Gliech a721302201 Implement cleanup jobs for upstream OAuth sessions and links
Add two cleanup jobs scheduled hourly:

1. Upstream OAuth authorization sessions - removes sessions after 30 days
2. Orphaned upstream OAuth links - removes links after 7 days where user_id IS NULL. These are links created during upstream OAuth 2.0 login but never associated with a user
2026-01-19 12:24:13 +01:00
Quentin Gliech eec86dab90 build(deps-dev): bump knip from 5.75.1 to 5.80.0 in /frontend (#5403) 2026-01-17 11:11:29 +01:00
Quentin Gliech e8d52e3670 build(deps): bump EmbarkStudios/cargo-deny-action from 2.0.14 to 2.0.15 (#5404) 2026-01-17 11:05:29 +01:00
dependabot[bot] 58caaeca58 build(deps-dev): bump knip from 5.75.1 to 5.80.0 in /frontend
Bumps [knip](https://github.com/webpro-nl/knip/tree/HEAD/packages/knip) from 5.75.1 to 5.80.0.
- [Release notes](https://github.com/webpro-nl/knip/releases)
- [Commits](https://github.com/webpro-nl/knip/commits/knip@5.80.0/packages/knip)

---
updated-dependencies:
- dependency-name: knip
  dependency-version: 5.80.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-01-17 10:04:47 +00:00
Quentin Gliech 190fa2cdda build(deps): bump the tanstack-router group in /frontend with 3 updates (#5402) 2026-01-17 11:04:07 +01:00
Quentin Gliech ee3ca1a605 build(deps): bump the i18next group across 1 directory with 3 updates (#5412) 2026-01-17 11:03:26 +01:00