dandri/meshcore-analyzer
1
0
Fork 0
mirror of https://github.com/Kpa-clawbot/meshcore-analyzer.git synced 2026-08-14 08:09:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove duplicate return statement in _cumulativeRowOffsets() (#476)

Browse Source 
## Summary

Removes an unreachable duplicate `return offsets;` statement in the
`_cumulativeRowOffsets()` function in `packets.js`. The second return
was dead code found during review of PR #402.

## Changes

- **`public/packets.js`**: Removed the duplicate `return offsets;` on
what was line 1137 (the line immediately after the first, reachable
`return offsets;`)
- **`public/index.html`**: Cache buster bump

## Testing

This is a dead code removal — the duplicate return was unreachable. No
behavior change. No new tests needed as existing tests already cover
`_cumulativeRowOffsets()` behavior.

Fixes #447

Co-authored-by: you <you@example.com>
This commit is contained in:
Kpa-clawbot
2026-04-01 23:25:07 -07:00
committed by GitHub
co-authored by you
parent 9f14c74b3e
commit 6aef83c82a
2 changed files with 28 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files
public/index.html
+28 -28
View File
@@ -22,9 +22,9 @@
<meta name="twitter:title" content="CoreScope">
<meta name="twitter:description" content="Real-time MeshCore LoRa mesh network analyzer — live packet visualization, node tracking, channel decryption, and route analysis.">
<meta name="twitter:image" content="https://raw.githubusercontent.com/Kpa-clawbot/corescope/master/public/og-image.png">
<link rel="stylesheet" href="style.css?v=1775097293">
<link rel="stylesheet" href="home.css?v=1775097293">
<link rel="stylesheet" href="live.css?v=1775097293">
<link rel="stylesheet" href="style.css?v=1775110549">
<link rel="stylesheet" href="home.css?v=1775110549">
<link rel="stylesheet" href="live.css?v=1775110549">
<link rel="stylesheet" href="https://unpkg.com/leaflet@1.9.4/dist/leaflet.css"
integrity="sha256-p4NxAoJBhIIN+hmNHrzRCf9tD/miZyoHS5obTRR9BMY="
crossorigin="anonymous">
@@ -85,30 +85,30 @@
<main id="app" role="main"></main>
<script src="vendor/qrcode.js"></script>
<script src="roles.js?v=1775097293"></script>
<script src="customize.js?v=1775097293" onerror="console.error('Failed to load:', this.src)"></script>
<script src="region-filter.js?v=1775097293"></script>
<script src="hop-resolver.js?v=1775097293"></script>
<script src="hop-display.js?v=1775097293"></script>
<script src="app.js?v=1775097293"></script>
<script src="home.js?v=1775097293"></script>
<script src="packet-filter.js?v=1775097293"></script>
<script src="packets.js?v=1775097293"></script>
<script src="geo-filter-overlay.js?v=1775097293"></script>
<script src="map.js?v=1775097293" onerror="console.error('Failed to load:', this.src)"></script>
<script src="channels.js?v=1775097293" onerror="console.error('Failed to load:', this.src)"></script>
<script src="nodes.js?v=1775097293" onerror="console.error('Failed to load:', this.src)"></script>
<script src="traces.js?v=1775097293" onerror="console.error('Failed to load:', this.src)"></script>
<script src="analytics.js?v=1775097293" onerror="console.error('Failed to load:', this.src)"></script>
<script src="audio.js?v=1775097293" onerror="console.error('Failed to load:', this.src)"></script>
<script src="audio-v1-constellation.js?v=1775097293" onerror="console.error('Failed to load:', this.src)"></script>
<script src="audio-v2-constellation.js?v=1775097293" onerror="console.error('Failed to load:', this.src)"></script>
<script src="audio-lab.js?v=1775097293" onerror="console.error('Failed to load:', this.src)"></script>
<script src="live.js?v=1775097293" onerror="console.error('Failed to load:', this.src)"></script>
<script src="observers.js?v=1775097293" onerror="console.error('Failed to load:', this.src)"></script>
<script src="observer-detail.js?v=1775097293" onerror="console.error('Failed to load:', this.src)"></script>
<script src="compare.js?v=1775097293" onerror="console.error('Failed to load:', this.src)"></script>
<script src="node-analytics.js?v=1775097293" onerror="console.error('Failed to load:', this.src)"></script>
<script src="perf.js?v=1775097293" onerror="console.error('Failed to load:', this.src)"></script>
<script src="roles.js?v=1775110549"></script>
<script src="customize.js?v=1775110549" onerror="console.error('Failed to load:', this.src)"></script>
<script src="region-filter.js?v=1775110549"></script>
<script src="hop-resolver.js?v=1775110549"></script>
<script src="hop-display.js?v=1775110549"></script>
<script src="app.js?v=1775110549"></script>
<script src="home.js?v=1775110549"></script>
<script src="packet-filter.js?v=1775110549"></script>
<script src="packets.js?v=1775110549"></script>
<script src="geo-filter-overlay.js?v=1775110549"></script>
<script src="map.js?v=1775110549" onerror="console.error('Failed to load:', this.src)"></script>
<script src="channels.js?v=1775110549" onerror="console.error('Failed to load:', this.src)"></script>
<script src="nodes.js?v=1775110549" onerror="console.error('Failed to load:', this.src)"></script>
<script src="traces.js?v=1775110549" onerror="console.error('Failed to load:', this.src)"></script>
<script src="analytics.js?v=1775110549" onerror="console.error('Failed to load:', this.src)"></script>
<script src="audio.js?v=1775110549" onerror="console.error('Failed to load:', this.src)"></script>
<script src="audio-v1-constellation.js?v=1775110549" onerror="console.error('Failed to load:', this.src)"></script>
<script src="audio-v2-constellation.js?v=1775110549" onerror="console.error('Failed to load:', this.src)"></script>
<script src="audio-lab.js?v=1775110549" onerror="console.error('Failed to load:', this.src)"></script>
<script src="live.js?v=1775110549" onerror="console.error('Failed to load:', this.src)"></script>
<script src="observers.js?v=1775110549" onerror="console.error('Failed to load:', this.src)"></script>
<script src="observer-detail.js?v=1775110549" onerror="console.error('Failed to load:', this.src)"></script>
<script src="compare.js?v=1775110549" onerror="console.error('Failed to load:', this.src)"></script>
<script src="node-analytics.js?v=1775110549" onerror="console.error('Failed to load:', this.src)"></script>
<script src="perf.js?v=1775110549" onerror="console.error('Failed to load:', this.src)"></script>
</body>
</html>
public/packets.js
-1
View File
@@ -1134,7 +1134,6 @@
}
_cumulativeOffsetsCache = offsets;
return offsets;
return offsets;
}
function renderVisibleRows() {