mirror of
https://github.com/Kpa-clawbot/meshcore-analyzer.git
synced 2026-05-25 12:44:01 +00:00
Merge decision inbox: infra details, auto-close directive, test isolation, clipboard helper
- Consolidated 4 decisions from .squad/decisions/inbox/ into decisions.md - Removed duplicate entries (consolidated old versions) - Deleted inbox files after merge - All decisions now in single canonical location Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
@@ -0,0 +1,41 @@
|
||||
# Squad Decisions
|
||||
|
||||
## Active Decisions
|
||||
|
||||
### 2026-03-27T02:18:00Z: Infrastructure connection details
|
||||
**By:** Squad Coordinator (capturing session discoveries)
|
||||
**What:** Production VM connection details established this session:
|
||||
- **VM Name:** meshcore-vm
|
||||
- **Resource Group:** MESHCORE-WEST-RG
|
||||
- **Region:** westus2
|
||||
- **Size:** Standard_D2as_v5 (Linux)
|
||||
- **Public IP:** <VM_HOST>
|
||||
- **SSH User:** deploy
|
||||
- **SSH Command:** `ssh deploy@<VM_HOST>`
|
||||
- **Azure CLI:** v2.84.0 (upgraded from 2.11.1 this session — stale .pyc files cleared)
|
||||
- **CI Runner:** self-hosted on this same VM ("meshcore-vm")
|
||||
- **App path:** TBD (Hudson investigating via SSH)
|
||||
- **DB path:** TBD (Hudson investigating via SSH)
|
||||
**Why:** Team needs a single reference for prod access. Hudson, Hicks, and any future agent doing prod debugging needs these details.
|
||||
|
||||
### 2026-03-27T00:06:00Z: User directive — auto-close issues with commit messages
|
||||
**By:** User (via Copilot)
|
||||
**What:** Always use "Fixes #N" or "Closes #N" in commit messages so GitHub auto-closes issues on push. Don't just reference issue numbers in description text.
|
||||
**Why:** User request — captured for team memory. Previous commit listed issues but didn't trigger auto-close.
|
||||
|
||||
### 2026-03-26T19:10:00Z: User directive — test data isolation
|
||||
**By:** User (via Copilot)
|
||||
**What:** Seeded test data for E2E tests must be isolated — never pollute production or deployed containers. Use a separate test-only DB or inject via test harness. Seed before tests, tear down after. No seed scripts in Docker image.
|
||||
**Why:** User request — captured for team memory.
|
||||
|
||||
### 2026-03-26T19:00:00Z: Shared clipboard helper in roles.js
|
||||
**Author:** Newt
|
||||
**What:** Added `window.copyToClipboard(text, onSuccess, onFail)` to `roles.js` as the single clipboard implementation for all frontend modules.
|
||||
**Rationale:** Three separate files had their own clipboard logic (nodes.js, packets.js, customize.js) — one had no fallback, one used `prompt()`, one had a proper fallback. DRY principle: one implementation, used everywhere. The helper tries `navigator.clipboard.writeText()` first, falls back to hidden textarea + `document.execCommand('copy')` for Firefox and older browsers.
|
||||
**Impact:** Any future copy-to-clipboard needs should use `window.copyToClipboard()` instead of calling the Clipboard API directly.
|
||||
|
||||
## Governance
|
||||
|
||||
- All meaningful changes require team consensus
|
||||
- Document architectural decisions here
|
||||
- Keep history focused on work, decisions focused on direction
|
||||
Reference in New Issue
Block a user