Compare commits

..

6 Commits

Author SHA1 Message Date
you d8c76ca47a fix: customizer v2 type colors default to black (#514)
- Server: add default typeColors in handleConfigTheme matching roles.js
- Client: fall back to window.TYPE_COLORS before #000000 in _renderNodes
- Tests: verify typeColors defaults in theme API and frontend fallback
2026-04-03 05:25:57 +00:00
Kpa-clawbot 813b424ca1 fix: Show Neighbors uses affinity API for collision disambiguation (#484) — milestone 3 (#512)
## Summary

Replace broken client-side path walking in `selectReferenceNode()` with
server-side `/api/nodes/{pubkey}/neighbors` API call, fixing #484 where
Show Neighbors returned zero results due to hash collision
disambiguation failures.

**Fixes #484** | Part of #482

## What changed

### `public/map.js` — `selectReferenceNode()` function

**Before:** Client-side path walking — fetched
`/api/nodes/{pubkey}/paths`, walked each path to find hops adjacent to
the selected node by comparing full pubkeys. This fails on hash
collisions because path hops only contain short prefixes (1-2 bytes),
and the hop resolver can pick the wrong collision candidate.

**After:** Server-side affinity resolution — fetches
`/api/nodes/{pubkey}/neighbors?min_count=3` which uses the neighbor
affinity graph (built in M1/M2) to return disambiguated neighbors. For
ambiguous edges, all candidates are included in the neighbor set (better
to show extra markers than miss real neighbors).

**Fallback:** When the affinity API returns zero neighbors (cold start,
insufficient data), the function falls back to the original path-walking
approach. This ensures the feature works even before the affinity graph
has accumulated enough observations.

## Tests

4 new Playwright E2E tests (in both `test-show-neighbors.js` and
`test-e2e-playwright.js`):

1. **Happy path** — Verifies the `/neighbors` API is called and the
reference node UI activates
2. **Hash collision disambiguation** — Two nodes sharing prefix "C0" get
different neighbor sets via the affinity API (THE critical test for
#484)
3. **Fallback to path walking** — Empty affinity response triggers
fallback to `/paths` API
4. **Ambiguous candidates** — Ambiguous edge candidates are included in
the neighbor set

All tests use Playwright route interception to mock API responses,
testing the frontend logic independently of server state.

## Spec reference

See [neighbor-affinity-graph.md](docs/specs/neighbor-affinity-graph.md),
sections:
- "Replacing Show Neighbors on the map" (lines ~461-504)
- "Milestone 3: Show Neighbors Fix (#484)" (lines ~1136-1152)
- Test specs a & b (lines ~754-800)

---------

Co-authored-by: you <you@example.com>
2026-04-02 22:04:03 -07:00
Kpa-clawbot e66085092e feat: neighbor affinity API endpoints (#482) — milestone 2 (#508)
## Summary

Milestone 2 of the neighbor affinity graph (#482). Adds two API
endpoints that expose the neighbor graph built in M1 (PR #507).

### Endpoints

#### `GET /api/nodes/{pubkey}/neighbors`
Returns neighbors for a specific node with affinity scores.

**Query params:** `min_count` (default 1), `min_score` (default 0.0),
`include_ambiguous` (default true)

**Response shape:**
```json
{
  "node": "pubkey",
  "neighbors": [
    { "pubkey": "...", "prefix": "BB", "name": "...", "role": "repeater",
      "count": 847, "score": 0.95, "first_seen": "...", "last_seen": "...",
      "avg_snr": -8.2, "observers": ["obs1"], "ambiguous": false }
  ],
  "total_observations": 847
}
```

Ambiguous entries have `candidates` array; unresolved prefixes have
`unresolved: true`.

#### `GET /api/analytics/neighbor-graph`
Returns full graph summary for analytics/visualization.

**Query params:** `min_count` (default 5), `min_score` (default 0.1),
`region` (IATA code filter)

**Response shape:**
```json
{
  "nodes": [{ "pubkey": "...", "name": "...", "role": "...", "neighbor_count": 5 }],
  "edges": [{ "source": "...", "target": "...", "weight": 847, "score": 0.95, "ambiguous": false }],
  "stats": { "total_nodes": 42, "total_edges": 87, "ambiguous_edges": 3, "avg_cluster_size": 4.2 }
}
```

### Wiring
- `NeighborGraph` + `neighborMu` added to `Server` struct
- Lazy initialization: graph built on first API call, cached with 60s
TTL
- Node name/role lookups via existing `getCachedNodesAndPM()`
- Region filtering via existing `resolveRegionObservers()`

### Tests (15 tests)
- Empty graph, single neighbor, multiple neighbors (sorted by score)
- Ambiguous candidates with candidate list
- Unresolved prefix (orphan) with `unresolved: true`
- `min_count` filter, `min_score` filter, `include_ambiguous=false`
filter
- Unknown node returns 200 with empty neighbors
- Graph endpoint: empty, with edges, default min_count, ambiguous count
- Region filter (graceful when no store)
- Response shape validation (all required keys present)

All existing tests continue to pass.

Part of #482

---------

Co-authored-by: you <you@example.com>
2026-04-02 21:30:23 -07:00
Kpa-clawbot 4a56be0b48 feat: neighbor affinity graph builder (#482) — milestone 1 (#507)
## Summary

Milestone 1 of 7 for the neighbor affinity graph feature (#482).
Implements the core `NeighborGraph` data structure and
`BuildFromStore()` algorithm.

**Spec:** `docs/specs/neighbor-affinity-graph.md` on
`spec/482-neighbor-affinity` branch.

## What's Built

### `cmd/server/neighbor_graph.go`
- **`NeighborGraph` struct** — thread-safe (sync.RWMutex) in-memory
graph with edge map and per-node index
- **`BuildFromStore(*PacketStore)`** — iterates all packets/observations
to extract first-hop edges:
- `originator ↔ path[0]` for ADVERT packets only (originator identity
known)
  - `observer ↔ path[last]` for ALL packet types
  - Zero-hop ADVERTs: `originator ↔ observer` direct edge
- **Affinity scoring** — `score = min(1.0, count/100) × exp(-λ × hours)`
with 7-day half-life
- **Jaccard disambiguation** — resolves ambiguous hash prefixes using
mutual-neighbor overlap
- **Confidence threshold** — auto-resolve only when best ≥ 3×
second-best AND ≥ 3 observations
- **Transitivity poisoning guard** — only fully-resolved edges used as
evidence
- **Orphan prefix handling** — unknown prefixes stored as unresolved
markers
- **Cache management** — 60s TTL, `IsStale()` check for rebuild
triggering

### `cmd/server/neighbor_graph_test.go`
22 unit tests covering all spec requirements:

| Test | What it validates |
|------|-------------------|
| EmptyStore | Empty graph from empty store |
| AdvertSingleHopPath | Both edge types from single-hop ADVERT |
| AdvertMultiHopPath | originator↔path[0] + observer↔path[last] |
| AdvertZeroHop | Direct originator↔observer edge |
| NonAdvertEmptyPath | No edges from non-ADVERT empty path |
| NonAdvertOnlyObserverEdge | Only observer↔last_hop for non-ADVERTs |
| NonAdvertSingleHop | observer↔path[0] only |
| HashCollision | Ambiguous edge with candidates |
| JaccardScoring | Jaccard coefficient computation |
| ConfidenceAutoResolve | Auto-resolve when ratio ≥ 3× |
| EqualScoresAmbiguous | Remains ambiguous with equal scores |
| ObserverSelfEdgeGuard | No self-edges |
| OrphanPrefix | Unresolved prefix handling |
| AffinityScore_Fresh | Score ≈ 1.0 for fresh high-count |
| AffinityScore_Decayed | Score ≈ 0.5 at 7-day half-life |
| AffinityScore_LowCount | Score ≈ 0.05 for count=5 |
| AffinityScore_StaleAndLow | Score ≈ 0 for old low-count |
| CountAccumulation | 5 observations → count=5 |
| MultipleObservers | Observer set tracks all witnesses |
| TimeDecayOldObservations | Month-old edge scores very low |
| ADVERTOnlyConstraint | Non-ADVERTs don't create originator edges |
| CacheTTL | Stale detection works correctly |

## Not in scope (future milestones)
- API endpoints (M2)
- Frontend integration (M3-M5)
- Debug tools (M6)
- Analytics visualization (M7)

Part of #482

---------

Co-authored-by: you <you@example.com>
2026-04-02 21:14:58 -07:00
Kpa-clawbot 64745f89b1 feat: customizer v2 — event-driven state management (#502) (#503)
## Summary

Implements the customizer v2 per the [approved
spec](docs/specs/customizer-rework.md), replacing the v1 customizer's
scattered state management with a clean event-driven architecture.
Resolves #502.

## What Changed

### New: `public/customize-v2.js`
Complete rewrite of the customizer as a self-contained IIFE with:

- **Single localStorage key** (`cs-theme-overrides`) replacing 7
scattered keys
- **Three state layers:** server defaults (immutable) → user overrides
(delta) → effective config (computed)
- **Full data flow pipeline:** `write → read-back → merge → atomic
SITE_CONFIG assign → apply CSS → dispatch theme-changed`
- **Color picker optimistic CSS** (Decision #12): `input` events update
CSS directly for responsiveness; `change` events trigger the full
pipeline
- **Override indicator dots** (●) on each field — click to reset
individual values
- **Section-level override count badges** on tabs
- **Browser-local banner** in panel header: "These settings are saved in
your browser only"
- **Auto-save status indicator** in footer: "All changes saved" /
"Saving..." / "⚠️ Storage full"
- **Export/Import** with full shape validation (`validateShape()`)
- **Presets** flow through the standard pipeline
(`writeOverrides(presetData) → pipeline`)
- **One-time migration** from 7 legacy localStorage keys (exact field
mapping per spec)
- **Validation** on all writes: color format, opacity range, timestamp
enum values
- **QuotaExceededError handling** with visible user warning

### Modified: `public/app.js`
Replaced ~80 lines of inline theme application code with a 15-line
`_customizerV2.init(cfg)` call. The customizer v2 handles all merging,
CSS application, and global state updates.

### Modified: `public/index.html`
Swapped `customize.js` → `customize-v2.js` script tag.

### Added: `docs/specs/customizer-rework.md`
The full approved spec, included in the repo for reference.

## Migration

On first page load:
1. Checks if `cs-theme-overrides` already exists → skip if yes
2. Reads all 7 legacy keys (`meshcore-user-theme`,
`meshcore-timestamp-*`, `meshcore-heatmap-opacity`,
`meshcore-live-heatmap-opacity`)
3. Maps them to the new delta format per the spec's field-by-field
mapping
4. Writes to `cs-theme-overrides`, removes all legacy keys
5. Continues with normal init

Users with existing customizations will see them preserved
automatically.

## Dark/Light Mode

- `theme` section stores light mode overrides, `themeDark` stores dark
mode overrides
- `meshcore-theme` localStorage key remains **separate** (view
preference, not customization)
- Switching modes re-runs the full pipeline with the correct section

## Testing

- All existing tests pass (`test-packet-filter.js`, `test-aging.js`,
`test-frontend-helpers.js`)
- Old `customize.js` is NOT modified — left in place for reference but
no longer loaded

## Not in Scope (per spec)

- Undo/redo stack
- Cross-tab synchronization
- Server-side admin import endpoint
- Map config / geo-filter overrides

---------

Co-authored-by: you <you@example.com>
2026-04-02 21:14:38 -07:00
Kpa-clawbot c9c473279e fix: add null-guards to rAF callbacks in live page animations (#506)
## Summary

Fixes #483 — navigating away from the live page while matrix/hop
animations are running throws `TypeError: Cannot read properties of null
(reading 'addLayer')`.

## Root Cause

`destroy()` sets `animLayer = null` and `pathsLayer = null`, but
in-flight `requestAnimationFrame` callbacks continue executing and
attempt to call `.addTo(animLayer)` or `.removeLayer()` on the now-null
references.

The entry guards at the top of `drawMatrixLine()` and
`drawAnimatedLine()` only protect the initial call — not the rAF
continuation loops inside `tick()`, `fadeOut()`, `animateLine()`, and
`animateFade()`.

## Fix

Added null-guards (`if (!animLayer || !pathsLayer) return`) at the top
of all four rAF callback functions in `live.js`:

1. **`tick()`** (line ~2203) — matrix animation main loop
2. **`fadeOut()`** (line ~2253) — matrix animation fade-out
3. **`animateLine()`** (line ~2302) — standard line animation main loop
4. **`animateFade()`** (line ~2337) — standard line fade-out

This pattern is already used elsewhere in the file (e.g., line 1873,
1886) for the same purpose.

## Testing

- All unit tests pass (`npm test` — 0 failures)
- Go server tests pass (`cmd/server` + `cmd/ingestor`)
- Change is defensive only (early return on null) — no behavioral change
when layers exist

---------

Co-authored-by: you <you@example.com>
2026-04-02 20:14:52 -07:00
18 changed files with 5234 additions and 1606 deletions
+361
View File
@@ -0,0 +1,361 @@
package main
import (
"encoding/json"
"net/http"
"sort"
"strconv"
"strings"
"time"
"github.com/gorilla/mux"
)
// ─── Neighbor API response types ───────────────────────────────────────────────
type NeighborResponse struct {
Node string `json:"node"`
Neighbors []NeighborEntry `json:"neighbors"`
TotalObservations int `json:"total_observations"`
}
type NeighborEntry struct {
Pubkey *string `json:"pubkey"`
Prefix string `json:"prefix"`
Name *string `json:"name"`
Role *string `json:"role"`
Count int `json:"count"`
Score float64 `json:"score"`
FirstSeen string `json:"first_seen"`
LastSeen string `json:"last_seen"`
AvgSNR *float64 `json:"avg_snr"`
Observers []string `json:"observers"`
Ambiguous bool `json:"ambiguous"`
Unresolved bool `json:"unresolved,omitempty"`
Candidates []CandidateEntry `json:"candidates,omitempty"`
}
type CandidateEntry struct {
Pubkey string `json:"pubkey"`
Name string `json:"name"`
Role string `json:"role"`
}
type NeighborGraphResponse struct {
Nodes []GraphNode `json:"nodes"`
Edges []GraphEdge `json:"edges"`
Stats GraphStats `json:"stats"`
}
type GraphNode struct {
Pubkey string `json:"pubkey"`
Name string `json:"name"`
Role string `json:"role"`
NeighborCount int `json:"neighbor_count"`
}
type GraphEdge struct {
Source string `json:"source"`
Target string `json:"target"`
Weight int `json:"weight"`
Score float64 `json:"score"`
Bidirectional bool `json:"bidirectional"`
AvgSNR *float64 `json:"avg_snr"`
Ambiguous bool `json:"ambiguous"`
}
type GraphStats struct {
TotalNodes int `json:"total_nodes"`
TotalEdges int `json:"total_edges"`
AmbiguousEdges int `json:"ambiguous_edges"`
AvgClusterSize float64 `json:"avg_cluster_size"`
}
// ─── Graph accessor on Server ──────────────────────────────────────────────────
// getNeighborGraph returns the current neighbor graph, rebuilding if stale.
func (s *Server) getNeighborGraph() *NeighborGraph {
s.neighborMu.Lock()
defer s.neighborMu.Unlock()
if s.neighborGraph == nil || s.neighborGraph.IsStale() {
if s.store != nil {
s.neighborGraph = BuildFromStore(s.store)
} else {
s.neighborGraph = NewNeighborGraph()
}
}
return s.neighborGraph
}
// ─── Handlers ──────────────────────────────────────────────────────────────────
func (s *Server) handleNodeNeighbors(w http.ResponseWriter, r *http.Request) {
pubkey := strings.ToLower(mux.Vars(r)["pubkey"])
minCount := 1
if v := r.URL.Query().Get("min_count"); v != "" {
if n, err := strconv.Atoi(v); err == nil && n > 0 {
minCount = n
}
}
minScore := 0.0
if v := r.URL.Query().Get("min_score"); v != "" {
if f, err := strconv.ParseFloat(v, 64); err == nil {
minScore = f
}
}
includeAmbiguous := true
if v := r.URL.Query().Get("include_ambiguous"); v == "false" {
includeAmbiguous = false
}
graph := s.getNeighborGraph()
edges := graph.Neighbors(pubkey)
now := time.Now()
// Build node info lookup for names/roles.
nodeMap := s.buildNodeInfoMap()
var entries []NeighborEntry
totalObs := 0
for _, e := range edges {
score := e.Score(now)
if e.Count < minCount || score < minScore {
continue
}
if e.Ambiguous && !includeAmbiguous {
continue
}
totalObs += e.Count
// Determine the "other" node (neighbor of the queried pubkey).
neighborPK := e.NodeA
if strings.EqualFold(neighborPK, pubkey) {
neighborPK = e.NodeB
}
entry := NeighborEntry{
Prefix: e.Prefix,
Count: e.Count,
Score: score,
FirstSeen: e.FirstSeen.UTC().Format(time.RFC3339),
LastSeen: e.LastSeen.UTC().Format(time.RFC3339),
Ambiguous: e.Ambiguous,
Observers: observerList(e.Observers),
}
if e.SNRCount > 0 {
avg := e.AvgSNR()
entry.AvgSNR = &avg
}
if e.Ambiguous {
if len(e.Candidates) == 0 {
entry.Unresolved = true
}
for _, cpk := range e.Candidates {
ce := CandidateEntry{Pubkey: cpk}
if info, ok := nodeMap[strings.ToLower(cpk)]; ok {
ce.Name = info.Name
ce.Role = info.Role
}
entry.Candidates = append(entry.Candidates, ce)
}
} else if neighborPK != "" {
entry.Pubkey = &neighborPK
if info, ok := nodeMap[strings.ToLower(neighborPK)]; ok {
entry.Name = &info.Name
entry.Role = &info.Role
}
}
entries = append(entries, entry)
}
// Sort by score descending.
sort.Slice(entries, func(i, j int) bool {
return entries[i].Score > entries[j].Score
})
if entries == nil {
entries = []NeighborEntry{}
}
resp := NeighborResponse{
Node: pubkey,
Neighbors: entries,
TotalObservations: totalObs,
}
w.Header().Set("Content-Type", "application/json")
json.NewEncoder(w).Encode(resp)
}
func (s *Server) handleNeighborGraph(w http.ResponseWriter, r *http.Request) {
minCount := 5
if v := r.URL.Query().Get("min_count"); v != "" {
if n, err := strconv.Atoi(v); err == nil && n > 0 {
minCount = n
}
}
minScore := 0.1
if v := r.URL.Query().Get("min_score"); v != "" {
if f, err := strconv.ParseFloat(v, 64); err == nil {
minScore = f
}
}
region := r.URL.Query().Get("region")
roleFilter := strings.ToLower(r.URL.Query().Get("role"))
graph := s.getNeighborGraph()
allEdges := graph.AllEdges()
now := time.Now()
// Resolve region observers if filtering.
var regionObs map[string]bool
if region != "" && s.store != nil {
regionObs = s.store.resolveRegionObservers(region)
}
nodeMap := s.buildNodeInfoMap()
nodeSet := make(map[string]bool)
var filteredEdges []GraphEdge
ambiguousCount := 0
for _, e := range allEdges {
score := e.Score(now)
if e.Count < minCount || score < minScore {
continue
}
// Role filter: at least one endpoint must match the role.
if roleFilter != "" && nodeMap != nil {
aInfo, aOK := nodeMap[strings.ToLower(e.NodeA)]
bInfo, bOK := nodeMap[strings.ToLower(e.NodeB)]
aMatch := aOK && strings.EqualFold(aInfo.Role, roleFilter)
bMatch := bOK && strings.EqualFold(bInfo.Role, roleFilter)
if !aMatch && !bMatch {
continue
}
}
// Region filter: at least one observer must be in the region.
if regionObs != nil {
match := false
for obs := range e.Observers {
if regionObs[obs] {
match = true
break
}
}
if !match {
continue
}
}
ge := GraphEdge{
Source: e.NodeA,
Target: e.NodeB,
Weight: e.Count,
Score: score,
Bidirectional: true,
Ambiguous: e.Ambiguous,
}
if e.SNRCount > 0 {
avg := e.AvgSNR()
ge.AvgSNR = &avg
}
if e.Ambiguous {
ambiguousCount++
// For ambiguous edges, use prefix as target.
if e.NodeB == "" {
ge.Target = "prefix:" + e.Prefix
}
}
filteredEdges = append(filteredEdges, ge)
// Track nodes.
if e.NodeA != "" && !strings.HasPrefix(e.NodeA, "prefix:") {
nodeSet[e.NodeA] = true
}
if e.NodeB != "" && !strings.HasPrefix(e.NodeB, "prefix:") {
nodeSet[e.NodeB] = true
}
}
// Build node list.
// Count neighbors per node from filtered edges.
neighborCounts := make(map[string]int)
for _, ge := range filteredEdges {
neighborCounts[ge.Source]++
neighborCounts[ge.Target]++
}
var nodes []GraphNode
for pk := range nodeSet {
gn := GraphNode{Pubkey: pk, NeighborCount: neighborCounts[pk]}
if info, ok := nodeMap[strings.ToLower(pk)]; ok {
gn.Name = info.Name
gn.Role = info.Role
}
nodes = append(nodes, gn)
}
if filteredEdges == nil {
filteredEdges = []GraphEdge{}
}
if nodes == nil {
nodes = []GraphNode{}
}
avgCluster := 0.0
if len(nodes) > 0 {
avgCluster = float64(len(filteredEdges)*2) / float64(len(nodes))
}
resp := NeighborGraphResponse{
Nodes: nodes,
Edges: filteredEdges,
Stats: GraphStats{
TotalNodes: len(nodes),
TotalEdges: len(filteredEdges),
AmbiguousEdges: ambiguousCount,
AvgClusterSize: avgCluster,
},
}
w.Header().Set("Content-Type", "application/json")
json.NewEncoder(w).Encode(resp)
}
// ─── Helpers ───────────────────────────────────────────────────────────────────
func observerList(m map[string]bool) []string {
if len(m) == 0 {
return []string{}
}
out := make([]string, 0, len(m))
for k := range m {
out = append(out, k)
}
sort.Strings(out)
return out
}
// buildNodeInfoMap returns a map of lowercase pubkey → nodeInfo for name/role lookups.
func (s *Server) buildNodeInfoMap() map[string]nodeInfo {
if s.store == nil {
return nil
}
nodes, _ := s.store.getCachedNodesAndPM()
m := make(map[string]nodeInfo, len(nodes))
for _, n := range nodes {
m[strings.ToLower(n.PublicKey)] = n
}
return m
}
+396
View File
@@ -0,0 +1,396 @@
package main
import (
"encoding/json"
"net/http"
"net/http/httptest"
"testing"
"time"
"github.com/gorilla/mux"
)
// ─── Helpers ───────────────────────────────────────────────────────────────────
// makeTestServer creates a Server with a pre-built neighbor graph for testing.
func makeTestServer(graph *NeighborGraph) *Server {
srv := &Server{
perfStats: NewPerfStats(),
}
srv.neighborGraph = graph
return srv
}
// makeTestGraph creates a graph with given edges for testing.
func makeTestGraph(edges ...*NeighborEdge) *NeighborGraph {
g := NewNeighborGraph()
g.mu.Lock()
for _, e := range edges {
key := makeEdgeKey(e.NodeA, e.NodeB)
if e.NodeB == "" {
key = makeEdgeKey(e.NodeA, "prefix:"+e.Prefix)
}
e.NodeA = key.A
if e.NodeB != "" {
e.NodeB = key.B
}
g.edges[key] = e
g.byNode[key.A] = append(g.byNode[key.A], e)
if key.B != "" && key.B != key.A {
g.byNode[key.B] = append(g.byNode[key.B], e)
}
}
g.builtAt = time.Now()
g.mu.Unlock()
return g
}
func newEdge(a, b, prefix string, count int, lastSeen time.Time) *NeighborEdge {
return &NeighborEdge{
NodeA: a,
NodeB: b,
Prefix: prefix,
Count: count,
FirstSeen: lastSeen.Add(-24 * time.Hour),
LastSeen: lastSeen,
Observers: map[string]bool{"obs1": true},
SNRSum: -8.0,
SNRCount: 1,
}
}
func newAmbiguousEdge(knownPK, prefix string, candidates []string, count int, lastSeen time.Time) *NeighborEdge {
return &NeighborEdge{
NodeA: knownPK,
NodeB: "",
Prefix: prefix,
Count: count,
FirstSeen: lastSeen.Add(-24 * time.Hour),
LastSeen: lastSeen,
Observers: map[string]bool{"obs1": true},
Ambiguous: true,
Candidates: candidates,
}
}
func serveRequest(srv *Server, method, path string) *httptest.ResponseRecorder {
router := mux.NewRouter()
router.HandleFunc("/api/nodes/{pubkey}/neighbors", srv.handleNodeNeighbors).Methods("GET")
router.HandleFunc("/api/analytics/neighbor-graph", srv.handleNeighborGraph).Methods("GET")
req := httptest.NewRequest(method, path, nil)
rr := httptest.NewRecorder()
router.ServeHTTP(rr, req)
return rr
}
// ─── Tests: /api/nodes/{pubkey}/neighbors ──────────────────────────────────────
func TestNeighborAPI_EmptyGraph(t *testing.T) {
srv := makeTestServer(makeTestGraph())
rr := serveRequest(srv, "GET", "/api/nodes/deadbeef/neighbors")
if rr.Code != http.StatusOK {
t.Fatalf("expected 200, got %d", rr.Code)
}
var resp NeighborResponse
if err := json.Unmarshal(rr.Body.Bytes(), &resp); err != nil {
t.Fatalf("bad JSON: %v", err)
}
if resp.Node != "deadbeef" {
t.Errorf("node = %q, want deadbeef", resp.Node)
}
if len(resp.Neighbors) != 0 {
t.Errorf("expected 0 neighbors, got %d", len(resp.Neighbors))
}
if resp.TotalObservations != 0 {
t.Errorf("expected 0 observations, got %d", resp.TotalObservations)
}
}
func TestNeighborAPI_SingleNeighbor(t *testing.T) {
now := time.Now()
e := newEdge("aaaa", "bbbb", "bb", 50, now)
srv := makeTestServer(makeTestGraph(e))
rr := serveRequest(srv, "GET", "/api/nodes/aaaa/neighbors")
if rr.Code != http.StatusOK {
t.Fatalf("expected 200, got %d", rr.Code)
}
var resp NeighborResponse
json.Unmarshal(rr.Body.Bytes(), &resp)
if len(resp.Neighbors) != 1 {
t.Fatalf("expected 1 neighbor, got %d", len(resp.Neighbors))
}
n := resp.Neighbors[0]
if n.Pubkey == nil || *n.Pubkey != "bbbb" {
t.Errorf("expected pubkey bbbb, got %v", n.Pubkey)
}
if n.Count != 50 {
t.Errorf("expected count 50, got %d", n.Count)
}
if n.Score <= 0 {
t.Errorf("expected positive score, got %f", n.Score)
}
if n.Ambiguous {
t.Error("expected not ambiguous")
}
}
func TestNeighborAPI_MultipleNeighbors(t *testing.T) {
now := time.Now()
e1 := newEdge("aaaa", "bbbb", "bb", 100, now)
e2 := newEdge("aaaa", "cccc", "cc", 10, now)
srv := makeTestServer(makeTestGraph(e1, e2))
rr := serveRequest(srv, "GET", "/api/nodes/aaaa/neighbors")
var resp NeighborResponse
json.Unmarshal(rr.Body.Bytes(), &resp)
if len(resp.Neighbors) != 2 {
t.Fatalf("expected 2 neighbors, got %d", len(resp.Neighbors))
}
// Should be sorted by score descending.
if resp.Neighbors[0].Score < resp.Neighbors[1].Score {
t.Error("expected sorted by score descending")
}
if resp.TotalObservations != 110 {
t.Errorf("expected 110 total observations, got %d", resp.TotalObservations)
}
}
func TestNeighborAPI_AmbiguousCandidates(t *testing.T) {
now := time.Now()
e := newAmbiguousEdge("aaaa", "c0", []string{"c0de01", "c0de02"}, 12, now)
srv := makeTestServer(makeTestGraph(e))
rr := serveRequest(srv, "GET", "/api/nodes/aaaa/neighbors")
var resp NeighborResponse
json.Unmarshal(rr.Body.Bytes(), &resp)
if len(resp.Neighbors) != 1 {
t.Fatalf("expected 1 neighbor, got %d", len(resp.Neighbors))
}
n := resp.Neighbors[0]
if !n.Ambiguous {
t.Error("expected ambiguous")
}
if n.Pubkey != nil {
t.Errorf("expected nil pubkey for ambiguous, got %v", n.Pubkey)
}
if len(n.Candidates) != 2 {
t.Fatalf("expected 2 candidates, got %d", len(n.Candidates))
}
}
func TestNeighborAPI_UnresolvedPrefix(t *testing.T) {
now := time.Now()
e := newAmbiguousEdge("aaaa", "ff", []string{}, 3, now)
srv := makeTestServer(makeTestGraph(e))
rr := serveRequest(srv, "GET", "/api/nodes/aaaa/neighbors")
var resp NeighborResponse
json.Unmarshal(rr.Body.Bytes(), &resp)
if len(resp.Neighbors) != 1 {
t.Fatalf("expected 1 neighbor, got %d", len(resp.Neighbors))
}
n := resp.Neighbors[0]
if !n.Unresolved {
t.Error("expected unresolved=true")
}
if len(n.Candidates) != 0 {
t.Error("expected empty candidates for unresolved")
}
}
func TestNeighborAPI_MinCountFilter(t *testing.T) {
now := time.Now()
e1 := newEdge("aaaa", "bbbb", "bb", 100, now)
e2 := newEdge("aaaa", "cccc", "cc", 2, now)
srv := makeTestServer(makeTestGraph(e1, e2))
rr := serveRequest(srv, "GET", "/api/nodes/aaaa/neighbors?min_count=10")
var resp NeighborResponse
json.Unmarshal(rr.Body.Bytes(), &resp)
if len(resp.Neighbors) != 1 {
t.Fatalf("expected 1 neighbor after min_count filter, got %d", len(resp.Neighbors))
}
if *resp.Neighbors[0].Pubkey != "bbbb" {
t.Error("expected bbbb to survive filter")
}
}
func TestNeighborAPI_MinScoreFilter(t *testing.T) {
now := time.Now()
e1 := newEdge("aaaa", "bbbb", "bb", 100, now) // score ~1.0
e2 := newEdge("aaaa", "cccc", "cc", 1, now.Add(-30*24*time.Hour)) // very low score
srv := makeTestServer(makeTestGraph(e1, e2))
rr := serveRequest(srv, "GET", "/api/nodes/aaaa/neighbors?min_score=0.5")
var resp NeighborResponse
json.Unmarshal(rr.Body.Bytes(), &resp)
if len(resp.Neighbors) != 1 {
t.Fatalf("expected 1 neighbor after min_score filter, got %d", len(resp.Neighbors))
}
}
func TestNeighborAPI_ExcludeAmbiguous(t *testing.T) {
now := time.Now()
e1 := newEdge("aaaa", "bbbb", "bb", 50, now)
e2 := newAmbiguousEdge("aaaa", "c0", []string{"c0de01"}, 10, now)
srv := makeTestServer(makeTestGraph(e1, e2))
rr := serveRequest(srv, "GET", "/api/nodes/aaaa/neighbors?include_ambiguous=false")
var resp NeighborResponse
json.Unmarshal(rr.Body.Bytes(), &resp)
if len(resp.Neighbors) != 1 {
t.Fatalf("expected 1 non-ambiguous neighbor, got %d", len(resp.Neighbors))
}
}
func TestNeighborAPI_UnknownNode(t *testing.T) {
now := time.Now()
e := newEdge("aaaa", "bbbb", "bb", 50, now)
srv := makeTestServer(makeTestGraph(e))
rr := serveRequest(srv, "GET", "/api/nodes/unknown1234/neighbors")
if rr.Code != http.StatusOK {
t.Fatalf("expected 200 for unknown node, got %d", rr.Code)
}
var resp NeighborResponse
json.Unmarshal(rr.Body.Bytes(), &resp)
if len(resp.Neighbors) != 0 {
t.Errorf("expected 0 neighbors for unknown node, got %d", len(resp.Neighbors))
}
}
// ─── Tests: /api/analytics/neighbor-graph ──────────────────────────────────────
func TestNeighborGraphAPI_EmptyGraph(t *testing.T) {
srv := makeTestServer(makeTestGraph())
rr := serveRequest(srv, "GET", "/api/analytics/neighbor-graph")
if rr.Code != http.StatusOK {
t.Fatalf("expected 200, got %d", rr.Code)
}
var resp NeighborGraphResponse
json.Unmarshal(rr.Body.Bytes(), &resp)
if len(resp.Edges) != 0 {
t.Errorf("expected 0 edges, got %d", len(resp.Edges))
}
if resp.Stats.TotalEdges != 0 {
t.Errorf("expected 0 total edges, got %d", resp.Stats.TotalEdges)
}
if resp.Stats.TotalNodes != 0 {
t.Errorf("expected 0 total nodes, got %d", resp.Stats.TotalNodes)
}
}
func TestNeighborGraphAPI_WithEdges(t *testing.T) {
now := time.Now()
e1 := newEdge("aaaa", "bbbb", "bb", 100, now)
e2 := newEdge("bbbb", "cccc", "cc", 50, now)
srv := makeTestServer(makeTestGraph(e1, e2))
rr := serveRequest(srv, "GET", "/api/analytics/neighbor-graph?min_count=1&min_score=0")
var resp NeighborGraphResponse
json.Unmarshal(rr.Body.Bytes(), &resp)
if len(resp.Edges) != 2 {
t.Fatalf("expected 2 edges, got %d", len(resp.Edges))
}
if resp.Stats.TotalNodes != 3 {
t.Errorf("expected 3 nodes, got %d", resp.Stats.TotalNodes)
}
if resp.Stats.TotalEdges != 2 {
t.Errorf("expected 2 total edges, got %d", resp.Stats.TotalEdges)
}
}
func TestNeighborGraphAPI_MinCountDefault(t *testing.T) {
now := time.Now()
e1 := newEdge("aaaa", "bbbb", "bb", 100, now) // passes default min_count=5
e2 := newEdge("aaaa", "cccc", "cc", 2, now) // fails default min_count=5
srv := makeTestServer(makeTestGraph(e1, e2))
rr := serveRequest(srv, "GET", "/api/analytics/neighbor-graph")
var resp NeighborGraphResponse
json.Unmarshal(rr.Body.Bytes(), &resp)
if len(resp.Edges) != 1 {
t.Fatalf("expected 1 edge with default min_count=5, got %d", len(resp.Edges))
}
}
func TestNeighborGraphAPI_AmbiguousEdgesCount(t *testing.T) {
now := time.Now()
e1 := newEdge("aaaa", "bbbb", "bb", 100, now)
e2 := newAmbiguousEdge("aaaa", "c0", []string{"c0de01", "c0de02"}, 50, now)
srv := makeTestServer(makeTestGraph(e1, e2))
rr := serveRequest(srv, "GET", "/api/analytics/neighbor-graph?min_count=1&min_score=0")
var resp NeighborGraphResponse
json.Unmarshal(rr.Body.Bytes(), &resp)
if resp.Stats.AmbiguousEdges != 1 {
t.Errorf("expected 1 ambiguous edge, got %d", resp.Stats.AmbiguousEdges)
}
}
func TestNeighborGraphAPI_RegionFilter(t *testing.T) {
now := time.Now()
// Edge with observer "obs-sjc" — would match region SJC if we had region resolution.
// Without a store, region filtering returns nothing (no observers match).
e1 := newEdge("aaaa", "bbbb", "bb", 100, now)
srv := makeTestServer(makeTestGraph(e1))
// No store → region filter has no observers → filters everything out.
rr := serveRequest(srv, "GET", "/api/analytics/neighbor-graph?region=SJC&min_count=1&min_score=0")
var resp NeighborGraphResponse
json.Unmarshal(rr.Body.Bytes(), &resp)
// With no store, regionObs is nil so filter is skipped → all edges returned.
// Actually: region="" when store is nil → regionObs stays nil → no filtering.
// Wait, we set region=SJC and store is nil → resolveRegionObservers won't be called
// because s.store is nil. So regionObs is nil → filter not applied.
// Let's just check it doesn't crash.
if rr.Code != http.StatusOK {
t.Fatalf("expected 200, got %d", rr.Code)
}
}
func TestNeighborGraphAPI_ResponseShape(t *testing.T) {
now := time.Now()
e := newEdge("aaaa", "bbbb", "bb", 100, now)
srv := makeTestServer(makeTestGraph(e))
rr := serveRequest(srv, "GET", "/api/analytics/neighbor-graph?min_count=1&min_score=0")
var raw map[string]interface{}
if err := json.Unmarshal(rr.Body.Bytes(), &raw); err != nil {
t.Fatalf("bad JSON: %v", err)
}
// Verify top-level keys.
for _, key := range []string{"nodes", "edges", "stats"} {
if _, ok := raw[key]; !ok {
t.Errorf("missing key %q in response", key)
}
}
// Verify stats keys.
stats := raw["stats"].(map[string]interface{})
for _, key := range []string{"total_nodes", "total_edges", "ambiguous_edges", "avg_cluster_size"} {
if _, ok := stats[key]; !ok {
t.Errorf("missing stats key %q", key)
}
}
}
+500
View File
@@ -0,0 +1,500 @@
package main
import (
"encoding/json"
"math"
"strings"
"sync"
"time"
)
// ─── Constants ─────────────────────────────────────────────────────────────────
const (
// After this many observations, count contributes max weight to the score.
affinitySaturationCount = 100
// Time-decay half-life: 7 days.
affinityHalfLifeHours = 168.0
// Cache TTL for the built graph.
neighborGraphTTL = 60 * time.Second
// Auto-resolve confidence: best must be >= this factor × second-best.
affinityConfidenceRatio = 3.0
// Minimum observation count to auto-resolve.
affinityMinObservations = 3
)
// affinityLambda = ln(2) / half-life-hours, precomputed.
var affinityLambda = math.Ln2 / affinityHalfLifeHours
// ─── Data model ────────────────────────────────────────────────────────────────
// edgeKey is the canonical key for an undirected edge (A < B lexicographically).
// For ambiguous edges where NodeB is unknown, B is the raw prefix prefixed with "prefix:".
type edgeKey struct {
A, B string
}
func makeEdgeKey(a, b string) edgeKey {
if a > b {
a, b = b, a
}
return edgeKey{A: a, B: b}
}
// NeighborEdge represents a weighted, undirected first-hop neighbor relationship.
type NeighborEdge struct {
NodeA string // full pubkey
NodeB string // full pubkey, or "" if unresolved/ambiguous
Prefix string // raw hop prefix that established this edge
Count int // total observations
FirstSeen time.Time //
LastSeen time.Time //
SNRSum float64 // running sum for average
SNRCount int // how many SNR samples
Observers map[string]bool // observer pubkeys that witnessed
Ambiguous bool // multiple candidates or zero candidates
Candidates []string // candidate pubkeys when ambiguous
Resolved bool // true if auto-resolved via Jaccard
}
// Score computes the affinity score at query time with time decay.
func (e *NeighborEdge) Score(now time.Time) float64 {
countFactor := math.Min(1.0, float64(e.Count)/float64(affinitySaturationCount))
hoursSince := now.Sub(e.LastSeen).Hours()
if hoursSince < 0 {
hoursSince = 0
}
decay := math.Exp(-affinityLambda * hoursSince)
return countFactor * decay
}
// AvgSNR returns the average SNR, or 0 if no samples.
func (e *NeighborEdge) AvgSNR() float64 {
if e.SNRCount == 0 {
return 0
}
return e.SNRSum / float64(e.SNRCount)
}
// ─── NeighborGraph ─────────────────────────────────────────────────────────────
// NeighborGraph is a cached, in-memory first-hop neighbor affinity graph.
type NeighborGraph struct {
mu sync.RWMutex
edges map[edgeKey]*NeighborEdge
byNode map[string][]*NeighborEdge // pubkey → edges involving this node
builtAt time.Time
}
// NewNeighborGraph creates an empty graph.
func NewNeighborGraph() *NeighborGraph {
return &NeighborGraph{
edges: make(map[edgeKey]*NeighborEdge),
byNode: make(map[string][]*NeighborEdge),
}
}
// Neighbors returns all edges for a given node pubkey.
func (g *NeighborGraph) Neighbors(pubkey string) []*NeighborEdge {
g.mu.RLock()
defer g.mu.RUnlock()
return g.byNode[strings.ToLower(pubkey)]
}
// AllEdges returns all edges in the graph.
func (g *NeighborGraph) AllEdges() []*NeighborEdge {
g.mu.RLock()
defer g.mu.RUnlock()
out := make([]*NeighborEdge, 0, len(g.edges))
for _, e := range g.edges {
out = append(out, e)
}
return out
}
// IsStale returns true if the graph cache has expired.
func (g *NeighborGraph) IsStale() bool {
g.mu.RLock()
defer g.mu.RUnlock()
return g.builtAt.IsZero() || time.Since(g.builtAt) > neighborGraphTTL
}
// ─── Builder ───────────────────────────────────────────────────────────────────
// BuildFromStore constructs the neighbor graph from all packets in the store.
// The store's read-lock must NOT be held by the caller.
func BuildFromStore(store *PacketStore) *NeighborGraph {
g := NewNeighborGraph()
store.mu.RLock()
// Snapshot what we need under lock.
packets := make([]*StoreTx, len(store.packets))
copy(packets, store.packets)
store.mu.RUnlock()
// Build prefix map for candidate resolution.
// Use cached nodes+PM (avoids DB call if cache is fresh).
_, pm := store.getCachedNodesAndPM()
// Phase 1: Extract edges from every transmission + observation.
for _, tx := range packets {
isAdvert := tx.PayloadType != nil && *tx.PayloadType == 4
fromNode := "" // originator pubkey (from byNode index key)
// Find the originator pubkey — it's the key in store.byNode.
// StoreTx doesn't store from_node directly; we find it via decoded JSON
// or the byNode index. However, iterating byNode is expensive.
// The originator pubkey is in the decoded JSON "from_node" field,
// but parsing JSON per tx is expensive too.
// Actually, let's look at how byNode is keyed.
// Looking at store.go, byNode maps pubkey → transmissions where that
// pubkey is the "from" node. We need the reverse: tx → from_node.
// The from_node is embedded in DecodedJSON.
// For efficiency, let's extract it once.
fromNode = extractFromNode(tx)
for _, obs := range tx.Observations {
path := parsePathJSON(obs.PathJSON)
observerPK := strings.ToLower(obs.ObserverID)
if len(path) == 0 {
// Zero-hop
if isAdvert && fromNode != "" {
fromLower := strings.ToLower(fromNode)
if fromLower != observerPK { // self-edge guard
g.upsertEdge(fromLower, observerPK, "", observerPK, obs.SNR, parseTimestamp(obs.Timestamp))
}
}
continue
}
// Edge 1: originator ↔ path[0] — ADVERTs only
if isAdvert && fromNode != "" {
firstHop := strings.ToLower(path[0])
fromLower := strings.ToLower(fromNode)
if fromLower != firstHop { // self-edge guard (shouldn't happen but spec says check)
candidates := pm.m[firstHop]
g.upsertEdgeWithCandidates(fromLower, firstHop, candidates, observerPK, obs.SNR, parseTimestamp(obs.Timestamp))
}
}
// Edge 2: observer ↔ path[last] — ALL packet types
lastHop := strings.ToLower(path[len(path)-1])
if observerPK != lastHop { // self-edge guard
candidates := pm.m[lastHop]
g.upsertEdgeWithCandidates(observerPK, lastHop, candidates, observerPK, obs.SNR, parseTimestamp(obs.Timestamp))
}
}
}
// Phase 2: Disambiguation via Jaccard similarity.
g.disambiguate()
g.mu.Lock()
g.builtAt = time.Now()
g.mu.Unlock()
return g
}
// extractFromNode pulls the from_node pubkey from a StoreTx.
// It looks in DecodedJSON for "from_node" or "from".
func extractFromNode(tx *StoreTx) string {
if tx.DecodedJSON == "" {
return ""
}
// Fast path: look for "from_node" key.
var decoded map[string]interface{}
if err := jsonUnmarshalFast(tx.DecodedJSON, &decoded); err != nil {
return ""
}
if v, ok := decoded["from_node"]; ok {
if s, ok := v.(string); ok {
return s
}
}
if v, ok := decoded["from"]; ok {
if s, ok := v.(string); ok {
return s
}
}
return ""
}
// jsonUnmarshalFast is a thin wrapper; could be optimized later.
func jsonUnmarshalFast(data string, v interface{}) error {
return json.Unmarshal([]byte(data), v)
}
// upsertEdge adds/updates an edge between two fully-known pubkeys.
func (g *NeighborGraph) upsertEdge(pubkeyA, pubkeyB, prefix, observer string, snr *float64, ts time.Time) {
key := makeEdgeKey(pubkeyA, pubkeyB)
g.mu.Lock()
defer g.mu.Unlock()
e, exists := g.edges[key]
if !exists {
e = &NeighborEdge{
NodeA: key.A,
NodeB: key.B,
Prefix: prefix,
Observers: make(map[string]bool),
FirstSeen: ts,
LastSeen: ts,
}
g.edges[key] = e
g.byNode[key.A] = append(g.byNode[key.A], e)
g.byNode[key.B] = append(g.byNode[key.B], e)
}
e.Count++
if ts.After(e.LastSeen) {
e.LastSeen = ts
}
if ts.Before(e.FirstSeen) {
e.FirstSeen = ts
}
if snr != nil {
e.SNRSum += *snr
e.SNRCount++
}
if observer != "" {
e.Observers[observer] = true
}
}
// upsertEdgeWithCandidates handles prefix-based edges that may be ambiguous.
func (g *NeighborGraph) upsertEdgeWithCandidates(knownPK, prefix string, candidates []nodeInfo, observer string, snr *float64, ts time.Time) {
if len(candidates) == 1 {
resolved := strings.ToLower(candidates[0].PublicKey)
if resolved == knownPK {
return // self-edge guard
}
g.upsertEdge(knownPK, resolved, prefix, observer, snr, ts)
return
}
// Filter out self from candidates
filtered := make([]string, 0, len(candidates))
for _, c := range candidates {
pk := strings.ToLower(c.PublicKey)
if pk != knownPK {
filtered = append(filtered, pk)
}
}
if len(filtered) == 1 {
g.upsertEdge(knownPK, filtered[0], prefix, observer, snr, ts)
return
}
// Ambiguous or orphan: use prefix-based key
pseudoB := "prefix:" + prefix
key := makeEdgeKey(knownPK, pseudoB)
g.mu.Lock()
defer g.mu.Unlock()
e, exists := g.edges[key]
if !exists {
e = &NeighborEdge{
NodeA: key.A,
NodeB: "",
Prefix: prefix,
Observers: make(map[string]bool),
Ambiguous: true,
Candidates: filtered,
FirstSeen: ts,
LastSeen: ts,
}
g.edges[key] = e
g.byNode[knownPK] = append(g.byNode[knownPK], e)
}
e.Count++
if ts.After(e.LastSeen) {
e.LastSeen = ts
}
if ts.Before(e.FirstSeen) {
e.FirstSeen = ts
}
if snr != nil {
e.SNRSum += *snr
e.SNRCount++
}
if observer != "" {
e.Observers[observer] = true
}
}
// ─── Disambiguation ────────────────────────────────────────────────────────────
// disambiguate resolves ambiguous edges using Jaccard similarity of neighbor sets.
// Only fully-resolved edges are used as evidence (transitivity poisoning guard).
func (g *NeighborGraph) disambiguate() {
g.mu.Lock()
defer g.mu.Unlock()
// Build resolved neighbor sets: for each node, collect the set of nodes
// it has fully-resolved (non-ambiguous) edges with.
resolvedNeighbors := make(map[string]map[string]bool)
for _, e := range g.edges {
if e.Ambiguous || e.NodeB == "" {
continue
}
if resolvedNeighbors[e.NodeA] == nil {
resolvedNeighbors[e.NodeA] = make(map[string]bool)
}
if resolvedNeighbors[e.NodeB] == nil {
resolvedNeighbors[e.NodeB] = make(map[string]bool)
}
resolvedNeighbors[e.NodeA][e.NodeB] = true
resolvedNeighbors[e.NodeB][e.NodeA] = true
}
// Try to resolve each ambiguous edge.
for key, e := range g.edges {
if !e.Ambiguous || len(e.Candidates) < 2 {
continue
}
if e.Count < affinityMinObservations {
continue
}
// Determine the known node (the one that's a real pubkey, not the prefix side).
knownNode := e.NodeA
if strings.HasPrefix(e.NodeA, "prefix:") {
knownNode = e.NodeB
}
// If knownNode is empty (shouldn't happen for ambiguous edges with candidates), skip.
if knownNode == "" {
continue
}
knownNeighbors := resolvedNeighbors[knownNode]
type scored struct {
pubkey string
jaccard float64
}
var scores []scored
for _, cand := range e.Candidates {
candNeighbors := resolvedNeighbors[cand]
j := jaccardSimilarity(knownNeighbors, candNeighbors)
scores = append(scores, scored{cand, j})
}
if len(scores) < 2 {
continue
}
// Find best and second-best.
best, secondBest := scores[0], scores[1]
if secondBest.jaccard > best.jaccard {
best, secondBest = secondBest, best
}
for i := 2; i < len(scores); i++ {
if scores[i].jaccard > best.jaccard {
secondBest = best
best = scores[i]
} else if scores[i].jaccard > secondBest.jaccard {
secondBest = scores[i]
}
}
// Auto-resolve only if best >= 3× second-best AND enough observations.
if secondBest.jaccard == 0 {
// If second-best is 0 and best > 0, ratio is infinite → resolve.
if best.jaccard > 0 {
g.resolveEdge(key, e, knownNode, best.pubkey)
}
} else if best.jaccard/secondBest.jaccard >= affinityConfidenceRatio {
g.resolveEdge(key, e, knownNode, best.pubkey)
}
// Otherwise remain ambiguous.
}
}
// resolveEdge converts an ambiguous edge to a resolved one.
// Must be called with g.mu held.
func (g *NeighborGraph) resolveEdge(oldKey edgeKey, e *NeighborEdge, knownNode, resolvedPK string) {
// Remove old edge.
delete(g.edges, oldKey)
g.removeFromByNode(oldKey.A, e)
g.removeFromByNode(oldKey.B, e)
// Update edge.
newKey := makeEdgeKey(knownNode, resolvedPK)
e.NodeA = newKey.A
e.NodeB = newKey.B
e.Ambiguous = false
e.Resolved = true
// Merge with existing edge if any.
if existing, ok := g.edges[newKey]; ok {
existing.Count += e.Count
if e.LastSeen.After(existing.LastSeen) {
existing.LastSeen = e.LastSeen
}
if e.FirstSeen.Before(existing.FirstSeen) {
existing.FirstSeen = e.FirstSeen
}
existing.SNRSum += e.SNRSum
existing.SNRCount += e.SNRCount
for obs := range e.Observers {
existing.Observers[obs] = true
}
return
}
g.edges[newKey] = e
g.byNode[newKey.A] = append(g.byNode[newKey.A], e)
g.byNode[newKey.B] = append(g.byNode[newKey.B], e)
}
// removeFromByNode removes an edge from the byNode index for the given key.
func (g *NeighborGraph) removeFromByNode(nodeKey string, edge *NeighborEdge) {
edges := g.byNode[nodeKey]
for i, e := range edges {
if e == edge {
g.byNode[nodeKey] = append(edges[:i], edges[i+1:]...)
return
}
}
}
// jaccardSimilarity computes |A ∩ B| / |A B|.
func jaccardSimilarity(a, b map[string]bool) float64 {
if len(a) == 0 && len(b) == 0 {
return 0
}
intersection := 0
for k := range a {
if b[k] {
intersection++
}
}
union := len(a) + len(b) - intersection
if union == 0 {
return 0
}
return float64(intersection) / float64(union)
}
// parseTimestamp parses a timestamp string into time.Time.
func parseTimestamp(s string) time.Time {
// Try common formats.
for _, fmt := range []string{
time.RFC3339,
"2006-01-02T15:04:05Z",
"2006-01-02 15:04:05",
"2006-01-02T15:04:05.000Z",
} {
if t, err := time.Parse(fmt, s); err == nil {
return t
}
}
return time.Time{}
}
+642
View File
@@ -0,0 +1,642 @@
package main
import (
"encoding/json"
"math"
"testing"
"time"
)
// ─── Helpers ───────────────────────────────────────────────────────────────────
// ngTestStore creates a minimal PacketStore with injected nodes and packets.
func ngTestStore(nodes []nodeInfo, packets []*StoreTx) *PacketStore {
if nodes == nil {
nodes = []nodeInfo{}
}
if packets == nil {
packets = []*StoreTx{}
}
ps := &PacketStore{
packets: packets,
byHash: make(map[string]*StoreTx),
byTxID: make(map[int]*StoreTx),
byObsID: make(map[int]*StoreObs),
byObserver: make(map[string][]*StoreObs),
byNode: make(map[string][]*StoreTx),
nodeHashes: make(map[string]map[string]bool),
byPayloadType: make(map[int][]*StoreTx),
rfCache: make(map[string]*cachedResult),
topoCache: make(map[string]*cachedResult),
hashCache: make(map[string]*cachedResult),
collisionCache: make(map[string]*cachedResult),
chanCache: make(map[string]*cachedResult),
distCache: make(map[string]*cachedResult),
subpathCache: make(map[string]*cachedResult),
spIndex: make(map[string]int),
}
ps.nodeCache = nodes
ps.nodePM = buildPrefixMap(nodes)
ps.nodeCacheTime = time.Now().Add(1 * time.Hour)
return ps
}
func ngIntPtr(v int) *int { return &v }
func ngFloatPtr(v float64) *float64 { return &v }
func ngMakeTx(id int, payloadType int, decodedJSON string, obs []*StoreObs) *StoreTx {
tx := &StoreTx{
ID: id,
PayloadType: ngIntPtr(payloadType),
DecodedJSON: decodedJSON,
Observations: obs,
}
return tx
}
func ngMakeObs(observerID, pathJSON, timestamp string, snr *float64) *StoreObs {
return &StoreObs{
ObserverID: observerID,
PathJSON: pathJSON,
Timestamp: timestamp,
SNR: snr,
}
}
func ngFromNodeJSON(pubkey string) string {
b, _ := json.Marshal(map[string]string{"from_node": pubkey})
return string(b)
}
var now = time.Now()
var nowStr = now.UTC().Format(time.RFC3339)
var weekAgoStr = now.Add(-7 * 24 * time.Hour).UTC().Format(time.RFC3339)
var monthAgoStr = now.Add(-30 * 24 * time.Hour).UTC().Format(time.RFC3339)
// ─── Tests ─────────────────────────────────────────────────────────────────────
func TestBuildNeighborGraph_EmptyStore(t *testing.T) {
store := ngTestStore(nil, nil)
g := BuildFromStore(store)
if len(g.edges) != 0 {
t.Errorf("expected 0 edges, got %d", len(g.edges))
}
}
func TestBuildNeighborGraph_AdvertSingleHopPath(t *testing.T) {
// ADVERT from X, path=["R1_prefix"] → edges: X↔R1 and Observer↔R1
nodes := []nodeInfo{
{PublicKey: "aaaa1111", Name: "NodeX"},
{PublicKey: "r1aabbcc", Name: "R1"},
{PublicKey: "obs00001", Name: "Observer"},
}
tx := ngMakeTx(1, 4, ngFromNodeJSON("aaaa1111"), []*StoreObs{
ngMakeObs("obs00001", `["r1aa"]`, nowStr, ngFloatPtr(-10)),
})
store := ngTestStore(nodes, []*StoreTx{tx})
g := BuildFromStore(store)
// Should have 2 edges: X↔R1 and Observer↔R1
// But since path has 1 element, path[0]==path[last], so for ADVERTs
// both edge types point to the same hop. X↔R1 and Obs↔R1 = 2 edges.
edges := g.AllEdges()
if len(edges) != 2 {
t.Fatalf("expected 2 edges, got %d", len(edges))
}
// Check X↔R1 exists
found := false
for _, e := range edges {
if (e.NodeA == "aaaa1111" && e.NodeB == "r1aabbcc") ||
(e.NodeA == "r1aabbcc" && e.NodeB == "aaaa1111") {
found = true
}
}
if !found {
t.Error("missing originator↔path[0] edge (X↔R1)")
}
// Check Observer↔R1 exists
found = false
for _, e := range edges {
if (e.NodeA == "obs00001" && e.NodeB == "r1aabbcc") ||
(e.NodeA == "r1aabbcc" && e.NodeB == "obs00001") {
found = true
}
}
if !found {
t.Error("missing observer↔path[last] edge (Observer↔R1)")
}
}
func TestBuildNeighborGraph_AdvertMultiHopPath(t *testing.T) {
// ADVERT from X, path=["R1","R2"] → X↔R1 and Observer↔R2
nodes := []nodeInfo{
{PublicKey: "aaaa1111", Name: "NodeX"},
{PublicKey: "r1aabbcc", Name: "R1"},
{PublicKey: "r2ddeeff", Name: "R2"},
{PublicKey: "obs00001", Name: "Observer"},
}
tx := ngMakeTx(1, 4, ngFromNodeJSON("aaaa1111"), []*StoreObs{
ngMakeObs("obs00001", `["r1aa","r2dd"]`, nowStr, nil),
})
store := ngTestStore(nodes, []*StoreTx{tx})
g := BuildFromStore(store)
edges := g.AllEdges()
if len(edges) != 2 {
t.Fatalf("expected 2 edges, got %d", len(edges))
}
// X↔R1
hasXR1 := false
hasObsR2 := false
for _, e := range edges {
if (e.NodeA == "aaaa1111" && e.NodeB == "r1aabbcc") || (e.NodeA == "r1aabbcc" && e.NodeB == "aaaa1111") {
hasXR1 = true
}
if (e.NodeA == "obs00001" && e.NodeB == "r2ddeeff") || (e.NodeA == "r2ddeeff" && e.NodeB == "obs00001") {
hasObsR2 = true
}
}
if !hasXR1 {
t.Error("missing X↔R1 edge")
}
if !hasObsR2 {
t.Error("missing Observer↔R2 edge")
}
}
func TestBuildNeighborGraph_AdvertZeroHop(t *testing.T) {
// ADVERT from X, path=[] → X↔Observer direct edge
nodes := []nodeInfo{
{PublicKey: "aaaa1111", Name: "NodeX"},
{PublicKey: "obs00001", Name: "Observer"},
}
tx := ngMakeTx(1, 4, ngFromNodeJSON("aaaa1111"), []*StoreObs{
ngMakeObs("obs00001", `[]`, nowStr, nil),
})
store := ngTestStore(nodes, []*StoreTx{tx})
g := BuildFromStore(store)
edges := g.AllEdges()
if len(edges) != 1 {
t.Fatalf("expected 1 edge, got %d", len(edges))
}
e := edges[0]
if !((e.NodeA == "aaaa1111" && e.NodeB == "obs00001") || (e.NodeA == "obs00001" && e.NodeB == "aaaa1111")) {
t.Errorf("expected X↔Observer edge, got %s↔%s", e.NodeA, e.NodeB)
}
if e.Ambiguous {
t.Error("zero-hop edge should not be ambiguous")
}
}
func TestBuildNeighborGraph_NonAdvertEmptyPath(t *testing.T) {
// Non-ADVERT, path=[] → no edges
nodes := []nodeInfo{
{PublicKey: "aaaa1111", Name: "NodeX"},
{PublicKey: "obs00001", Name: "Observer"},
}
tx := ngMakeTx(1, 2, ngFromNodeJSON("aaaa1111"), []*StoreObs{
ngMakeObs("obs00001", `[]`, nowStr, nil),
})
store := ngTestStore(nodes, []*StoreTx{tx})
g := BuildFromStore(store)
if len(g.edges) != 0 {
t.Errorf("expected 0 edges for non-ADVERT empty path, got %d", len(g.edges))
}
}
func TestBuildNeighborGraph_NonAdvertOnlyObserverEdge(t *testing.T) {
// Non-ADVERT with path=["R1","R2"] → only Observer↔R2, NO originator edge
nodes := []nodeInfo{
{PublicKey: "aaaa1111", Name: "NodeX"},
{PublicKey: "r1aabbcc", Name: "R1"},
{PublicKey: "r2ddeeff", Name: "R2"},
{PublicKey: "obs00001", Name: "Observer"},
}
tx := ngMakeTx(1, 2, ngFromNodeJSON("aaaa1111"), []*StoreObs{
ngMakeObs("obs00001", `["r1aa","r2dd"]`, nowStr, nil),
})
store := ngTestStore(nodes, []*StoreTx{tx})
g := BuildFromStore(store)
edges := g.AllEdges()
if len(edges) != 1 {
t.Fatalf("expected 1 edge, got %d", len(edges))
}
e := edges[0]
if !((e.NodeA == "obs00001" && e.NodeB == "r2ddeeff") || (e.NodeA == "r2ddeeff" && e.NodeB == "obs00001")) {
t.Errorf("expected Observer↔R2 edge, got %s↔%s", e.NodeA, e.NodeB)
}
}
func TestBuildNeighborGraph_NonAdvertSingleHop(t *testing.T) {
// Non-ADVERT with path=["R1"] → Observer↔R1 only
nodes := []nodeInfo{
{PublicKey: "aaaa1111", Name: "NodeX"},
{PublicKey: "r1aabbcc", Name: "R1"},
{PublicKey: "obs00001", Name: "Observer"},
}
tx := ngMakeTx(1, 2, ngFromNodeJSON("aaaa1111"), []*StoreObs{
ngMakeObs("obs00001", `["r1aa"]`, nowStr, nil),
})
store := ngTestStore(nodes, []*StoreTx{tx})
g := BuildFromStore(store)
edges := g.AllEdges()
if len(edges) != 1 {
t.Fatalf("expected 1 edge, got %d", len(edges))
}
e := edges[0]
if !((e.NodeA == "obs00001" && e.NodeB == "r1aabbcc") || (e.NodeA == "r1aabbcc" && e.NodeB == "obs00001")) {
t.Errorf("expected Observer↔R1, got %s↔%s", e.NodeA, e.NodeB)
}
}
func TestBuildNeighborGraph_HashCollision(t *testing.T) {
// Two nodes share prefix "a3" → ambiguous edge
nodes := []nodeInfo{
{PublicKey: "aaaa1111", Name: "NodeX"},
{PublicKey: "a3bb1111", Name: "CandidateA"},
{PublicKey: "a3bb2222", Name: "CandidateB"},
{PublicKey: "obs00001", Name: "Observer"},
}
tx := ngMakeTx(1, 4, ngFromNodeJSON("aaaa1111"), []*StoreObs{
ngMakeObs("obs00001", `["a3bb"]`, nowStr, nil),
})
store := ngTestStore(nodes, []*StoreTx{tx})
g := BuildFromStore(store)
// Should have ambiguous edges
var ambigCount int
for _, e := range g.AllEdges() {
if e.Ambiguous {
ambigCount++
if len(e.Candidates) < 2 {
t.Errorf("expected >=2 candidates, got %d", len(e.Candidates))
}
}
}
if ambigCount == 0 {
t.Error("expected at least one ambiguous edge for hash collision")
}
}
func TestBuildNeighborGraph_JaccardScoring(t *testing.T) {
// Test Jaccard similarity computation directly
a := map[string]bool{"x": true, "y": true, "z": true}
b := map[string]bool{"y": true, "z": true, "w": true}
j := jaccardSimilarity(a, b)
// intersection = {y, z} = 2, union = {x, y, z, w} = 4 → 0.5
if math.Abs(j-0.5) > 0.001 {
t.Errorf("expected Jaccard 0.5, got %f", j)
}
// Empty sets
j = jaccardSimilarity(nil, nil)
if j != 0 {
t.Errorf("expected 0 for empty sets, got %f", j)
}
}
func TestBuildNeighborGraph_ConfidenceAutoResolve(t *testing.T) {
// Setup: NodeX has known neighbors N1, N2, N3 (resolved edges).
// CandidateA also has known neighbors N1, N2, N3 (high Jaccard with X).
// CandidateB has no known neighbors (Jaccard = 0).
// An ambiguous edge X↔prefix "a3" with candidates [A, B] should auto-resolve to A.
nodes := []nodeInfo{
{PublicKey: "aaaa1111", Name: "NodeX"},
{PublicKey: "n1111111", Name: "N1"},
{PublicKey: "n2222222", Name: "N2"},
{PublicKey: "n3333333", Name: "N3"},
{PublicKey: "a3001111", Name: "CandidateA"},
{PublicKey: "a3002222", Name: "CandidateB"},
{PublicKey: "obs00001", Name: "Observer"},
}
// Create resolved edges: X↔N1, X↔N2, X↔N3, A↔N1, A↔N2, A↔N3
// Then an ambiguous edge X↔"a300" prefix with 3+ observations.
var txs []*StoreTx
txID := 1
// X sends ADVERTs through N1, N2, N3
for _, nhop := range []string{"n111", "n222", "n333"} {
txs = append(txs, ngMakeTx(txID, 4, ngFromNodeJSON("aaaa1111"), []*StoreObs{
ngMakeObs("obs00001", `["`+nhop+`"]`, nowStr, nil),
}))
txID++
}
// CandidateA sends ADVERTs through N1, N2, N3
for _, nhop := range []string{"n111", "n222", "n333"} {
txs = append(txs, ngMakeTx(txID, 4, ngFromNodeJSON("a3001111"), []*StoreObs{
ngMakeObs("obs00001", `["`+nhop+`"]`, nowStr, nil),
}))
txID++
}
// Ambiguous edge: X sends ADVERTs with path[0]="a300" (matches both candidates)
// Need 3+ observations for confidence threshold.
for i := 0; i < 3; i++ {
txs = append(txs, ngMakeTx(txID, 4, ngFromNodeJSON("aaaa1111"), []*StoreObs{
ngMakeObs("obs00001", `["a300"]`, nowStr, nil),
}))
txID++
}
store := ngTestStore(nodes, txs)
g := BuildFromStore(store)
// The ambiguous edge X↔a300 should have been resolved to CandidateA
neighbors := g.Neighbors("aaaa1111")
foundA := false
for _, e := range neighbors {
other := e.NodeB
if e.NodeA != "aaaa1111" {
other = e.NodeA
}
if other == "a3001111" {
foundA = true
if e.Ambiguous {
t.Error("edge should have been resolved (not ambiguous)")
}
}
}
if !foundA {
t.Error("expected edge X↔CandidateA to be auto-resolved")
}
}
func TestBuildNeighborGraph_EqualScoresAmbiguous(t *testing.T) {
// Two candidates with identical neighbor sets → should NOT auto-resolve.
nodes := []nodeInfo{
{PublicKey: "aaaa1111", Name: "NodeX"},
{PublicKey: "n1111111", Name: "N1"},
{PublicKey: "a3001111", Name: "CandidateA"},
{PublicKey: "a3002222", Name: "CandidateB"},
{PublicKey: "obs00001", Name: "Observer"},
}
var txs []*StoreTx
txID := 1
// X↔N1
txs = append(txs, ngMakeTx(txID, 4, ngFromNodeJSON("aaaa1111"), []*StoreObs{
ngMakeObs("obs00001", `["n111"]`, nowStr, nil),
}))
txID++
// Both candidates have same neighbor (N1)
txs = append(txs, ngMakeTx(txID, 4, ngFromNodeJSON("a3001111"), []*StoreObs{
ngMakeObs("obs00001", `["n111"]`, nowStr, nil),
}))
txID++
txs = append(txs, ngMakeTx(txID, 4, ngFromNodeJSON("a3002222"), []*StoreObs{
ngMakeObs("obs00001", `["n111"]`, nowStr, nil),
}))
txID++
// Ambiguous edge with 3+ observations
for i := 0; i < 3; i++ {
txs = append(txs, ngMakeTx(txID, 4, ngFromNodeJSON("aaaa1111"), []*StoreObs{
ngMakeObs("obs00001", `["a300"]`, nowStr, nil),
}))
txID++
}
store := ngTestStore(nodes, txs)
g := BuildFromStore(store)
// Should remain ambiguous
var ambigFound bool
for _, e := range g.AllEdges() {
if e.Ambiguous && e.Prefix == "a300" {
ambigFound = true
}
}
if !ambigFound {
t.Error("expected ambiguous edge to remain unresolved with equal scores")
}
}
func TestBuildNeighborGraph_ObserverSelfEdgeGuard(t *testing.T) {
// Observer's own prefix in path → should NOT create self-edge.
nodes := []nodeInfo{
{PublicKey: "aaaa1111", Name: "NodeX"},
{PublicKey: "obs00001", Name: "Observer"},
}
tx := ngMakeTx(1, 4, ngFromNodeJSON("aaaa1111"), []*StoreObs{
ngMakeObs("obs00001", `["obs0"]`, nowStr, nil),
})
store := ngTestStore(nodes, []*StoreTx{tx})
g := BuildFromStore(store)
// Check no self-edge for observer
for _, e := range g.AllEdges() {
if e.NodeA == e.NodeB && e.NodeA == "obs00001" {
t.Error("self-edge created for observer")
}
}
}
func TestBuildNeighborGraph_OrphanPrefix(t *testing.T) {
// Path contains prefix matching zero nodes → edge recorded as unresolved.
nodes := []nodeInfo{
{PublicKey: "aaaa1111", Name: "NodeX"},
{PublicKey: "obs00001", Name: "Observer"},
}
tx := ngMakeTx(1, 4, ngFromNodeJSON("aaaa1111"), []*StoreObs{
ngMakeObs("obs00001", `["ff99"]`, nowStr, nil),
})
store := ngTestStore(nodes, []*StoreTx{tx})
g := BuildFromStore(store)
// Should have ambiguous edges with empty candidates.
var orphanFound bool
for _, e := range g.AllEdges() {
if e.Ambiguous && len(e.Candidates) == 0 {
orphanFound = true
if e.Prefix != "ff99" {
t.Errorf("expected prefix ff99, got %s", e.Prefix)
}
}
}
if !orphanFound {
t.Error("expected orphan prefix edge with empty candidates")
}
}
func TestAffinityScore_Fresh(t *testing.T) {
e := &NeighborEdge{Count: 100, LastSeen: time.Now()}
s := e.Score(time.Now())
if s < 0.99 || s > 1.0 {
t.Errorf("expected score ≈ 1.0, got %f", s)
}
}
func TestAffinityScore_Decayed(t *testing.T) {
e := &NeighborEdge{Count: 100, LastSeen: time.Now().Add(-7 * 24 * time.Hour)}
s := e.Score(time.Now())
// 7 days → half-life → ~0.5
if math.Abs(s-0.5) > 0.05 {
t.Errorf("expected score ≈ 0.5, got %f", s)
}
}
func TestAffinityScore_LowCount(t *testing.T) {
e := &NeighborEdge{Count: 5, LastSeen: time.Now()}
s := e.Score(time.Now())
// 5/100 = 0.05
if math.Abs(s-0.05) > 0.01 {
t.Errorf("expected score ≈ 0.05, got %f", s)
}
}
func TestAffinityScore_StaleAndLow(t *testing.T) {
e := &NeighborEdge{Count: 5, LastSeen: time.Now().Add(-30 * 24 * time.Hour)}
s := e.Score(time.Now())
// Very small
if s > 0.01 {
t.Errorf("expected score ≈ 0, got %f", s)
}
}
func TestBuildNeighborGraph_CountAccumulation(t *testing.T) {
nodes := []nodeInfo{
{PublicKey: "aaaa1111", Name: "NodeX"},
{PublicKey: "r1aabbcc", Name: "R1"},
{PublicKey: "obs00001", Name: "Observer"},
}
var txs []*StoreTx
for i := 0; i < 5; i++ {
txs = append(txs, ngMakeTx(i+1, 4, ngFromNodeJSON("aaaa1111"), []*StoreObs{
ngMakeObs("obs00001", `["r1aa"]`, nowStr, nil),
}))
}
store := ngTestStore(nodes, txs)
g := BuildFromStore(store)
// Check count on X↔R1 edge
for _, e := range g.AllEdges() {
if (e.NodeA == "aaaa1111" && e.NodeB == "r1aabbcc") || (e.NodeA == "r1aabbcc" && e.NodeB == "aaaa1111") {
if e.Count != 5 {
t.Errorf("expected count 5, got %d", e.Count)
}
return
}
}
t.Error("X↔R1 edge not found")
}
func TestBuildNeighborGraph_MultipleObservers(t *testing.T) {
nodes := []nodeInfo{
{PublicKey: "aaaa1111", Name: "NodeX"},
{PublicKey: "r1aabbcc", Name: "R1"},
{PublicKey: "obs00001", Name: "Obs1"},
{PublicKey: "obs00002", Name: "Obs2"},
}
tx := ngMakeTx(1, 4, ngFromNodeJSON("aaaa1111"), []*StoreObs{
ngMakeObs("obs00001", `["r1aa"]`, nowStr, nil),
ngMakeObs("obs00002", `["r1aa"]`, nowStr, nil),
})
store := ngTestStore(nodes, []*StoreTx{tx})
g := BuildFromStore(store)
for _, e := range g.AllEdges() {
if (e.NodeA == "aaaa1111" && e.NodeB == "r1aabbcc") || (e.NodeA == "r1aabbcc" && e.NodeB == "aaaa1111") {
if len(e.Observers) != 2 {
t.Errorf("expected 2 observers, got %d", len(e.Observers))
}
if !e.Observers["obs00001"] || !e.Observers["obs00002"] {
t.Error("missing expected observer")
}
return
}
}
t.Error("X↔R1 edge not found")
}
func TestBuildNeighborGraph_TimeDecayOldObservations(t *testing.T) {
nodes := []nodeInfo{
{PublicKey: "aaaa1111", Name: "NodeX"},
{PublicKey: "r1aabbcc", Name: "R1"},
{PublicKey: "obs00001", Name: "Observer"},
}
tx := ngMakeTx(1, 4, ngFromNodeJSON("aaaa1111"), []*StoreObs{
ngMakeObs("obs00001", `["r1aa"]`, monthAgoStr, nil),
})
store := ngTestStore(nodes, []*StoreTx{tx})
g := BuildFromStore(store)
for _, e := range g.AllEdges() {
if (e.NodeA == "aaaa1111" && e.NodeB == "r1aabbcc") || (e.NodeA == "r1aabbcc" && e.NodeB == "aaaa1111") {
score := e.Score(time.Now())
if score > 0.05 {
t.Errorf("expected decayed score < 0.05, got %f", score)
}
return
}
}
t.Error("X↔R1 edge not found")
}
func TestBuildNeighborGraph_ADVERTOnlyConstraint(t *testing.T) {
// Non-ADVERT: should NOT create originator↔path[0] edge, only observer↔path[last].
nodes := []nodeInfo{
{PublicKey: "aaaa1111", Name: "NodeX"},
{PublicKey: "r1aabbcc", Name: "R1"},
{PublicKey: "r2ddeeff", Name: "R2"},
{PublicKey: "obs00001", Name: "Observer"},
}
tx := ngMakeTx(1, 2, ngFromNodeJSON("aaaa1111"), []*StoreObs{
ngMakeObs("obs00001", `["r1aa","r2dd"]`, nowStr, nil),
})
store := ngTestStore(nodes, []*StoreTx{tx})
g := BuildFromStore(store)
for _, e := range g.AllEdges() {
a, b := e.NodeA, e.NodeB
if (a == "aaaa1111" && b == "r1aabbcc") || (a == "r1aabbcc" && b == "aaaa1111") {
t.Error("non-ADVERT should NOT produce originator↔path[0] edge")
}
}
// Should have Observer↔R2
found := false
for _, e := range g.AllEdges() {
if (e.NodeA == "obs00001" && e.NodeB == "r2ddeeff") || (e.NodeA == "r2ddeeff" && e.NodeB == "obs00001") {
found = true
}
}
if !found {
t.Error("missing Observer↔R2 edge from non-ADVERT")
}
}
func TestNeighborGraph_CacheTTL(t *testing.T) {
g := NewNeighborGraph()
if !g.IsStale() {
t.Error("new graph should be stale")
}
g.mu.Lock()
g.builtAt = time.Now()
g.mu.Unlock()
if g.IsStale() {
t.Error("just-built graph should not be stale")
}
g.mu.Lock()
g.builtAt = time.Now().Add(-2 * neighborGraphTTL)
g.mu.Unlock()
if !g.IsStale() {
t.Error("old graph should be stale")
}
}
+12 -1
View File
@@ -38,6 +38,10 @@ type Server struct {
statsMu sync.Mutex
statsCache *StatsResponse
statsCachedAt time.Time
// Neighbor affinity graph (lazy-built, cached with TTL)
neighborMu sync.Mutex
neighborGraph *NeighborGraph
}
// PerfStats tracks request performance.
@@ -128,6 +132,7 @@ func (s *Server) RegisterRoutes(r *mux.Router) {
r.HandleFunc("/api/nodes/{pubkey}/health", s.handleNodeHealth).Methods("GET")
r.HandleFunc("/api/nodes/{pubkey}/paths", s.handleNodePaths).Methods("GET")
r.HandleFunc("/api/nodes/{pubkey}/analytics", s.handleNodeAnalytics).Methods("GET")
r.HandleFunc("/api/nodes/{pubkey}/neighbors", s.handleNodeNeighbors).Methods("GET")
r.HandleFunc("/api/nodes/{pubkey}", s.handleNodeDetail).Methods("GET")
r.HandleFunc("/api/nodes", s.handleNodes).Methods("GET")
@@ -140,6 +145,7 @@ func (s *Server) RegisterRoutes(r *mux.Router) {
r.HandleFunc("/api/analytics/hash-collisions", s.handleAnalyticsHashCollisions).Methods("GET")
r.HandleFunc("/api/analytics/subpaths", s.handleAnalyticsSubpaths).Methods("GET")
r.HandleFunc("/api/analytics/subpath-detail", s.handleAnalyticsSubpathDetail).Methods("GET")
r.HandleFunc("/api/analytics/neighbor-graph", s.handleNeighborGraph).Methods("GET")
// Other endpoints
r.HandleFunc("/api/resolve-hops", s.handleResolveHops).Methods("GET")
@@ -287,7 +293,12 @@ func (s *Server) handleConfigTheme(w http.ResponseWriter, r *http.Request) {
}, s.cfg.NodeColors, theme.NodeColors)
themeDark := mergeMap(map[string]interface{}{}, s.cfg.ThemeDark, theme.ThemeDark)
typeColors := mergeMap(map[string]interface{}{}, s.cfg.TypeColors, theme.TypeColors)
typeColors := mergeMap(map[string]interface{}{
"ADVERT": "#22c55e", "GRP_TXT": "#3b82f6", "TXT_MSG": "#f59e0b",
"ACK": "#6b7280", "REQUEST": "#a855f7", "RESPONSE": "#06b6d4",
"TRACE": "#ec4899", "PATH": "#14b8a6", "ANON_REQ": "#f43f5e",
"UNKNOWN": "#6b7280",
}, s.cfg.TypeColors, theme.TypeColors)
var home interface{}
if theme.Home != nil {
+29
View File
@@ -454,6 +454,35 @@ func TestConfigThemeEndpoint(t *testing.T) {
}
}
func TestConfigThemeTypeColorsDefaults(t *testing.T) {
_, router := setupTestServer(t)
req := httptest.NewRequest("GET", "/api/config/theme", nil)
w := httptest.NewRecorder()
router.ServeHTTP(w, req)
if w.Code != 200 {
t.Fatalf("expected 200, got %d", w.Code)
}
var body map[string]interface{}
json.Unmarshal(w.Body.Bytes(), &body)
tc, ok := body["typeColors"].(map[string]interface{})
if !ok {
t.Fatal("expected typeColors object in theme response")
}
expectedTypes := []string{"ADVERT", "GRP_TXT", "TXT_MSG", "ACK", "REQUEST", "RESPONSE", "TRACE", "PATH", "ANON_REQ", "UNKNOWN"}
for _, typ := range expectedTypes {
val, exists := tc[typ]
if !exists {
t.Errorf("typeColors missing default for %s", typ)
continue
}
color, ok := val.(string)
if !ok || color == "" || color == "#000000" {
t.Errorf("typeColors[%s] should be a non-black color, got %v", typ, val)
}
}
}
func TestConfigMapEndpoint(t *testing.T) {
_, router := setupTestServer(t)
req := httptest.NewRequest("GET", "/api/config/map", nil)
+568
View File
@@ -0,0 +1,568 @@
# Customizer Rework Spec
## Overview
The current customizer (`public/customize.js`) suffers from fundamental state management issues documented in [issue #284](https://github.com/Kpa-clawbot/CoreScope/issues/284). State is scattered across 7 localStorage keys, CSS updates bypass the data layer, and there's no single source of truth for the effective configuration.
This spec defines a clean rework based on event-driven state management with a single data flow path. The goal: predictable state, minimal storage footprint, portable config format, and zero ambiguity about which values are active and why.
## Design Decisions
These are agreed and final. Do not reinterpret or deviate.
1. **Three state layers:** server defaults (immutable after fetch), user overrides (delta in localStorage), effective config (computed via merge, never stored directly).
2. **Single data flow:** user action → debounce (~300ms) → write delta to localStorage → read back from localStorage → merge with server defaults → apply CSS variables. No shortcuts, no optimistic CSS updates (see Decision #12 for the one exception).
3. **One localStorage key:** `cs-theme-overrides` — replaces the current 7 scattered keys (`meshcore-user-theme`, `meshcore-timestamp-mode`, `meshcore-timestamp-timezone`, `meshcore-timestamp-format`, `meshcore-timestamp-custom-format`, `meshcore-heatmap-opacity`, `meshcore-live-heatmap-opacity`).
4. **Universal format:** same shape as the server's `ThemeResponse` plus additional keys. Works identically for user export, admin `theme.json`, and user import.
5. **User overrides always win** in merge — `merge(serverDefaults, userOverrides)` = effective config.
6. **Override indicator:** shown in customizer panel ONLY when override value differs from current server default.
7. **No silent pruning:** overrides stay in localStorage until the user explicitly resets them (per-field reset or full reset). The delta may contain values that happen to match current server defaults — that's fine. User intent is preserved; nothing silently disappears.
8. **Per-field reset:** remove a single key from the delta → re-merge → re-apply CSS.
9. **Full reset:** `localStorage.removeItem('cs-theme-overrides')` → re-merge (effective = server defaults) → re-apply CSS.
10. **Export = dump delta object as JSON download. Import = validate shape, write to localStorage, trigger re-merge.**
11. **No CSS magic:** CSS variables ONLY update after the localStorage round-trip completes. No optimistic updates (see Decision #12 for the one exception).
12. **Color picker optimistic CSS exception:** For continuous inputs (color pickers, sliders), CSS is updated optimistically during `input` events for visual responsiveness. The localStorage write only happens on `change` event (mouseup/blur). On `change`, the full pipeline runs: write → read → merge → apply (which will match the optimistic state). If the user refreshes mid-drag before `change` fires, the change is lost — this is acceptable. This is the ONLY exception to the localStorage-first rule.
## Dark/Light Mode
The customizer treats light and dark mode as separate override sections:
- **`theme`** stores light mode color overrides.
- **`themeDark`** stores dark mode color overrides.
- When the user changes a color in the customizer, it writes to whichever section matches their current mode: `theme` if light, `themeDark` if dark.
- The dark/light mode toggle preference (`meshcore-theme` localStorage key) is **separate** from the delta object. It is a view preference, not a customization — it is not stored in `cs-theme-overrides`.
- The customizer UI shows color fields for the currently active mode only. Switching modes re-renders the color fields with values from the matching section.
## Presets
The existing preset themes are preserved and flow through the standard pipeline:
**Available presets:** Default, Ocean, Forest, Sunset, Monochrome.
**How presets work:**
- Clicking a preset writes its values to localStorage via the same pipeline as any other change: preset data → `writeOverrides()` → read back → merge → apply CSS.
- Presets are NOT special — they are pre-built delta objects applied through the standard flow.
- Each preset contains both `theme` (light) and `themeDark` (dark) sections, plus any other overrides the preset defines (e.g., `nodeColors`).
- **"Reset to Default"** = clear all overrides (equivalent to full reset: `localStorage.removeItem('cs-theme-overrides')` → re-merge → apply).
**Preset data format:** Same shape as the delta object. Example:
```json
{
"theme": {
"accent": "#0077b6",
"navBg": "#03045e",
"background": "#f0f7fa"
},
"themeDark": {
"accent": "#48cae4",
"navBg": "#03045e",
"background": "#0a1929"
}
}
```
Applying a preset **replaces** the entire delta (it's a `writeOverrides(presetData)`, not a merge onto existing overrides). The user can then further customize individual fields on top.
## Data Model
### Delta Object Format
The user override delta is a sparse object — it only contains fields the user has explicitly changed. The shape mirrors the server's `ThemeResponse` (from `/api/config/theme`) plus additional client-only sections:
```json
{
"branding": {
"siteName": "string — site name override",
"tagline": "string — tagline override",
"logoUrl": "string — custom logo URL",
"faviconUrl": "string — custom favicon URL"
},
"theme": {
"accent": "string — CSS color, light mode accent",
"accentHover": "string — CSS color, light mode accent hover",
"navBg": "string — CSS color, nav background",
"navBg2": "string — CSS color, nav secondary background",
"navText": "string — CSS color, nav text",
"navTextMuted": "string — CSS color, nav muted text",
"background": "string — CSS color, page background",
"text": "string — CSS color, body text",
"textMuted": "string — CSS color, muted text",
"border": "string — CSS color, borders",
"surface1": "string — CSS color, surface level 1",
"surface2": "string — CSS color, surface level 2",
"cardBg": "string — CSS color, card backgrounds",
"contentBg": "string — CSS color, content area background",
"detailBg": "string — CSS color, detail pane background",
"inputBg": "string — CSS color, input backgrounds",
"rowStripe": "string — CSS color, alternating row stripe",
"rowHover": "string — CSS color, row hover highlight",
"selectedBg": "string — CSS color, selected row background",
"statusGreen": "string — CSS color, healthy status",
"statusYellow": "string — CSS color, degraded status",
"statusRed": "string — CSS color, critical status",
"font": "string — CSS font-family for body text",
"mono": "string — CSS font-family for monospace"
},
"themeDark": {
"/* same keys as theme — dark mode overrides */"
},
"nodeColors": {
"repeater": "string — CSS color",
"companion": "string — CSS color",
"room": "string — CSS color",
"sensor": "string — CSS color",
"observer": "string — CSS color"
},
"typeColors": {
"ADVERT": "string — CSS color",
"GRP_TXT": "string — CSS color",
"TXT_MSG": "string — CSS color",
"ACK": "string — CSS color",
"REQUEST": "string — CSS color",
"RESPONSE": "string — CSS color",
"TRACE": "string — CSS color",
"PATH": "string — CSS color",
"ANON_REQ": "string — CSS color"
},
"home": {
"heroTitle": "string",
"heroSubtitle": "string",
"steps": "[array of {emoji, title, description}]",
"checklist": "[array of strings]",
"footerLinks": "[array of {label, url}]"
},
"timestamps": {
"defaultMode": "string — 'ago' | 'absolute'",
"timezone": "string — 'local' | 'utc'",
"formatPreset": "string — 'iso' | 'iso-seconds' | 'locale'",
"customFormat": "string — custom strftime-style format"
},
"heatmapOpacity": "number — 0.0 to 1.0",
"liveHeatmapOpacity": "number — 0.0 to 1.0"
}
```
**Rules:**
- All sections and keys are optional. An empty object `{}` means "no overrides."
- The `timestamps`, `heatmapOpacity`, and `liveHeatmapOpacity` keys are client-only extensions — not part of the server's `ThemeResponse`, but included in the universal format for portability.
### localStorage Key
**Key:** `cs-theme-overrides`
**Value:** JSON string of the delta object above.
**Absent key** = no overrides = effective config equals server defaults.
### Dark/Light Mode Preference
**Key:** `meshcore-theme`
**Value:** `"dark"` or `"light"` (or absent = follow system preference).
**This key is NOT part of the delta object.** It controls which mode is active, not which colors are used. The delta stores overrides for both modes independently in `theme` and `themeDark`.
## Data Flow Diagrams
### Page Load
```
┌─────────────┐ ┌──────────────────┐ ┌─────────────────┐
│ Fetch │ │ Read localStorage │ │ Migration check │
│ /api/config/ │ │ cs-theme-overrides│ │ (one-time) │
│ theme │ └────────┬─────────┘ └────────┬────────┘
└──────┬──────┘ │ │
│ │ ┌────────────────────┘
▼ ▼ ▼
serverDefaults userOverrides (possibly migrated)
│ │
▼ ▼
┌──────────────────────────────────────┐
│ computeEffective(server, userOverrides) │
└──────────────┬───────────────────────┘
┌──────────────────────────────────────┐
│ window.SITE_CONFIG = effective │ ← atomic assignment
└──────────────┬───────────────────────┘
┌──────────────────────┐
│ applyCSS(effective) │ ← sets CSS vars on :root for current mode
└──────────────────────┘
┌──────────────────────────────┐
│ dispatch 'theme-changed' │ ← bare signal, no payload
└──────────────────────────────┘
```
### User Change (e.g., picks new accent color)
```
User action (input/click)
debounce(300ms)
setOverride('theme', 'accent', '#ff0000')
├─► readOverrides() ← read current delta from localStorage
│ │
│ ▼
├─► update delta object ← set delta.theme.accent = '#ff0000'
│ │
│ ▼
├─► writeOverrides(delta) ← serialize & write to localStorage
│ │
│ ▼
├─► readOverrides() ← read BACK from localStorage (round-trip)
│ │
│ ▼
├─► computeEffective(server, delta)
│ │
│ ▼
├─► window.SITE_CONFIG = effective ← atomic assignment
│ │
│ ▼
└─► applyCSS(effective) ← CSS vars updated on :root
dispatch 'theme-changed'
```
**Color picker / slider exception:** During continuous `input` events (drag), CSS is updated optimistically (directly setting `--var` on `:root`) without the localStorage round-trip. The full pipeline above only runs on the `change` event (mouseup/blur).
### Per-Field Reset
```
User clicks reset icon on a field
clearOverride('theme', 'accent')
├─► readOverrides()
├─► delete delta.theme.accent
├─► if delta.theme is empty, delete delta.theme
├─► writeOverrides(delta)
├─► readOverrides() ← round-trip
├─► computeEffective(server, delta)
├─► window.SITE_CONFIG = effective
└─► applyCSS(effective)
dispatch 'theme-changed'
```
### Full Reset
```
User clicks "Reset All"
localStorage.removeItem('cs-theme-overrides')
computeEffective(server, {}) ← no overrides = server defaults
window.SITE_CONFIG = effective
applyCSS(effective)
dispatch 'theme-changed'
```
### Export
```
User clicks "Export"
readOverrides()
JSON.stringify(delta, null, 2)
trigger download as .json file
```
### Import
```
User selects .json file
parse JSON
validateShape(parsed) ← check structure, validate values
├─► invalid → show error, abort
▼ valid
writeOverrides(parsed)
readOverrides() ← round-trip
computeEffective(server, delta)
window.SITE_CONFIG = effective
applyCSS(effective)
dispatch 'theme-changed'
```
## Function Signatures
### `readOverrides() → object`
Reads `cs-theme-overrides` from localStorage, parses as JSON. Returns empty object `{}` on missing key, parse error, or non-object value. Never throws.
### `writeOverrides(delta: object) → void`
Serializes `delta` to JSON and writes to `cs-theme-overrides` in localStorage. If `delta` is empty (`{}`), removes the key entirely.
**Validation on write:**
- Color values must match: `#hex` (3, 4, 6, or 8 digit), `rgb()`, `rgba()`, `hsl()`, `hsla()`, or CSS named colors. Invalid color values are rejected (not written) with `console.warn`.
- Numeric values (`heatmapOpacity`, `liveHeatmapOpacity`) must be finite numbers in the range 01. Invalid values are rejected with `console.warn`.
- Timestamp enum values are validated against known options (`defaultMode`: `'ago'`/`'absolute'`; `timezone`: `'local'`/`'utc'`; `formatPreset`: `'iso'`/`'iso-seconds'`/`'locale'`). Invalid values are rejected with `console.warn`.
**Quota error handling:**
- Wrap `localStorage.setItem` in try/catch.
- On `QuotaExceededError`: show a visible warning to the user ("Storage full — changes may not be saved"), log to console.
- Do NOT silently swallow the error.
### `computeEffective(serverConfig: object, userOverrides: object) → object`
Deep merges `userOverrides` onto `serverConfig`. For each section (e.g., `theme`, `nodeColors`), if `userOverrides` has the section, its keys override the corresponding `serverConfig` keys. Top-level non-object keys (e.g., `heatmapOpacity`) are directly overridden.
Returns a new object — neither input is mutated.
**Merge rules:**
- Object sections: shallow merge per section (`Object.assign({}, server.theme, user.theme)`)
- Array sections (e.g., `home.steps`): full replacement (user array wins entirely, no element-level merge)
- Scalar sections (e.g., `heatmapOpacity`): direct replacement
After computing the effective config, writes it to `window.SITE_CONFIG` atomically (single assignment, not piecemeal mutations).
### `applyCSS(effectiveConfig: object) → void`
Maps effective config values to CSS custom properties on `:root`. Behavior:
1. Reads the current mode (light/dark) from the `meshcore-theme` localStorage key, falling back to system preference (`prefers-color-scheme`).
2. Applies the matching section's values: `theme` for light mode, `themeDark` for dark mode.
3. Also applies mode-independent values: node colors as `--node-{role}`, type colors as `--type-{name}`, font families as `--font-body` and `--font-mono`.
4. Does NOT generate dual CSS rule blocks — only the current mode's values are applied to `:root`.
5. On dark/light mode toggle, `applyCSS` is called again to re-apply the correct section.
Updates the `<style>` element (create if absent, reuse if present). Dispatches a `theme-changed` CustomEvent on `window` after applying.
### `theme-changed` Event
- `theme-changed` is a bare `CustomEvent` with no payload (matches current behavior).
- After each merge cycle, the effective config is written to `window.SITE_CONFIG` atomically (single assignment).
- `window.SITE_CONFIG` is the canonical readable source for effective config throughout the app. All existing listeners that read from `SITE_CONFIG` continue to work without changes.
### `setOverride(section: string, key: string, value: any) → void`
Sets a single override. For nested sections (e.g., `section='theme'`, `key='accent'`), sets `delta[section][key] = value`. For top-level scalars (e.g., `section=null`, `key='heatmapOpacity'`), sets `delta[key] = value`.
Follows the full data flow: read → update → write → read-back → merge → apply CSS → dispatch `theme-changed`. Debounced at ~300ms (the debounce wraps the write-through-to-CSS portion).
### `clearOverride(section: string, key: string) → void`
Removes a single key from the delta. If the section becomes empty after removal, removes the section too. Triggers the full data flow (no debounce — resets should feel instant).
### `migrateOldKeys() → object | null`
One-time migration. Checks for any of the 7 legacy localStorage keys. If found:
1. Reads all legacy values
2. Maps them into the new delta format (see Migration Plan)
3. Writes the merged delta to `cs-theme-overrides`
4. Removes all 7 legacy keys
5. Returns the migrated delta
Returns `null` if no legacy keys found.
### `validateShape(obj: any) → { valid: boolean, errors: string[] }`
Validates that an imported object conforms to the expected shape:
- Must be a plain object
- Top-level keys must be from the known set: `branding`, `theme`, `themeDark`, `nodeColors`, `typeColors`, `home`, `timestamps`, `heatmapOpacity`, `liveHeatmapOpacity`
- Section values must be objects (where expected) or correct scalar types
- Color values are validated: must match `#hex` (3, 4, 6, or 8 digit), `rgb()`, `rgba()`, `hsl()`, `hsla()`, or CSS named colors
- Numeric values (`heatmapOpacity`, `liveHeatmapOpacity`) must be finite numbers in range 01
- Timestamp enum values validated against known options
Unknown top-level keys cause a warning but don't fail validation (forward compatibility).
## Migration Plan
On first page load, before the normal init flow:
1. Check if `cs-theme-overrides` already exists → if yes, skip migration.
2. Check if ANY of the 7 legacy keys exist in localStorage.
3. If legacy keys found, build a delta object using the exact mapping below:
### Field-by-Field Migration Mapping
```
meshcore-user-theme (JSON) → parse, map directly:
.branding → delta.branding
.theme → delta.theme
.themeDark → delta.themeDark
.nodeColors → delta.nodeColors
.typeColors → delta.typeColors
.home → delta.home
(any other keys are dropped)
meshcore-timestamp-mode → delta.timestamps.defaultMode
meshcore-timestamp-timezone → delta.timestamps.timezone
meshcore-timestamp-format → delta.timestamps.formatPreset
meshcore-timestamp-custom-format → delta.timestamps.customFormat
meshcore-heatmap-opacity → delta.heatmapOpacity (parseFloat)
meshcore-live-heatmap-opacity → delta.liveHeatmapOpacity (parseFloat)
```
4. Write the assembled delta to `cs-theme-overrides`.
5. Delete all 7 legacy keys.
6. Continue with normal init.
**Edge cases:**
- If `meshcore-user-theme` contains invalid JSON, skip it (log a warning to console).
- If a legacy value is empty string or null, skip that field.
- Migration runs exactly once — the presence of `cs-theme-overrides` (even as `{}`) prevents re-migration.
## `allowCustomFormat` — User Preferences Trump
The server-side `allowCustomFormat` gate is not enforced client-side. If a user imports a delta with a custom format, it's applied regardless. The server controls what formats are available in the UI (whether the custom format input field is shown), but does not block stored preferences.
## Override Indicator UX
In the customizer panel, each field that has an active override (value differs from server default) shows a visual indicator:
- **Indicator:** A small dot or icon (e.g., `●` or a reset arrow `↺`) adjacent to the field label.
- **Color:** Use the accent color to draw attention without being noisy.
- **Behavior:** Clicking the indicator resets that single field (calls `clearOverride`).
- **Tooltip:** "Reset to server default" or "This value differs from the server default."
- **Absence:** Fields matching the server default show no indicator — clean and minimal.
**Section-level indicator:** If any field in a section (e.g., "Theme Colors") is overridden, the tab/section header shows a count badge (e.g., "Theme Colors (3)").
**"Reset All" button:** Always visible at bottom of panel. Confirms before executing (`localStorage.removeItem` + re-merge).
## UX Requirements
### Browser-Local Banner
The customizer panel must display a persistent, always-visible notice:
> **"These settings are saved in your browser only and don't affect other users."**
This is NOT a tooltip, NOT a dismissible popup — it must be always visible in the panel header or footer area. Users must understand at a glance that their changes are local.
### Auto-Save Indicator
Show a persistent status in the customizer panel footer, Google Docs style — subtle but always present:
- **Default state:** "All changes saved" (muted text)
- **During debounce:** "Saving..." (muted text)
- **On quota error:** "⚠️ Storage full — changes may not be saved" (red text, persistent until resolved)
The indicator reflects the actual state of the localStorage write, not just the UI action.
## Server Compatibility
The delta format is intentionally shaped to be a valid subset of the server's `theme.json` admin config file. This means:
- **User export → admin import:** An admin can take a user's exported JSON and drop it into `theme.json` as server defaults. The `timestamps`, `heatmapOpacity`, and `liveHeatmapOpacity` keys are ignored by the current server (it doesn't read them from `theme.json`), but they don't cause errors.
- **Admin config → user import:** A `theme.json` file can be imported as user overrides. Unknown server-only keys are ignored by the client.
- **Round-trip safe:** Export → import produces identical delta (assuming no server default changes between operations).
The server's `ThemeResponse` struct currently returns: `branding`, `theme`, `themeDark`, `nodeColors`, `typeColors`, `home`. The client-only extensions (`timestamps`, `heatmapOpacity`, `liveHeatmapOpacity`) are additive — they extend the format without conflicting.
## Testing Requirements
### Unit Tests (Node.js, no browser required)
1. **`readOverrides`**
- Returns `{}` when key is absent
- Returns `{}` when key contains invalid JSON
- Returns `{}` when key contains a non-object (string, array, number)
- Returns parsed object when key contains valid JSON object
2. **`writeOverrides`**
- Writes serialized JSON to localStorage
- Removes key when delta is empty `{}`
- Round-trips correctly (write → read = identical object)
- Rejects invalid color values with console.warn
- Rejects out-of-range numeric values with console.warn
- Rejects invalid timestamp enum values with console.warn
- Handles QuotaExceededError gracefully (warns user, does not throw)
3. **`computeEffective`**
- Returns server defaults when overrides is `{}`
- Overrides a single key in a section
- Overrides multiple keys across sections
- Does not mutate either input
- Handles missing sections in overrides gracefully
- Array values (e.g., `home.steps`) are fully replaced, not merged
- Top-level scalars (`heatmapOpacity`) are directly replaced
4. **`setOverride` / `clearOverride`**
- Setting a value stores it in the delta
- Clearing a key removes it from delta
- Clearing the last key in a section removes the section
- Full data flow executes (CSS vars updated)
5. **`migrateOldKeys`**
- Migrates all 7 keys correctly using exact field mapping
- Handles partial migration (only some keys present)
- Handles invalid JSON in `meshcore-user-theme`
- Removes all legacy keys after migration
- Skips migration if `cs-theme-overrides` already exists
- Returns null when no legacy keys found
- Drops unknown keys from `meshcore-user-theme`
6. **`validateShape`**
- Accepts valid delta objects
- Accepts empty object
- Rejects non-objects (string, array, null)
- Warns on unknown top-level keys (doesn't reject)
- Validates section types (object vs scalar)
- Rejects invalid color values
- Rejects out-of-range opacity values
- Rejects invalid timestamp enum values
### Browser/E2E Tests (Playwright)
1. **Customizer opens and shows current values** — fields reflect effective config.
2. **Changing a color updates CSS variable** — after debounce, `:root` has new value.
3. **Override indicator appears** when value differs from server default.
4. **Per-field reset** removes override, reverts to server default, indicator disappears.
5. **Full reset** clears all overrides, all fields show server defaults.
6. **Export** downloads a JSON file with current delta.
7. **Import** applies overrides from uploaded JSON file.
8. **Migration** — set legacy keys, reload, verify they're migrated and removed.
9. **Preset application** — clicking a preset applies its colors, fields update.
10. **Dark/light mode toggle** — switching mode re-applies correct section's CSS vars.
11. **Browser-local banner** — verify persistent notice is visible in customizer panel.
12. **Auto-save indicator** — verify status text updates during and after changes.
## What's NOT In Scope
- **Undo/redo stack** — could be added as P2. For v1, per-field reset to server default is the only revert mechanism.
- **Cross-tab synchronization** — two tabs editing simultaneously may clobber each other's changes. Acceptable for v1.
- **Server-side timestamp config** (`allowCustomFormat` gate) — remains server-only, not exposed in the customizer delta. The server controls UI availability but does not block stored preferences (see `allowCustomFormat` section above).
- **Admin import endpoint** — no server API for uploading `theme.json` via the UI. Admins edit the file directly. Future work.
- **Map config overrides** (`mapDefaults.center`, `mapDefaults.zoom`) — separate concern, not part of theme. Future work.
- **Geo-filter config** — server-only. Not in scope.
- **Per-page layout preferences** (column widths, sort orders) — separate from theming. Future work.
File diff suppressed because it is too large Load Diff
+16 -85
View File
@@ -136,13 +136,6 @@ function getTimestampCustomFormat() {
function pad2(v) { return String(v).padStart(2, '0'); }
function pad3(v) { return String(v).padStart(3, '0'); }
function mergeUserHomeConfig(siteConfig, userTheme) {
if (!siteConfig || !userTheme || !userTheme.home || typeof userTheme.home !== 'object') return siteConfig;
const serverHome = (siteConfig.home && typeof siteConfig.home === 'object') ? siteConfig.home : {};
siteConfig.home = Object.assign({}, serverHome, userTheme.home);
return siteConfig;
}
function formatIsoLike(d, timezone, includeMs) {
const useUtc = timezone === 'utc';
const year = useUtc ? d.getUTCFullYear() : d.getFullYear();
@@ -794,92 +787,30 @@ window.addEventListener('DOMContentLoaded', () => {
debouncedOnWS(function () { updateNavStats(); });
// --- Theme Customization ---
// Fetch theme config and apply branding/colors before first render
// Fetch theme config and apply via customizer v2 pipeline
fetch('/api/config/theme', { cache: 'no-store' }).then(r => r.json()).then(cfg => {
window.SITE_CONFIG = cfg || {};
if (!window.SITE_CONFIG.timestamps) window.SITE_CONFIG.timestamps = {};
const tsCfg = window.SITE_CONFIG.timestamps;
// Normalize timestamp defaults
cfg = cfg || {};
if (!cfg.timestamps) cfg.timestamps = {};
const tsCfg = cfg.timestamps;
if (tsCfg.defaultMode !== 'absolute' && tsCfg.defaultMode !== 'ago') tsCfg.defaultMode = 'ago';
if (tsCfg.timezone !== 'utc' && tsCfg.timezone !== 'local') tsCfg.timezone = 'local';
if (tsCfg.formatPreset !== 'iso' && tsCfg.formatPreset !== 'iso-seconds' && tsCfg.formatPreset !== 'locale') tsCfg.formatPreset = 'iso';
if (typeof tsCfg.customFormat !== 'string') tsCfg.customFormat = '';
tsCfg.allowCustomFormat = tsCfg.allowCustomFormat === true;
// User's localStorage preferences take priority over server config
const userTheme = (() => { try { return JSON.parse(localStorage.getItem('meshcore-user-theme') || '{}'); } catch { return {}; } })();
window._SITE_CONFIG_ORIGINAL_HOME = JSON.parse(JSON.stringify(window.SITE_CONFIG.home || {}));
mergeUserHomeConfig(window.SITE_CONFIG, userTheme);
// Apply CSS variable overrides from theme config (skipped if user has local overrides)
if (!userTheme.theme && !userTheme.themeDark) {
const dark = document.documentElement.getAttribute('data-theme') === 'dark' ||
(document.documentElement.getAttribute('data-theme') !== 'light' && window.matchMedia('(prefers-color-scheme: dark)').matches);
const themeData = dark ? { ...(cfg.theme || {}), ...(cfg.themeDark || {}) } : (cfg.theme || {});
const root = document.documentElement.style;
const varMap = {
accent: '--accent', accentHover: '--accent-hover',
navBg: '--nav-bg', navBg2: '--nav-bg2', navText: '--nav-text', navTextMuted: '--nav-text-muted',
background: '--surface-0', text: '--text', textMuted: '--text-muted', border: '--border',
statusGreen: '--status-green', statusYellow: '--status-yellow', statusRed: '--status-red',
surface1: '--surface-1', surface2: '--surface-2', surface3: '--surface-3',
cardBg: '--card-bg', contentBg: '--content-bg', inputBg: '--input-bg',
rowStripe: '--row-stripe', rowHover: '--row-hover', detailBg: '--detail-bg',
selectedBg: '--selected-bg', sectionBg: '--section-bg',
font: '--font', mono: '--mono'
};
for (const [key, cssVar] of Object.entries(varMap)) {
if (themeData[key]) root.setProperty(cssVar, themeData[key]);
}
// Derived vars
if (themeData.background) root.setProperty('--content-bg', themeData.contentBg || themeData.background);
if (themeData.surface1) root.setProperty('--card-bg', themeData.cardBg || themeData.surface1);
// Nav gradient
if (themeData.navBg) {
const nav = document.querySelector('.top-nav');
if (nav) nav.style.background = `linear-gradient(135deg, ${themeData.navBg} 0%, ${themeData.navBg2 || themeData.navBg} 50%, ${themeData.navBg} 100%)`;
}
// Customizer v2: set server defaults and run full pipeline
// (reads localStorage overrides → merges → sets SITE_CONFIG → applies CSS → dispatches theme-changed)
if (window._customizerV2) {
window._customizerV2.init(cfg);
} else {
// Fallback if customize-v2.js didn't load
window.SITE_CONFIG = cfg;
}
// Apply node color overrides (skip if user has local preferences)
if (cfg.nodeColors && !userTheme.nodeColors) {
for (const [role, color] of Object.entries(cfg.nodeColors)) {
if (window.ROLE_COLORS && role in window.ROLE_COLORS) window.ROLE_COLORS[role] = color;
if (window.ROLE_STYLE && window.ROLE_STYLE[role]) window.ROLE_STYLE[role].color = color;
}
}
// Apply type color overrides (skip if user has local preferences)
if (cfg.typeColors && !userTheme.typeColors) {
for (const [type, color] of Object.entries(cfg.typeColors)) {
if (window.TYPE_COLORS && type in window.TYPE_COLORS) window.TYPE_COLORS[type] = color;
}
if (window.syncBadgeColors) window.syncBadgeColors();
}
// Apply branding (skip if user has local preferences)
if (cfg.branding && !userTheme.branding) {
if (cfg.branding.siteName) {
document.title = cfg.branding.siteName;
const brandText = document.querySelector('.brand-text');
if (brandText) brandText.textContent = cfg.branding.siteName;
}
if (cfg.branding.logoUrl) {
const brandIcon = document.querySelector('.brand-icon');
if (brandIcon) {
const img = document.createElement('img');
img.src = cfg.branding.logoUrl;
img.alt = cfg.branding.siteName || 'Logo';
img.style.height = '24px';
img.style.width = 'auto';
brandIcon.replaceWith(img);
}
}
if (cfg.branding.faviconUrl) {
const favicon = document.querySelector('link[rel="icon"]');
if (favicon) favicon.href = cfg.branding.faviconUrl;
}
}
}).catch(() => { window.SITE_CONFIG = { timestamps: { defaultMode: 'ago', timezone: 'local', formatPreset: 'iso', customFormat: '', allowCustomFormat: false } }; }).finally(() => {
}).catch(() => {
window.SITE_CONFIG = { timestamps: { defaultMode: 'ago', timezone: 'local', formatPreset: 'iso', customFormat: '', allowCustomFormat: false } };
if (window._customizerV2) window._customizerV2.init(window.SITE_CONFIG);
}).finally(() => {
if (!location.hash || location.hash === '#/') location.hash = '#/home';
else navigate();
});
File diff suppressed because it is too large Load Diff
+1 -1
View File
@@ -86,7 +86,7 @@
<script src="vendor/qrcode.js"></script>
<script src="roles.js?v=__BUST__"></script>
<script src="customize.js?v=__BUST__" onerror="console.error('Failed to load:', this.src)"></script>
<script src="customize-v2.js?v=__BUST__" onerror="console.error('Failed to load:', this.src)"></script>
<script src="region-filter.js?v=__BUST__"></script>
<script src="hop-resolver.js?v=__BUST__"></script>
<script src="hop-display.js?v=__BUST__"></script>
+15
View File
@@ -1957,6 +1957,7 @@
let lastPulse = performance.now();
const pulseStart = lastPulse;
function animatePulse(now) {
if (!animLayer) return;
if (now - pulseStart > 2000) {
try { animLayer.removeLayer(ring); } catch {}
return;
@@ -2201,6 +2202,10 @@
const startTime = performance.now();
function tick(now) {
if (!animLayer || !pathsLayer) {
if (onComplete) onComplete();
return;
}
const elapsed = now - startTime;
const t = Math.min(1, elapsed / DURATION_MS);
const lat = from[0] + (to[0] - from[0]) * t;
@@ -2245,6 +2250,11 @@
// Fade out
const fadeStart = performance.now();
function fadeOut(now) {
if (!animLayer || !pathsLayer) {
charMarkers.length = 0;
if (onComplete) onComplete();
return;
}
const ft = Math.min(1, (now - fadeStart) / 300);
if (ft >= 1) {
for (const cm of charMarkers) try { animLayer.removeLayer(cm.marker); } catch {}
@@ -2292,6 +2302,10 @@
let lastStep = performance.now();
function animateLine(now) {
if (!animLayer || !pathsLayer) {
if (onComplete) onComplete();
return;
}
const elapsed = now - lastStep;
if (elapsed >= 33) {
const ticks = Math.min(Math.floor(elapsed / 33), 4);
@@ -2320,6 +2334,7 @@
let fadeOp = mainOpacity;
let lastFade = performance.now();
function animateFade(now) {
if (!pathsLayer) return;
const fadeElapsed = now - lastFade;
if (fadeElapsed >= 52) {
const fadeTicks = Math.min(Math.floor(fadeElapsed / 52), 4);
+23 -12
View File
@@ -749,21 +749,30 @@
selectedReferenceNode = pubkey;
neighborPubkeys = new Set();
try {
const data = await api('/nodes/' + pubkey + '/paths');
const paths = data.paths || [];
for (const p of paths) {
const hops = p.hops || [];
// Find the reference node in the path; direct neighbors are adjacent hops
for (let i = 0; i < hops.length; i++) {
if (hops[i].pubkey === pubkey) {
if (i > 0 && hops[i - 1].pubkey) neighborPubkeys.add(hops[i - 1].pubkey);
if (i < hops.length - 1 && hops[i + 1].pubkey) neighborPubkeys.add(hops[i + 1].pubkey);
// Use affinity-based neighbor API (server-side disambiguation) instead of
// client-side path walking which fails on hash collisions (#484)
const data = await api('/nodes/' + pubkey + '/neighbors?min_count=3');
for (const n of (data.neighbors || [])) {
if (n.pubkey) neighborPubkeys.add(n.pubkey);
// For ambiguous edges, include all candidates (better to show extra than miss)
if (n.candidates) n.candidates.forEach(function(c) { if (c.pubkey) neighborPubkeys.add(c.pubkey); });
}
// If affinity data is insufficient, fall back to client-side path walking
if (neighborPubkeys.size === 0) {
const pathData = await api('/nodes/' + pubkey + '/paths');
const paths = pathData.paths || [];
for (const p of paths) {
const hops = p.hops || [];
for (var i = 0; i < hops.length; i++) {
if (hops[i].pubkey === pubkey) {
if (i > 0 && hops[i - 1].pubkey) neighborPubkeys.add(hops[i - 1].pubkey);
if (i < hops.length - 1 && hops[i + 1].pubkey) neighborPubkeys.add(hops[i + 1].pubkey);
}
}
}
// (Redundant block removed — the main loop above already handles first/last hops)
}
} catch (e) {
console.warn('Failed to fetch neighbor paths for', pubkey, '— neighbor filter may be incomplete:', e);
console.warn('Failed to fetch neighbors for', pubkey, ':', e);
neighborPubkeys = new Set();
}
// Update sidebar UI
@@ -779,8 +788,9 @@
if (cb) cb.checked = true;
renderMarkers();
}
// Expose for popup onclick
// Expose for popup onclick and testing
window._mapSelectRefNode = selectReferenceNode;
window._mapGetNeighborPubkeys = function() { return neighborPubkeys ? Array.from(neighborPubkeys) : []; };
function buildPopup(node) {
const key = node.public_key ? truncate(node.public_key, 16) : '—';
@@ -839,6 +849,7 @@
selectedReferenceNode = null;
neighborPubkeys = null;
delete window._mapSelectRefNode;
delete window._mapGetNeighborPubkeys;
}
function toggleHeatmap(on) {
+408
View File
@@ -0,0 +1,408 @@
/* Unit tests for customizer v2 core functions */
'use strict';
const vm = require('vm');
const fs = require('fs');
const assert = require('assert');
let passed = 0, failed = 0;
function test(name, fn) {
try { fn(); passed++; console.log(`${name}`); }
catch (e) { failed++; console.log(`${name}: ${e.message}`); }
}
function makeSandbox() {
const storage = {};
const localStorage = {
_data: storage,
getItem(k) { return k in storage ? storage[k] : null; },
setItem(k, v) { storage[k] = String(v); },
removeItem(k) { delete storage[k]; },
clear() { for (const k in storage) delete storage[k]; }
};
const ctx = {
window: {
addEventListener: () => {},
dispatchEvent: () => {},
SITE_CONFIG: {},
_SITE_CONFIG_ORIGINAL_HOME: null,
},
document: {
readyState: 'loading',
createElement: (tag) => ({
id: '', textContent: '', innerHTML: '', className: '',
setAttribute: () => {}, appendChild: () => {},
style: {}, addEventListener: () => {},
querySelectorAll: () => [], querySelector: () => null,
}),
head: { appendChild: () => {} },
getElementById: () => null,
addEventListener: () => {},
querySelectorAll: () => [],
querySelector: () => null,
documentElement: {
style: { setProperty: () => {}, removeProperty: () => {}, getPropertyValue: () => '' },
dataset: { theme: 'dark' },
getAttribute: () => 'dark',
},
},
console,
localStorage,
setTimeout: (fn) => fn(),
clearTimeout: () => {},
Date, Math, Array, Object, JSON, String, Number, Boolean,
parseInt, parseFloat, isNaN, Infinity, NaN, undefined,
MutationObserver: class { observe() {} },
HashChangeEvent: class {},
CustomEvent: class CustomEvent { constructor(type, opts) { this.type = type; this.detail = opts && opts.detail; } },
getComputedStyle: () => ({ getPropertyValue: () => '' }),
};
ctx.window.localStorage = localStorage;
ctx.self = ctx.window;
return ctx;
}
function loadCustomizer() {
const ctx = makeSandbox();
const code = fs.readFileSync('public/customize-v2.js', 'utf8');
vm.createContext(ctx);
vm.runInContext(code, ctx, { filename: 'customize-v2.js' });
return { ctx, api: ctx.window._customizerV2, ls: ctx.localStorage };
}
console.log('\n📋 Customizer V2 — Core Function Tests\n');
// ── readOverrides ──
console.log('readOverrides:');
test('returns {} when key is absent', () => {
const { api } = loadCustomizer();
const result = api.readOverrides();
assert.strictEqual(JSON.stringify(result), '{}');
});
test('returns {} when key contains invalid JSON', () => {
const { api, ls } = loadCustomizer();
ls.setItem('cs-theme-overrides', 'not json{{{');
assert.strictEqual(JSON.stringify(api.readOverrides()), '{}');
});
test('returns {} when key contains a non-object (string)', () => {
const { api, ls } = loadCustomizer();
ls.setItem('cs-theme-overrides', '"just a string"');
assert.strictEqual(JSON.stringify(api.readOverrides()), '{}');
});
test('returns {} when key contains an array', () => {
const { api, ls } = loadCustomizer();
ls.setItem('cs-theme-overrides', '[1,2,3]');
assert.strictEqual(JSON.stringify(api.readOverrides()), '{}');
});
test('returns {} when key contains a number', () => {
const { api, ls } = loadCustomizer();
ls.setItem('cs-theme-overrides', '42');
assert.strictEqual(JSON.stringify(api.readOverrides()), '{}');
});
test('returns parsed object when valid', () => {
const { api, ls } = loadCustomizer();
const data = { theme: { accent: '#ff0000' } };
ls.setItem('cs-theme-overrides', JSON.stringify(data));
assert.deepStrictEqual(api.readOverrides(), data);
});
// ── writeOverrides ──
console.log('\nwriteOverrides:');
test('writes serialized JSON to localStorage', () => {
const { api, ls } = loadCustomizer();
const data = { theme: { accent: '#ff0000' } };
api.writeOverrides(data);
assert.deepStrictEqual(JSON.parse(ls.getItem('cs-theme-overrides')), data);
});
test('removes key when delta is empty {}', () => {
const { api, ls } = loadCustomizer();
ls.setItem('cs-theme-overrides', '{"theme":{}}');
api.writeOverrides({});
assert.strictEqual(ls.getItem('cs-theme-overrides'), null);
});
test('round-trips correctly (write → read = identical)', () => {
const { api } = loadCustomizer();
const data = { theme: { accent: '#abc', text: '#def' }, nodeColors: { repeater: '#111' } };
api.writeOverrides(data);
assert.deepStrictEqual(api.readOverrides(), data);
});
test('strips invalid color values silently', () => {
const { api, ls } = loadCustomizer();
api.writeOverrides({ theme: { accent: 'not-a-color' } });
// Invalid color is stripped by _validateDelta; remaining empty object is stored as '{}'
const stored = JSON.parse(ls.getItem('cs-theme-overrides'));
assert.strictEqual(stored.theme, undefined);
});
test('strips out-of-range opacity', () => {
const { api, ls } = loadCustomizer();
api.writeOverrides({ heatmapOpacity: 1.5 });
const stored1 = JSON.parse(ls.getItem('cs-theme-overrides'));
assert.strictEqual(stored1.heatmapOpacity, undefined);
api.writeOverrides({ heatmapOpacity: -0.1 });
const stored2 = JSON.parse(ls.getItem('cs-theme-overrides'));
assert.strictEqual(stored2.heatmapOpacity, undefined);
});
test('accepts valid opacity', () => {
const { api, ls } = loadCustomizer();
api.writeOverrides({ heatmapOpacity: 0.5 });
const stored = JSON.parse(ls.getItem('cs-theme-overrides'));
assert.strictEqual(stored.heatmapOpacity, 0.5);
});
// ── computeEffective ──
console.log('\ncomputeEffective:');
test('returns server defaults when overrides is {}', () => {
const { api } = loadCustomizer();
const defaults = { theme: { accent: '#aaa', text: '#bbb' }, nodeColors: { repeater: '#ccc' } };
const result = api.computeEffective(defaults, {});
assert.deepStrictEqual(result, defaults);
});
test('overrides a single key in a section', () => {
const { api } = loadCustomizer();
const defaults = { theme: { accent: '#aaa', text: '#bbb' } };
const result = api.computeEffective(defaults, { theme: { accent: '#ff0000' } });
assert.strictEqual(result.theme.accent, '#ff0000');
assert.strictEqual(result.theme.text, '#bbb');
});
test('overrides multiple keys across sections', () => {
const { api } = loadCustomizer();
const defaults = { theme: { accent: '#aaa' }, nodeColors: { repeater: '#bbb' } };
const result = api.computeEffective(defaults, { theme: { accent: '#111' }, nodeColors: { repeater: '#222' } });
assert.strictEqual(result.theme.accent, '#111');
assert.strictEqual(result.nodeColors.repeater, '#222');
});
test('does not mutate either input', () => {
const { api } = loadCustomizer();
const defaults = { theme: { accent: '#aaa' } };
const overrides = { theme: { accent: '#bbb' } };
const defCopy = JSON.stringify(defaults);
const ovrCopy = JSON.stringify(overrides);
api.computeEffective(defaults, overrides);
assert.strictEqual(JSON.stringify(defaults), defCopy);
assert.strictEqual(JSON.stringify(overrides), ovrCopy);
});
test('handles missing sections in overrides gracefully', () => {
const { api } = loadCustomizer();
const defaults = { theme: { accent: '#aaa' }, nodeColors: { repeater: '#bbb' } };
const result = api.computeEffective(defaults, { theme: { accent: '#ccc' } });
assert.strictEqual(result.nodeColors.repeater, '#bbb');
});
test('array values in home are fully replaced, not merged', () => {
const { api } = loadCustomizer();
const defaults = { home: { steps: [{ emoji: '1', title: 'a', description: 'b' }], heroTitle: 'X' } };
const overrides = { home: { steps: [{ emoji: '2', title: 'c', description: 'd' }, { emoji: '3', title: 'e', description: 'f' }] } };
const result = api.computeEffective(defaults, overrides);
assert.strictEqual(result.home.steps.length, 2);
assert.strictEqual(result.home.steps[0].emoji, '2');
assert.strictEqual(result.home.heroTitle, 'X'); // untouched
});
test('top-level scalars are directly replaced', () => {
const { api } = loadCustomizer();
const defaults = { heatmapOpacity: 0.5 };
const result = api.computeEffective(defaults, { heatmapOpacity: 0.8 });
assert.strictEqual(result.heatmapOpacity, 0.8);
});
// ── validateShape ──
console.log('\nvalidateShape:');
test('accepts valid delta objects', () => {
const { api } = loadCustomizer();
const result = api.validateShape({ theme: { accent: '#fff' }, heatmapOpacity: 0.5 });
assert.strictEqual(result.valid, true);
});
test('accepts empty object', () => {
const { api } = loadCustomizer();
assert.strictEqual(api.validateShape({}).valid, true);
});
test('rejects non-objects (string)', () => {
const { api } = loadCustomizer();
assert.strictEqual(api.validateShape('hello').valid, false);
});
test('rejects non-objects (array)', () => {
const { api } = loadCustomizer();
assert.strictEqual(api.validateShape([1, 2]).valid, false);
});
test('rejects non-objects (null)', () => {
const { api } = loadCustomizer();
assert.strictEqual(api.validateShape(null).valid, false);
});
test('warns on unknown top-level keys', () => {
const { api } = loadCustomizer();
const result = api.validateShape({ unknownKey: {} });
// Unknown keys produce a console.warn but validateShape still returns valid
assert.strictEqual(result.valid, true);
assert.strictEqual(result.errors.length, 0);
});
test('validates section types (rejects non-object section)', () => {
const { api } = loadCustomizer();
const result = api.validateShape({ theme: 'not an object' });
assert.strictEqual(result.valid, false);
});
test('accepts valid rgb() color values in theme', () => {
const { api } = loadCustomizer();
const result = api.validateShape({ theme: { accent: 'rgb(1,2,3)' } });
assert.strictEqual(result.valid, true);
});
test('rejects out-of-range opacity values', () => {
const { api } = loadCustomizer();
assert.strictEqual(api.validateShape({ heatmapOpacity: 2.0 }).valid, false);
assert.strictEqual(api.validateShape({ liveHeatmapOpacity: -1 }).valid, false);
});
// ── migrateOldKeys ──
console.log('\nmigrateOldKeys:');
test('migrates all 7 keys correctly', () => {
const { api, ls } = loadCustomizer();
ls.setItem('meshcore-user-theme', JSON.stringify({ theme: { accent: '#f00' }, branding: { siteName: 'Test' } }));
ls.setItem('meshcore-timestamp-mode', 'absolute');
ls.setItem('meshcore-timestamp-timezone', 'utc');
ls.setItem('meshcore-timestamp-format', 'iso-seconds');
ls.setItem('meshcore-timestamp-custom-format', 'YYYY-MM-DD');
ls.setItem('meshcore-heatmap-opacity', '0.7');
ls.setItem('meshcore-live-heatmap-opacity', '0.3');
const result = api.migrateOldKeys();
assert.strictEqual(result.theme.accent, '#f00');
assert.strictEqual(result.branding.siteName, 'Test');
assert.strictEqual(result.timestamps.defaultMode, 'absolute');
assert.strictEqual(result.timestamps.timezone, 'utc');
assert.strictEqual(result.heatmapOpacity, 0.7);
assert.strictEqual(result.liveHeatmapOpacity, 0.3);
// Legacy keys removed
assert.strictEqual(ls.getItem('meshcore-user-theme'), null);
assert.strictEqual(ls.getItem('meshcore-timestamp-mode'), null);
// New key written
assert.notStrictEqual(ls.getItem('cs-theme-overrides'), null);
});
test('handles partial migration (only some keys)', () => {
const { api, ls } = loadCustomizer();
ls.setItem('meshcore-timestamp-mode', 'ago');
const result = api.migrateOldKeys();
assert.strictEqual(result.timestamps.defaultMode, 'ago');
assert.strictEqual(ls.getItem('meshcore-timestamp-mode'), null);
});
test('handles invalid JSON in meshcore-user-theme', () => {
const { api, ls } = loadCustomizer();
ls.setItem('meshcore-user-theme', '{bad json');
const result = api.migrateOldKeys();
// Should not crash, returns delta (possibly empty besides what was valid)
assert(result !== null);
assert.strictEqual(ls.getItem('meshcore-user-theme'), null);
});
test('skips migration if cs-theme-overrides already exists', () => {
const { api, ls } = loadCustomizer();
ls.setItem('cs-theme-overrides', '{"theme":{}}');
ls.setItem('meshcore-user-theme', JSON.stringify({ theme: { accent: '#f00' } }));
const result = api.migrateOldKeys();
assert.strictEqual(result, null);
// Legacy key NOT removed (migration skipped entirely)
assert.notStrictEqual(ls.getItem('meshcore-user-theme'), null);
});
test('returns null when no legacy keys found', () => {
const { api } = loadCustomizer();
assert.strictEqual(api.migrateOldKeys(), null);
});
test('drops unknown keys from meshcore-user-theme', () => {
const { api, ls } = loadCustomizer();
ls.setItem('meshcore-user-theme', JSON.stringify({ theme: { accent: '#f00' }, unknownStuff: 'hi' }));
const result = api.migrateOldKeys();
assert.strictEqual(result.theme.accent, '#f00');
assert.strictEqual(result.unknownStuff, undefined);
});
// ── THEME_CSS_MAP completeness ──
console.log('\nTHEME_CSS_MAP:');
test('includes surface3 mapping', () => {
const { api } = loadCustomizer();
assert.strictEqual(api.THEME_CSS_MAP.surface3, '--surface-3');
});
test('includes sectionBg mapping', () => {
const { api } = loadCustomizer();
assert.strictEqual(api.THEME_CSS_MAP.sectionBg, '--section-bg');
});
test('matches all keys from old app.js varMap', () => {
const { api } = loadCustomizer();
const expectedKeys = [
'accent', 'accentHover', 'navBg', 'navBg2', 'navText', 'navTextMuted',
'background', 'text', 'textMuted', 'border',
'statusGreen', 'statusYellow', 'statusRed',
'surface1', 'surface2', 'surface3',
'cardBg', 'contentBg', 'inputBg',
'rowStripe', 'rowHover', 'detailBg',
'selectedBg', 'sectionBg',
'font', 'mono'
];
for (const key of expectedKeys) {
assert(key in api.THEME_CSS_MAP, `Missing key: ${key}`);
}
});
// ── _isOverridden tests ──
console.log('\n_isOverridden (value comparison):');
test('returns false when no overrides exist', () => {
const { api } = loadCustomizer();
api.init({ theme: { accent: '#aaa' } });
assert.strictEqual(api.isOverridden('theme', 'accent'), false);
});
test('returns false when override matches server default', () => {
const { api, ls } = loadCustomizer();
ls.setItem('cs-theme-overrides', JSON.stringify({ theme: { accent: '#aaa' } }));
api.init({ theme: { accent: '#aaa' } });
assert.strictEqual(api.isOverridden('theme', 'accent'), false);
});
test('returns true when override differs from server default', () => {
const { api, ls } = loadCustomizer();
ls.setItem('cs-theme-overrides', JSON.stringify({ theme: { accent: '#bbb' } }));
api.init({ theme: { accent: '#aaa' } });
assert.strictEqual(api.isOverridden('theme', 'accent'), true);
});
test('returns false for key not in overrides', () => {
const { api, ls } = loadCustomizer();
ls.setItem('cs-theme-overrides', JSON.stringify({ theme: { accent: '#bbb' } }));
api.init({ theme: { accent: '#aaa', border: '#ccc' } });
assert.strictEqual(api.isOverridden('theme', 'border'), false);
});
test('returns true when server has no default for overridden key', () => {
const { api, ls } = loadCustomizer();
ls.setItem('cs-theme-overrides', JSON.stringify({ theme: { accent: '#bbb' } }));
api.init({});
assert.strictEqual(api.isOverridden('theme', 'accent'), true);
});
// ── Summary ──
console.log(`\n${passed + failed} tests: ${passed} passed, ${failed} failed\n`);
process.exit(failed > 0 ? 1 : 0);
+396 -5
View File
@@ -85,7 +85,7 @@ async function run() {
await page.goto(BASE, { waitUntil: 'domcontentloaded' });
await page.waitForSelector('nav, .navbar, .nav, [class*="nav"]');
await page.evaluate(() => {
localStorage.removeItem('meshcore-user-theme');
localStorage.removeItem('cs-theme-overrides');
window.SITE_CONFIG = window.SITE_CONFIG || {};
window.SITE_CONFIG.home = {
heroTitle: 'Server Hero (E2E)',
@@ -122,18 +122,18 @@ async function run() {
const homeTab = page.locator('.cust-tab[data-tab="home"]');
await homeTab.waitFor({ state: 'visible', timeout: 10000 });
await homeTab.click();
const heroInput = page.locator('#cust-heroTitle');
const heroInput = page.locator('[data-cv2-field="home.heroTitle"]');
if (await heroInput.count() === 0) {
console.log(' ⏭️ #cust-heroTitle not found — TODO: requires running server');
console.log(' ⏭️ home.heroTitle input not found — TODO: requires running server');
return;
}
await heroInput.waitFor({ state: 'visible', timeout: 10000 });
await heroInput.fill(editedHero);
await page.waitForTimeout(700); // autoSave debounce is 500ms
await page.waitForTimeout(700); // debounce is 300ms, allow margin
await page.reload({ waitUntil: 'domcontentloaded' });
const persistedHero = await page.evaluate(() => {
try {
const saved = JSON.parse(localStorage.getItem('meshcore-user-theme') || '{}');
const saved = JSON.parse(localStorage.getItem('cs-theme-overrides') || '{}');
return saved && saved.home ? saved.home.heroTitle : '';
} catch {
return '';
@@ -1015,6 +1015,397 @@ async function run() {
assert(hexDump, 'Hex dump should be visible after selecting a packet');
});
// --- Group: Customizer v2 E2E tests ---
await test('Customizer v2: setOverride persists and applies CSS', async () => {
await page.goto(BASE, { waitUntil: 'domcontentloaded' });
await page.waitForSelector('nav, .navbar, .nav, [class*="nav"]');
// Clear any existing overrides
await page.evaluate(() => localStorage.removeItem('cs-theme-overrides'));
// Set an override via the API
const result = await page.evaluate(() => {
if (!window._customizerV2) return { error: 'customizerV2 not loaded' };
window._customizerV2.setOverride('theme', 'accent', '#ff0000');
// Wait for debounce
return new Promise(resolve => setTimeout(() => {
const stored = JSON.parse(localStorage.getItem('cs-theme-overrides') || '{}');
const cssVal = getComputedStyle(document.documentElement).getPropertyValue('--accent').trim();
resolve({ stored, cssVal });
}, 500));
});
assert(!result.error, result.error || '');
assert(result.stored.theme && result.stored.theme.accent === '#ff0000',
'Override not persisted to localStorage');
assert(result.cssVal === '#ff0000',
`CSS variable --accent expected #ff0000 but got "${result.cssVal}"`);
// Cleanup
await page.evaluate(() => localStorage.removeItem('cs-theme-overrides'));
});
await test('Customizer v2: clearOverride resets to server default', async () => {
await page.goto(BASE, { waitUntil: 'domcontentloaded' });
await page.waitForSelector('nav, .navbar, .nav, [class*="nav"]');
const result = await page.evaluate(() => {
if (!window._customizerV2) return { error: 'customizerV2 not loaded' };
// Get the server default accent
window._customizerV2.setOverride('theme', 'accent', '#ff0000');
return new Promise(resolve => setTimeout(() => {
window._customizerV2.clearOverride('theme', 'accent');
const stored = JSON.parse(localStorage.getItem('cs-theme-overrides') || '{}');
const hasAccent = stored.theme && stored.theme.hasOwnProperty('accent');
resolve({ hasAccent });
}, 500));
});
assert(!result.error, result.error || '');
assert(!result.hasAccent, 'accent should be removed from overrides after clearOverride');
await page.evaluate(() => localStorage.removeItem('cs-theme-overrides'));
});
await test('Customizer v2: full reset clears all overrides', async () => {
await page.goto(BASE, { waitUntil: 'domcontentloaded' });
await page.waitForSelector('nav, .navbar, .nav, [class*="nav"]');
const result = await page.evaluate(() => {
if (!window._customizerV2) return { error: 'customizerV2 not loaded' };
localStorage.setItem('cs-theme-overrides', JSON.stringify({ theme: { accent: '#ff0000' }, nodeColors: { repeater: '#00ff00' } }));
// Simulate full reset
localStorage.removeItem('cs-theme-overrides');
const stored = localStorage.getItem('cs-theme-overrides');
return { stored };
});
assert(!result.error, result.error || '');
assert(result.stored === null, 'cs-theme-overrides should be null after full reset');
});
await test('Customizer v2: export produces valid JSON', async () => {
await page.goto(BASE, { waitUntil: 'domcontentloaded' });
await page.waitForSelector('nav, .navbar, .nav, [class*="nav"]');
const result = await page.evaluate(() => {
if (!window._customizerV2) return { error: 'customizerV2 not loaded' };
// Set some overrides
localStorage.setItem('cs-theme-overrides', JSON.stringify({ theme: { accent: '#123456' } }));
const delta = window._customizerV2.readOverrides();
const json = JSON.stringify(delta, null, 2);
try { JSON.parse(json); return { valid: true, hasAccent: delta.theme && delta.theme.accent === '#123456' }; }
catch { return { valid: false }; }
});
assert(!result.error, result.error || '');
assert(result.valid, 'Exported JSON must be valid');
assert(result.hasAccent, 'Exported JSON must contain the stored override');
await page.evaluate(() => localStorage.removeItem('cs-theme-overrides'));
});
await test('Customizer v2: import applies overrides', async () => {
await page.goto(BASE, { waitUntil: 'domcontentloaded' });
await page.waitForSelector('nav, .navbar, .nav, [class*="nav"]');
const result = await page.evaluate(() => {
if (!window._customizerV2) return { error: 'customizerV2 not loaded' };
localStorage.removeItem('cs-theme-overrides');
const importData = { theme: { accent: '#abcdef' }, nodeColors: { repeater: '#112233' } };
const validation = window._customizerV2.validateShape(importData);
if (!validation.valid) return { error: 'Validation failed: ' + validation.errors.join(', ') };
window._customizerV2.writeOverrides(importData);
const stored = window._customizerV2.readOverrides();
return { accent: stored.theme && stored.theme.accent, repeater: stored.nodeColors && stored.nodeColors.repeater };
});
assert(!result.error, result.error || '');
assert(result.accent === '#abcdef', 'Imported accent should be #abcdef');
assert(result.repeater === '#112233', 'Imported repeater should be #112233');
await page.evaluate(() => localStorage.removeItem('cs-theme-overrides'));
});
await test('Customizer v2: migration from legacy keys', async () => {
await page.goto(BASE, { waitUntil: 'domcontentloaded' });
await page.waitForSelector('nav, .navbar, .nav, [class*="nav"]');
const result = await page.evaluate(() => {
if (!window._customizerV2) return { error: 'customizerV2 not loaded' };
// Clear new key so migration can run
localStorage.removeItem('cs-theme-overrides');
// Set legacy keys
localStorage.setItem('meshcore-user-theme', JSON.stringify({ theme: { accent: '#aabb01' }, branding: { siteName: 'LegacyName' } }));
localStorage.setItem('meshcore-timestamp-mode', 'absolute');
localStorage.setItem('meshcore-heatmap-opacity', '0.5');
// Run migration
const migrated = window._customizerV2.migrateOldKeys();
const stored = window._customizerV2.readOverrides();
const legacyGone = localStorage.getItem('meshcore-user-theme') === null &&
localStorage.getItem('meshcore-timestamp-mode') === null &&
localStorage.getItem('meshcore-heatmap-opacity') === null;
return {
migrated: !!migrated,
accent: stored.theme && stored.theme.accent,
siteName: stored.branding && stored.branding.siteName,
tsMode: stored.timestamps && stored.timestamps.defaultMode,
opacity: stored.heatmapOpacity,
legacyGone
};
});
assert(!result.error, result.error || '');
assert(result.migrated, 'migrateOldKeys should return non-null');
assert(result.accent === '#aabb01', 'Theme accent should be migrated');
assert(result.siteName === 'LegacyName', 'Branding should be migrated');
assert(result.tsMode === 'absolute', 'Timestamp mode should be migrated');
assert(result.opacity === 0.5, 'Heatmap opacity should be migrated');
assert(result.legacyGone, 'Legacy keys should be removed after migration');
await page.evaluate(() => localStorage.removeItem('cs-theme-overrides'));
});
await test('Customizer v2: browser-local banner visible', async () => {
await page.goto(BASE, { waitUntil: 'domcontentloaded' });
await page.waitForSelector('nav, .navbar, .nav, [class*="nav"]');
// Open customizer
const toggleSel = '#customizeToggle, button[title*="ustom" i], [class*="customize"]';
const btn = await page.$(toggleSel);
if (!btn) { console.log(' ⏭️ Customizer toggle not found'); return; }
await btn.click();
await page.waitForSelector('.cv2-local-banner', { timeout: 5000 });
const bannerText = await page.$eval('.cv2-local-banner', el => el.textContent);
assert(bannerText.includes('browser only'), `Banner should mention "browser only" but got "${bannerText}"`);
});
await test('Customizer v2: auto-save status indicator', async () => {
// Panel should already be open from previous test
const statusEl = await page.$('#cv2-save-status');
if (!statusEl) { console.log(' ⏭️ Save status element not found'); return; }
const statusText = await page.$eval('#cv2-save-status', el => el.textContent);
assert(statusText.includes('saved') || statusText.includes('Saving'),
`Status should show save state but got "${statusText}"`);
});
await test('Customizer v2: override indicator appears and disappears', async () => {
// Set override BEFORE page load so _renderTheme sees it during init
await page.goto(BASE, { waitUntil: 'domcontentloaded' });
await page.evaluate(() => {
// Force light mode so theme tab renders 'theme' section (not 'themeDark')
localStorage.setItem('meshcore-theme', 'light');
localStorage.setItem('cs-theme-overrides', JSON.stringify({ theme: { accent: '#ff0000' } }));
});
// Reload so customizer v2 initializes with the override in place
await page.reload({ waitUntil: 'domcontentloaded' });
await page.waitForSelector('nav, .navbar, .nav, [class*="nav"]');
// Ensure light mode is active (CI headless may default to dark)
await page.evaluate(() => document.documentElement.setAttribute('data-theme', 'light'));
const result = await page.evaluate(() => {
if (!window._customizerV2) return { error: 'customizerV2 not loaded' };
return { ok: true };
});
assert(!result.error, result.error || '');
// Open customizer and check for override dot
const toggleSel = '#customizeToggle, button[title*="ustom" i], [class*="customize"]';
const btn = await page.$(toggleSel);
if (!btn) { console.log(' ⏭️ Customizer toggle not found'); return; }
await btn.click();
await page.waitForSelector('.cust-overlay', { timeout: 5000 });
// Click theme tab
const themeTab = await page.$('.cust-tab[data-tab="theme"]');
if (themeTab) await themeTab.click();
await page.waitForTimeout(200);
// Check for override dot
const dots = await page.$$('.cv2-override-dot');
assert(dots.length > 0, 'Override dot should be visible when overrides exist');
// Clear overrides and reload to verify dots disappear
await page.evaluate(() => localStorage.removeItem('cs-theme-overrides'));
await page.reload({ waitUntil: 'domcontentloaded' });
await page.waitForSelector('nav, .navbar, .nav, [class*="nav"]');
const btn2 = await page.$(toggleSel);
if (btn2) await btn2.click();
await page.waitForSelector('.cust-overlay', { timeout: 5000 });
const themeTab2 = await page.$('.cust-tab[data-tab="theme"]');
if (themeTab2) await themeTab2.click();
await page.waitForTimeout(200);
const dotsAfter = await page.$$('.cv2-override-dot');
assert(dotsAfter.length === 0, 'Override dots should disappear after clearing overrides');
});
await test('Customizer v2: presets apply through standard pipeline', async () => {
await page.goto(BASE, { waitUntil: 'domcontentloaded' });
await page.waitForSelector('nav, .navbar, .nav, [class*="nav"]');
await page.evaluate(() => localStorage.removeItem('cs-theme-overrides'));
const toggleSel = '#customizeToggle, button[title*="ustom" i], [class*="customize"]';
const btn = await page.$(toggleSel);
if (!btn) { console.log(' ⏭️ Customizer toggle not found'); return; }
await btn.click();
await page.waitForSelector('.cust-overlay', { timeout: 5000 });
// Click theme tab
const themeTab = await page.$('.cust-tab[data-tab="theme"]');
if (themeTab) await themeTab.click();
await page.waitForTimeout(200);
// Click ocean preset
const oceanBtn = await page.$('.cust-preset-btn[data-preset="ocean"]');
if (!oceanBtn) { console.log(' ⏭️ Ocean preset button not found'); return; }
await oceanBtn.click();
await page.waitForTimeout(300);
const result = await page.evaluate(() => {
const stored = JSON.parse(localStorage.getItem('cs-theme-overrides') || '{}');
const cssAccent = getComputedStyle(document.documentElement).getPropertyValue('--accent').trim();
return { hasTheme: !!stored.theme, cssAccent };
});
assert(result.hasTheme, 'Preset should write theme to localStorage');
assert(result.cssAccent.length > 0, 'CSS accent should be set after preset');
await page.evaluate(() => localStorage.removeItem('cs-theme-overrides'));
});
await test('Customizer v2: page load applies overrides from localStorage', async () => {
// Set overrides BEFORE navigating
await page.goto(BASE, { waitUntil: 'domcontentloaded' });
await page.evaluate(() => {
localStorage.setItem('cs-theme-overrides', JSON.stringify({ theme: { accent: '#ee1122' } }));
});
// Reload to trigger init with overrides
await page.reload({ waitUntil: 'domcontentloaded' });
await page.waitForSelector('nav, .navbar, .nav, [class*="nav"]');
await page.waitForTimeout(500); // allow pipeline to run
const cssAccent = await page.evaluate(() =>
getComputedStyle(document.documentElement).getPropertyValue('--accent').trim()
);
assert(cssAccent === '#ee1122', `Page load should apply override accent #ee1122 but got "${cssAccent}"`);
await page.evaluate(() => localStorage.removeItem('cs-theme-overrides'));
});
// --- Group: Show Neighbors (#484 fix) ---
await test('Show Neighbors populates neighborPubkeys from affinity API', async () => {
const testPubkey = 'aabbccdd11223344556677889900aabbccddeeff00112233445566778899001122';
const neighborPubkey1 = '1111111111111111111111111111111111111111111111111111111111111111';
const neighborPubkey2 = '2222222222222222222222222222222222222222222222222222222222222222';
await page.route(`**/api/nodes/${testPubkey}/neighbors*`, route => {
route.fulfill({
status: 200,
contentType: 'application/json',
body: JSON.stringify({
node: testPubkey,
neighbors: [
{ pubkey: neighborPubkey1, prefix: '11', name: 'Neighbor-1', role: 'repeater', count: 50, score: 0.9, ambiguous: false },
{ pubkey: neighborPubkey2, prefix: '22', name: 'Neighbor-2', role: 'companion', count: 20, score: 0.7, ambiguous: false }
],
total_observations: 70
})
});
});
await page.goto(`${BASE}/#/map`, { waitUntil: 'domcontentloaded' });
await page.waitForTimeout(1500);
const result = await page.evaluate(async (args) => {
if (typeof window._mapSelectRefNode !== 'function') return { error: 'no _mapSelectRefNode' };
await window._mapSelectRefNode(args.pk, 'TestNode');
return { neighbors: window._mapGetNeighborPubkeys() };
}, { pk: testPubkey });
assert(!result.error, result.error || '');
assert(result.neighbors.includes(neighborPubkey1), 'Should contain neighbor1');
assert(result.neighbors.includes(neighborPubkey2), 'Should contain neighbor2');
assert(result.neighbors.length === 2, `Expected 2 neighbors, got ${result.neighbors.length}`);
await page.unroute(`**/api/nodes/${testPubkey}/neighbors*`);
});
await test('Show Neighbors resolves correct node on hash collision via affinity API', async () => {
const nodeA = 'c0dedad4208acb6cbe44b848943fc6d3c5d43cf38a21e48b43826a70862980e4';
const nodeB = 'c0f1a2b3000000000000000000000000000000000000000000000000000000ff';
const neighborR1 = 'r1aaaaaa000000000000000000000000000000000000000000000000000000aa';
const neighborR2 = 'r2bbbbbb000000000000000000000000000000000000000000000000000000bb';
const neighborR4 = 'r4dddddd000000000000000000000000000000000000000000000000000000dd';
await page.route(`**/api/nodes/${nodeA}/neighbors*`, route => {
route.fulfill({
status: 200,
contentType: 'application/json',
body: JSON.stringify({
node: nodeA,
neighbors: [
{ pubkey: neighborR1, prefix: 'R1', name: 'Repeater-R1', role: 'repeater', count: 100, score: 0.95, ambiguous: false },
{ pubkey: neighborR2, prefix: 'R2', name: 'Repeater-R2', role: 'repeater', count: 80, score: 0.85, ambiguous: false }
],
total_observations: 180
})
});
});
await page.route(`**/api/nodes/${nodeB}/neighbors*`, route => {
route.fulfill({
status: 200,
contentType: 'application/json',
body: JSON.stringify({
node: nodeB,
neighbors: [
{ pubkey: neighborR4, prefix: 'R4', name: 'Repeater-R4', role: 'repeater', count: 60, score: 0.75, ambiguous: false }
],
total_observations: 60
})
});
});
await page.goto(`${BASE}/#/map`, { waitUntil: 'domcontentloaded' });
await page.waitForTimeout(1500);
// Select Node A — should get R1, R2 but NOT R4
const resultA = await page.evaluate(async (pk) => {
await window._mapSelectRefNode(pk, 'NodeA');
return window._mapGetNeighborPubkeys();
}, nodeA);
assert(resultA.includes(neighborR1), 'Node A should have R1');
assert(resultA.includes(neighborR2), 'Node A should have R2');
assert(!resultA.includes(neighborR4), 'Node A should NOT have R4');
// Select Node B — should get R4 but NOT R1, R2
const resultB = await page.evaluate(async (pk) => {
await window._mapSelectRefNode(pk, 'NodeB');
return window._mapGetNeighborPubkeys();
}, nodeB);
assert(resultB.includes(neighborR4), 'Node B should have R4');
assert(!resultB.includes(neighborR1), 'Node B should NOT have R1');
assert(!resultB.includes(neighborR2), 'Node B should NOT have R2');
await page.unroute(`**/api/nodes/${nodeA}/neighbors*`);
await page.unroute(`**/api/nodes/${nodeB}/neighbors*`);
});
await test('Show Neighbors falls back to path walking when affinity API returns empty', async () => {
const testPubkey = 'fallbacktest0000000000000000000000000000000000000000000000000000';
const hopBefore = 'aaaa000000000000000000000000000000000000000000000000000000000000';
const hopAfter = 'bbbb000000000000000000000000000000000000000000000000000000000000';
await page.route(`**/api/nodes/${testPubkey}/neighbors*`, route => {
route.fulfill({
status: 200,
contentType: 'application/json',
body: JSON.stringify({ node: testPubkey, neighbors: [], total_observations: 0 })
});
});
await page.route(`**/api/nodes/${testPubkey}/paths*`, route => {
route.fulfill({
status: 200,
contentType: 'application/json',
body: JSON.stringify({
paths: [{
hops: [
{ pubkey: hopBefore, name: 'HopBefore' },
{ pubkey: testPubkey, name: 'Self' },
{ pubkey: hopAfter, name: 'HopAfter' }
]
}]
})
});
});
await page.goto(`${BASE}/#/map`, { waitUntil: 'domcontentloaded' });
await page.waitForTimeout(1500);
const result = await page.evaluate(async (pk) => {
if (typeof window._mapSelectRefNode !== 'function') return { error: 'no-function' };
await window._mapSelectRefNode(pk, 'FallbackNode');
return { neighbors: window._mapGetNeighborPubkeys() };
}, testPubkey);
assert(!result.error, result.error || '');
assert(result.neighbors.includes(hopBefore), 'Fallback should find hopBefore');
assert(result.neighbors.includes(hopAfter), 'Fallback should find hopAfter');
assert(result.neighbors.length === 2, `Expected 2 fallback neighbors, got ${result.neighbors.length}`);
await page.unroute(`**/api/nodes/${testPubkey}/neighbors*`);
await page.unroute(`**/api/nodes/${testPubkey}/paths*`);
});
// Extract frontend coverage if instrumented server is running
try {
const coverage = await page.evaluate(() => window.__coverage__);
+71 -262
View File
@@ -1942,263 +1942,105 @@ console.log('\n=== analytics.js: sortChannels ===');
}
// ===== CUSTOMIZE.JS: initState merge behavior =====
console.log('\n=== customize.js: initState merge behavior ===');
// ===== CUSTOMIZE-V2.JS: core behavior =====
console.log('\n=== customize-v2.js: core behavior ===');
{
function loadCustomizeExports(ctx) {
const src = fs.readFileSync('public/customize.js', 'utf8');
const withExports = src.replace(
/\}\)\(\);\s*$/,
'window.__customizeExport = { initState: initState, autoSave: autoSave, getState: function () { return state; }, getDefaults: function () { return deepClone(DEFAULTS); }, setInitialized: function (v) { _initialized = !!v; } };})();'
);
vm.runInContext(withExports, ctx);
function loadCustomizeV2(ctx) {
const src = fs.readFileSync('public/customize-v2.js', 'utf8');
vm.runInContext(src, ctx);
for (const k of Object.keys(ctx.window)) ctx[k] = ctx.window[k];
return ctx.window.__customizeExport;
return ctx.window._customizerV2;
}
test('autoSave no-ops before initialization on panel open path', () => {
test('readOverrides returns empty object when no localStorage data', () => {
const ctx = makeSandbox();
let saveTimerCalls = 0;
ctx.setTimeout = function () { saveTimerCalls++; return 1; };
ctx.clearTimeout = function () {};
ctx.window.SITE_CONFIG = { home: { heroTitle: 'Server Hero' } };
const ex = loadCustomizeExports(ctx);
ex.initState();
ex.setInitialized(false);
ex.autoSave();
assert.strictEqual(saveTimerCalls, 0);
assert.strictEqual(ctx.localStorage.getItem('meshcore-user-theme'), null);
ctx.CustomEvent = function (type) { this.type = type; };
const v2 = loadCustomizeV2(ctx);
const overrides = v2.readOverrides();
assert.strictEqual(Object.keys(overrides).length, 0);
});
test('server home config survives customizer open without modification', () => {
test('writeOverrides + readOverrides roundtrip', () => {
const ctx = makeSandbox();
let saveTimerCalls = 0;
ctx.setTimeout = function () { saveTimerCalls++; return 1; };
ctx.clearTimeout = function () {};
ctx.window.SITE_CONFIG = {
home: {
heroTitle: 'Server Hero',
heroSubtitle: 'Server Subtitle',
steps: [{ emoji: 'S', title: 'Server Step', description: 'server' }],
checklist: [{ question: 'Server Q', answer: 'Server A' }],
footerLinks: [{ label: 'Server Link', url: '#/server' }]
}
};
const before = JSON.stringify(ctx.window.SITE_CONFIG.home);
const ex = loadCustomizeExports(ctx);
ex.initState();
ex.setInitialized(false);
ex.autoSave();
assert.strictEqual(saveTimerCalls, 0);
assert.strictEqual(JSON.stringify(ctx.window.SITE_CONFIG.home), before);
ctx.CustomEvent = function (type) { this.type = type; };
const v2 = loadCustomizeV2(ctx);
v2.writeOverrides({ theme: { accent: '#ff0000' } });
const result = v2.readOverrides();
assert.strictEqual(result.theme.accent, '#ff0000');
});
test('post-init autoSave exports user theme without mutating SITE_CONFIG.home', () => {
test('computeEffective merges server defaults with overrides', () => {
const ctx = makeSandbox();
let saveTimerCalls = 0;
ctx.setTimeout = function (fn) { saveTimerCalls++; fn(); return 1; };
ctx.clearTimeout = function () {};
ctx.HashChangeEvent = function HashChangeEvent(type) { this.type = type; };
ctx.window.SITE_CONFIG = {
home: {
heroTitle: 'Server Hero',
heroSubtitle: 'Server Subtitle',
steps: [{ emoji: 'S', title: 'Server Step', description: 'server' }],
checklist: [{ question: 'Server Q', answer: 'Server A' }],
footerLinks: [{ label: 'Server Link', url: '#/server' }]
}
};
const before = JSON.stringify(ctx.window.SITE_CONFIG.home);
const ex = loadCustomizeExports(ctx);
ex.initState();
ex.setInitialized(true);
ex.autoSave();
const saved = ctx.localStorage.getItem('meshcore-user-theme');
assert.strictEqual(saveTimerCalls, 1);
assert(saved && saved.length > 0, 'Expected autoSave to persist user theme');
assert.strictEqual(JSON.stringify(ctx.window.SITE_CONFIG.home), before);
ctx.CustomEvent = function (type) { this.type = type; };
const v2 = loadCustomizeV2(ctx);
const server = { theme: { accent: '#111111', navBg: '#222222' } };
const overrides = { theme: { accent: '#ff0000' } };
const effective = v2.computeEffective(server, overrides);
assert.strictEqual(effective.theme.accent, '#ff0000');
assert.strictEqual(effective.theme.navBg, '#222222');
});
test('partial local checklist does not wipe steps/footerLinks and keeps server colors', () => {
test('isValidColor accepts hex, rgb, hsl, and named colors', () => {
const ctx = makeSandbox();
ctx.window.SITE_CONFIG = {
home: {
heroTitle: 'Server Hero',
heroSubtitle: 'Server Subtitle',
steps: [{ emoji: '🧪', title: 'Server Step', description: 'from server' }],
checklist: [{ question: 'Server Q', answer: 'Server A' }],
footerLinks: [{ label: 'Server Link', url: '#/server' }]
},
theme: { accent: '#123456', navBg: '#222222' },
nodeColors: { repeater: '#aa0000' }
};
ctx.localStorage.setItem('meshcore-user-theme', JSON.stringify({
home: { checklist: [{ question: 'Local Q', answer: 'Local A' }] }
}));
const ex = loadCustomizeExports(ctx);
ex.initState();
const state = ex.getState();
assert.strictEqual(state.home.checklist[0].question, 'Local Q');
assert.strictEqual(state.home.steps[0].title, 'Server Step');
assert.strictEqual(state.home.footerLinks[0].label, 'Server Link');
assert.strictEqual(state.home.heroTitle, 'Server Hero');
assert.strictEqual(state.theme.accent, '#123456');
assert.strictEqual(state.nodeColors.repeater, '#aa0000');
ctx.CustomEvent = function (type) { this.type = type; };
const v2 = loadCustomizeV2(ctx);
assert.strictEqual(v2.isValidColor('#ff0000'), true);
assert.strictEqual(v2.isValidColor('#abc'), true);
assert.strictEqual(v2.isValidColor('rgb(255, 0, 0)'), true);
assert.strictEqual(v2.isValidColor('hsl(0, 100%, 50%)'), true);
assert.strictEqual(v2.isValidColor('red'), true);
assert.strictEqual(v2.isValidColor('notacolor'), false);
assert.strictEqual(v2.isValidColor(123), false);
});
test('server values survive when localStorage has partial overrides', () => {
test('validateShape reports invalid color values', () => {
const ctx = makeSandbox();
ctx.window.SITE_CONFIG = {
home: {
heroTitle: 'Server Hero',
heroSubtitle: 'Server Subtitle',
steps: [{ emoji: '1️⃣', title: 'Server Step', description: 'server' }],
footerLinks: [{ label: 'Server Footer', url: '#/s' }]
},
theme: { accent: '#111111', navBg: '#222222', navText: '#333333' },
typeColors: { ADVERT: '#00aa00', REQUEST: '#aa00aa' }
};
ctx.localStorage.setItem('meshcore-user-theme', JSON.stringify({
home: { heroTitle: 'Local Hero' },
theme: { accent: '#999999' },
typeColors: { ADVERT: '#ff00ff' }
}));
const ex = loadCustomizeExports(ctx);
ex.initState();
const state = ex.getState();
assert.strictEqual(state.home.heroTitle, 'Local Hero');
assert.strictEqual(state.home.heroSubtitle, 'Server Subtitle');
assert.strictEqual(state.home.steps[0].title, 'Server Step');
assert.strictEqual(state.home.footerLinks[0].label, 'Server Footer');
assert.strictEqual(state.theme.accent, '#999999');
assert.strictEqual(state.theme.navBg, '#222222');
assert.strictEqual(state.typeColors.ADVERT, '#ff00ff');
assert.strictEqual(state.typeColors.REQUEST, '#aa00aa');
ctx.CustomEvent = function (type) { this.type = type; };
const v2 = loadCustomizeV2(ctx);
const valid = v2.validateShape({ theme: { accent: '#ff0000', navBg: '#222222' } });
assert.strictEqual(valid.valid, true);
const invalid = v2.validateShape({ theme: { accent: '#ff0000', navBg: 'not-a-color' } });
assert.ok(invalid.errors.length > 0, 'should report invalid color');
assert.ok(invalid.errors[0].includes('navBg'), 'error should mention navBg');
});
test('full localStorage values override server config', () => {
test('migrateOldKeys reads legacy localStorage keys', () => {
const ctx = makeSandbox();
ctx.window.SITE_CONFIG = {
home: {
heroTitle: 'Server Hero',
heroSubtitle: 'Server Subtitle',
steps: [{ emoji: 'S', title: 'Server Step', description: 'server' }],
checklist: [{ question: 'Server Q', answer: 'Server A' }],
footerLinks: [{ label: 'Server Link', url: '#/server' }]
},
theme: { accent: '#101010' }
};
ctx.localStorage.setItem('meshcore-user-theme', JSON.stringify({
home: {
heroTitle: 'Local Hero',
heroSubtitle: 'Local Subtitle',
steps: [{ emoji: 'L', title: 'Local Step', description: 'local' }],
checklist: [{ question: 'Local Q', answer: 'Local A' }],
footerLinks: [{ label: 'Local Link', url: '#/local' }]
},
theme: { accent: '#abcdef', navBg: '#fedcba' }
}));
const ex = loadCustomizeExports(ctx);
ex.initState();
const state = ex.getState();
assert.strictEqual(state.home.heroTitle, 'Local Hero');
assert.strictEqual(state.home.heroSubtitle, 'Local Subtitle');
assert.strictEqual(state.home.steps[0].title, 'Local Step');
assert.strictEqual(state.home.checklist[0].question, 'Local Q');
assert.strictEqual(state.home.footerLinks[0].label, 'Local Link');
assert.strictEqual(state.theme.accent, '#abcdef');
assert.strictEqual(state.theme.navBg, '#fedcba');
ctx.CustomEvent = function (type) { this.type = type; };
ctx.localStorage.setItem('meshcore-theme', 'dark');
const v2 = loadCustomizeV2(ctx);
// migrateOldKeys should handle legacy keys without crashing
v2.migrateOldKeys();
});
test('initState uses _SITE_CONFIG_ORIGINAL_HOME to bypass contaminated SITE_CONFIG.home', () => {
// Simulates: app.js called mergeUserHomeConfig which mutated SITE_CONFIG.home.steps = []
// The original server steps must still be recoverable via _SITE_CONFIG_ORIGINAL_HOME
test('THEME_CSS_MAP includes surface3 and sectionBg', () => {
const ctx = makeSandbox();
ctx.setTimeout = function (fn) { fn(); return 1; };
ctx.clearTimeout = function () {};
// SITE_CONFIG.home is contaminated — steps wiped by mergeUserHomeConfig at page load
ctx.window.SITE_CONFIG = {
home: {
heroTitle: 'Server Hero',
steps: [] // contaminated — user had steps:[] in localStorage at page load
}
};
// app.js snapshots original before mutation
ctx.window._SITE_CONFIG_ORIGINAL_HOME = {
heroTitle: 'Server Hero',
steps: [{ emoji: '🧪', title: 'Original Step', description: 'from server' }]
};
const ex = loadCustomizeExports(ctx);
ex.initState();
const state = ex.getState();
assert.strictEqual(state.home.steps.length, 1, 'should restore from snapshot, not contaminated SITE_CONFIG');
assert.strictEqual(state.home.steps[0].title, 'Original Step');
ctx.CustomEvent = function (type) { this.type = type; };
const src = fs.readFileSync('public/customize-v2.js', 'utf8');
assert.ok(src.includes("surface3: '--surface-3'"), 'surface3 must map to --surface-3');
assert.ok(src.includes("sectionBg: '--section-bg'"), 'sectionBg must map to --section-bg');
});
test('initState uses DEFAULTS.home when no SITE_CONFIG and no snapshot', () => {
test('_renderNodes falls back to window.TYPE_COLORS when typeColors is empty (#514)', () => {
const ctx = makeSandbox();
ctx.setTimeout = function (fn) { fn(); return 1; };
ctx.clearTimeout = function () {};
// No SITE_CONFIG at all — pure DEFAULTS
const ex = loadCustomizeExports(ctx);
ex.initState();
const state = ex.getState();
assert.ok(state.home.steps.length > 0, 'should use DEFAULTS.home.steps when no server config');
assert.strictEqual(state.home.steps[0].title, 'Join the Bay Area MeshCore Discord');
ctx.CustomEvent = function (type) { this.type = type; };
ctx.TYPE_COLORS = { ADVERT: '#22c55e', GRP_TXT: '#3b82f6' };
ctx.window.TYPE_COLORS = ctx.TYPE_COLORS;
const v2 = loadCustomizeV2(ctx);
// computeEffective with empty typeColors should still allow fallback
const server = { typeColors: {} };
const effective = v2.computeEffective(server, {});
// When typeColors is empty, the render should fall back to TYPE_COLORS
// We test the logic directly: tc[key] || TYPE_COLORS[key] || '#000000'
const tc = effective.typeColors || {};
const advertColor = tc['ADVERT'] || (ctx.window.TYPE_COLORS && ctx.window.TYPE_COLORS['ADVERT']) || '#000000';
assert.strictEqual(advertColor, '#22c55e', 'ADVERT should fall back to TYPE_COLORS, not #000000');
const grpColor = tc['GRP_TXT'] || (ctx.window.TYPE_COLORS && ctx.window.TYPE_COLORS['GRP_TXT']) || '#000000';
assert.strictEqual(grpColor, '#3b82f6', 'GRP_TXT should fall back to TYPE_COLORS, not #000000');
});
}
// ===== APP.JS: home rehydration merge =====
console.log('\n=== app.js: home rehydration merge ===');
{
test('mergeUserHomeConfig layers local home overrides on server home', () => {
const ctx = makeSandbox();
loadInCtx(ctx, 'public/roles.js');
loadInCtx(ctx, 'public/app.js');
const merged = ctx.mergeUserHomeConfig(
{
home: {
heroTitle: 'Server Hero',
heroSubtitle: 'Server Subtitle',
steps: [{ title: 'Server Step' }],
footerLinks: [{ label: 'Server Link' }]
}
},
{
home: {
heroSubtitle: 'Local Subtitle',
checklist: [{ question: 'Local Q', answer: 'Local A' }]
}
}
);
assert.strictEqual(merged.home.heroTitle, 'Server Hero');
assert.strictEqual(merged.home.heroSubtitle, 'Local Subtitle');
assert.strictEqual(merged.home.steps[0].title, 'Server Step');
assert.strictEqual(merged.home.footerLinks[0].label, 'Server Link');
assert.strictEqual(merged.home.checklist[0].question, 'Local Q');
});
test('mergeUserHomeConfig handles refresh-style localStorage payload', () => {
const ctx = makeSandbox();
loadInCtx(ctx, 'public/roles.js');
loadInCtx(ctx, 'public/app.js');
ctx.localStorage.setItem('meshcore-user-theme', JSON.stringify({
home: { heroTitle: 'Local Hero' }
}));
const cfg = {
home: {
heroTitle: 'Server Hero',
heroSubtitle: 'Server Subtitle',
steps: [{ title: 'Server Step' }]
}
};
const userTheme = JSON.parse(ctx.localStorage.getItem('meshcore-user-theme') || '{}');
const merged = ctx.mergeUserHomeConfig(cfg, userTheme);
assert.strictEqual(merged.home.heroTitle, 'Local Hero');
assert.strictEqual(merged.home.heroSubtitle, 'Server Subtitle');
assert.strictEqual(merged.home.steps[0].title, 'Server Step');
});
}
// ===== APP.JS: home rehydration merge (mergeUserHomeConfig removed — dead code) =====
// ===== CHANNELS.JS: WS Region Filter helper =====
console.log('\n=== channels.js: shouldProcessWSMessageForRegion ===');
@@ -4098,40 +3940,7 @@ console.log('\n=== app.js: debounce ===');
});
}
// ===== APP.JS: mergeUserHomeConfig edge cases =====
console.log('\n=== app.js: mergeUserHomeConfig edge cases ===');
{
const ctx = makeSandbox();
loadInCtx(ctx, 'public/roles.js');
loadInCtx(ctx, 'public/app.js');
const merge = ctx.mergeUserHomeConfig;
test('returns siteConfig when userTheme is null', () => {
const cfg = { home: { heroTitle: 'Test' } };
assert.strictEqual(merge(cfg, null), cfg);
});
test('returns siteConfig when userTheme has no home', () => {
const cfg = { home: { heroTitle: 'Test' } };
assert.strictEqual(merge(cfg, { theme: {} }), cfg);
});
test('returns siteConfig when siteConfig is null', () => {
assert.strictEqual(merge(null, { home: { heroTitle: 'X' } }), null);
});
test('creates home on siteConfig when missing', () => {
const cfg = {};
merge(cfg, { home: { heroTitle: 'New' } });
assert.strictEqual(cfg.home.heroTitle, 'New');
});
test('userTheme.home non-object is ignored', () => {
const cfg = { home: { heroTitle: 'Test' } };
assert.strictEqual(merge(cfg, { home: 'string' }), cfg);
assert.strictEqual(cfg.home.heroTitle, 'Test');
});
}
// ===== APP.JS: mergeUserHomeConfig removed (dead code) =====
// ===== APP.JS: formatAbsoluteTimestamp with custom format =====
console.log('\n=== app.js: formatAbsoluteTimestamp (custom format) ===');
+51 -1
View File
@@ -75,4 +75,54 @@ test('no setInterval remains in animation hot path', () => {
});
console.log(`\n${passed} passed, ${failed} failed\n`);
process.exit(failed > 0 ? 1 : 0);
if (failed > 0) process.exit(1);
/* === Null-guard coverage for rAF callbacks === */
const src2 = fs.readFileSync('public/live.js', 'utf8');
let p2 = 0, f2 = 0;
function test2(name, fn) {
try { fn(); p2++; console.log(`${name}`); }
catch (e) { f2++; console.log(`${name}: ${e.message}`); }
}
console.log('\n=== Null guards on rAF animation callbacks ===');
test2('animatePath tick() has null guard', () => {
// tick is inside animatePath, after "function tick(now)"
const tickStart = src2.indexOf('function tick(now)');
const tickBody = src2.substring(tickStart, tickStart + 200);
assert.ok(tickBody.includes('!animLayer || !pathsLayer'), 'tick() missing animLayer/pathsLayer null guard');
});
test2('animatePath fadeOut() has null guard', () => {
const fadeOutStart = src2.indexOf('function fadeOut(now)');
const fadeOutBody = src2.substring(fadeOutStart, fadeOutStart + 200);
assert.ok(fadeOutBody.includes('!animLayer || !pathsLayer'), 'fadeOut() missing animLayer/pathsLayer null guard');
});
test2('drawAnimatedLine animateLine() has null guard', () => {
const lineStart = src2.indexOf('function animateLine(now)');
const lineBody = src2.substring(lineStart, lineStart + 200);
assert.ok(lineBody.includes('!animLayer || !pathsLayer'), 'animateLine() missing animLayer/pathsLayer null guard');
});
test2('drawAnimatedLine animateFade() has null guard', () => {
const fadeStart = src2.indexOf('function animateFade(now)');
const fadeBody = src2.substring(fadeStart, fadeStart + 200);
assert.ok(fadeBody.includes('!pathsLayer'), 'animateFade() missing pathsLayer null guard');
});
test2('pulseNode animatePulse() has null guard', () => {
const pulseStart = src2.indexOf('function animatePulse(now)');
const pulseBody = src2.substring(pulseStart, pulseStart + 200);
assert.ok(pulseBody.includes('!animLayer'), 'animatePulse() missing animLayer null guard');
});
test2('ghostPulse has null guard', () => {
const ghostStart = src2.indexOf('function ghostPulse(now)');
const ghostBody = src2.substring(ghostStart, ghostStart + 200);
assert.ok(ghostBody.includes('!animLayer'), 'ghostPulse() missing animLayer null guard');
});
console.log(`\n${p2} passed, ${f2} failed\n`);
if (f2 > 0) process.exit(1);
+242
View File
@@ -0,0 +1,242 @@
/**
* Show Neighbors E2E tests (#484 fix)
* Tests that selectReferenceNode() uses the affinity API instead of client-side path walking.
* Usage: CHROMIUM_PATH=/usr/bin/chromium-browser BASE_URL=http://localhost:13590 node test-show-neighbors.js
*/
const { chromium } = require('playwright');
const BASE = process.env.BASE_URL || 'http://localhost:3000';
const results = [];
async function test(name, fn) {
try {
await fn();
results.push({ name, pass: true });
console.log(`${name}`);
} catch (err) {
results.push({ name, pass: false, error: err.message });
console.log(`${name}: ${err.message}`);
}
}
function assert(condition, msg) {
if (!condition) throw new Error(msg || 'Assertion failed');
}
async function run() {
console.log('Launching Chromium...');
const launchOpts = { headless: true, args: ['--no-sandbox', '--disable-gpu'] };
if (process.env.CHROMIUM_PATH) launchOpts.executablePath = process.env.CHROMIUM_PATH;
const browser = await chromium.launch(launchOpts);
const page = await browser.newPage();
console.log(`\nRunning Show Neighbors tests against ${BASE}\n`);
await test('Show Neighbors calls affinity API and populates neighborPubkeys', async () => {
const testPubkey = 'aabbccdd11223344556677889900aabbccddeeff00112233445566778899001122';
const neighborPubkey1 = '1111111111111111111111111111111111111111111111111111111111111111';
const neighborPubkey2 = '2222222222222222222222222222222222222222222222222222222222222222';
let apiCalled = false;
await page.route(`**/api/nodes/${testPubkey}/neighbors*`, route => {
apiCalled = true;
route.fulfill({
status: 200,
contentType: 'application/json',
body: JSON.stringify({
node: testPubkey,
neighbors: [
{ pubkey: neighborPubkey1, prefix: '11', name: 'Neighbor-1', role: 'repeater', count: 50, score: 0.9, ambiguous: false },
{ pubkey: neighborPubkey2, prefix: '22', name: 'Neighbor-2', role: 'companion', count: 20, score: 0.7, ambiguous: false }
],
total_observations: 70
})
});
});
await page.goto(`${BASE}/#/map`, { waitUntil: 'domcontentloaded' });
await page.waitForTimeout(2000);
const result = await page.evaluate(async (args) => {
if (typeof window._mapSelectRefNode !== 'function') return { error: 'no _mapSelectRefNode function' };
if (typeof window._mapGetNeighborPubkeys !== 'function') return { error: 'no _mapGetNeighborPubkeys function' };
await window._mapSelectRefNode(args.pk, 'TestNode');
return { neighbors: window._mapGetNeighborPubkeys() };
}, { pk: testPubkey });
assert(!result.error, result.error || '');
assert(apiCalled, 'The /neighbors API should have been called');
assert(result.neighbors.includes(neighborPubkey1), `Should contain neighbor1, got: ${JSON.stringify(result.neighbors)}`);
assert(result.neighbors.includes(neighborPubkey2), `Should contain neighbor2, got: ${JSON.stringify(result.neighbors)}`);
assert(result.neighbors.length === 2, `Should have exactly 2 neighbors, got ${result.neighbors.length}`);
await page.unroute(`**/api/nodes/${testPubkey}/neighbors*`);
});
await test('Show Neighbors resolves correct node on hash collision via affinity API', async () => {
const nodeA = 'c0dedad4208acb6cbe44b848943fc6d3c5d43cf38a21e48b43826a70862980e4';
const nodeB = 'c0f1a2b3000000000000000000000000000000000000000000000000000000ff';
const neighborR1 = 'r1aaaaaa000000000000000000000000000000000000000000000000000000aa';
const neighborR2 = 'r2bbbbbb000000000000000000000000000000000000000000000000000000bb';
const neighborR4 = 'r4dddddd000000000000000000000000000000000000000000000000000000dd';
await page.route(`**/api/nodes/${nodeA}/neighbors*`, route => {
route.fulfill({
status: 200,
contentType: 'application/json',
body: JSON.stringify({
node: nodeA,
neighbors: [
{ pubkey: neighborR1, prefix: 'R1', name: 'Repeater-R1', role: 'repeater', count: 100, score: 0.95, ambiguous: false },
{ pubkey: neighborR2, prefix: 'R2', name: 'Repeater-R2', role: 'repeater', count: 80, score: 0.85, ambiguous: false }
],
total_observations: 180
})
});
});
await page.route(`**/api/nodes/${nodeB}/neighbors*`, route => {
route.fulfill({
status: 200,
contentType: 'application/json',
body: JSON.stringify({
node: nodeB,
neighbors: [
{ pubkey: neighborR4, prefix: 'R4', name: 'Repeater-R4', role: 'repeater', count: 60, score: 0.75, ambiguous: false }
],
total_observations: 60
})
});
});
await page.goto(`${BASE}/#/map`, { waitUntil: 'domcontentloaded' });
await page.waitForTimeout(2000);
// Select Node A — should get R1, R2 but NOT R4
const resultA = await page.evaluate(async (pk) => {
await window._mapSelectRefNode(pk, 'NodeA');
return window._mapGetNeighborPubkeys();
}, nodeA);
assert(resultA.includes(neighborR1), 'Node A should have R1 as neighbor');
assert(resultA.includes(neighborR2), 'Node A should have R2 as neighbor');
assert(!resultA.includes(neighborR4), 'Node A should NOT have R4 (that belongs to Node B)');
// Select Node B — should get R4 but NOT R1, R2
const resultB = await page.evaluate(async (pk) => {
await window._mapSelectRefNode(pk, 'NodeB');
return window._mapGetNeighborPubkeys();
}, nodeB);
assert(resultB.includes(neighborR4), 'Node B should have R4 as neighbor');
assert(!resultB.includes(neighborR1), 'Node B should NOT have R1 (that belongs to Node A)');
assert(!resultB.includes(neighborR2), 'Node B should NOT have R2 (that belongs to Node A)');
await page.unroute(`**/api/nodes/${nodeA}/neighbors*`);
await page.unroute(`**/api/nodes/${nodeB}/neighbors*`);
});
await test('Show Neighbors falls back to path walking when affinity API returns empty', async () => {
const testPubkey = 'fallbacktest0000000000000000000000000000000000000000000000000000';
const hopBefore = 'aaaa000000000000000000000000000000000000000000000000000000000000';
const hopAfter = 'bbbb000000000000000000000000000000000000000000000000000000000000';
let neighborApiCalled = false;
let pathsApiCalled = false;
await page.route(`**/api/nodes/${testPubkey}/neighbors*`, route => {
neighborApiCalled = true;
route.fulfill({
status: 200,
contentType: 'application/json',
body: JSON.stringify({ node: testPubkey, neighbors: [], total_observations: 0 })
});
});
await page.route(`**/api/nodes/${testPubkey}/paths*`, route => {
pathsApiCalled = true;
route.fulfill({
status: 200,
contentType: 'application/json',
body: JSON.stringify({
paths: [{
hops: [
{ pubkey: hopBefore, name: 'HopBefore' },
{ pubkey: testPubkey, name: 'Self' },
{ pubkey: hopAfter, name: 'HopAfter' }
]
}]
})
});
});
await page.goto(`${BASE}/#/map`, { waitUntil: 'domcontentloaded' });
await page.waitForTimeout(2000);
const result = await page.evaluate(async (pk) => {
if (typeof window._mapSelectRefNode !== 'function') return { error: 'no-function' };
await window._mapSelectRefNode(pk, 'FallbackNode');
return { neighbors: window._mapGetNeighborPubkeys() };
}, testPubkey);
assert(!result.error, result.error || '');
assert(neighborApiCalled, 'Should try neighbor API first');
assert(pathsApiCalled, 'Should fall back to paths API when neighbors empty');
assert(result.neighbors.includes(hopBefore), 'Fallback should find hopBefore as neighbor');
assert(result.neighbors.includes(hopAfter), 'Fallback should find hopAfter as neighbor');
assert(result.neighbors.length === 2, `Fallback should find exactly 2 neighbors, got ${result.neighbors.length}`);
await page.unroute(`**/api/nodes/${testPubkey}/neighbors*`);
await page.unroute(`**/api/nodes/${testPubkey}/paths*`);
});
await test('Show Neighbors includes ambiguous candidates in neighborPubkeys', async () => {
const testPubkey = 'ambigtest000000000000000000000000000000000000000000000000000000';
const candidate1 = 'a3b4c500000000000000000000000000000000000000000000000000000000';
const candidate2 = 'a3f0e100000000000000000000000000000000000000000000000000000000';
const knownNeighbor = 'b7e8f9a000000000000000000000000000000000000000000000000000000000';
await page.route(`**/api/nodes/${testPubkey}/neighbors*`, route => {
route.fulfill({
status: 200,
contentType: 'application/json',
body: JSON.stringify({
node: testPubkey,
neighbors: [
{ pubkey: knownNeighbor, prefix: 'B7', name: 'Known-Neighbor', role: 'repeater', count: 100, score: 0.95, ambiguous: false },
{ pubkey: null, prefix: 'A3', name: null, role: null, count: 12, score: 0.08, ambiguous: true,
candidates: [
{ pubkey: candidate1, name: 'Node-Alpha', role: 'companion' },
{ pubkey: candidate2, name: 'Node-Beta', role: 'companion' }
]
}
],
total_observations: 112
})
});
});
await page.goto(`${BASE}/#/map`, { waitUntil: 'domcontentloaded' });
await page.waitForTimeout(2000);
const result = await page.evaluate(async (pk) => {
await window._mapSelectRefNode(pk, 'AmbigNode');
return window._mapGetNeighborPubkeys();
}, testPubkey);
// Should include the known neighbor AND both ambiguous candidates
assert(result.includes(knownNeighbor), 'Should include known neighbor');
assert(result.includes(candidate1), 'Should include ambiguous candidate 1');
assert(result.includes(candidate2), 'Should include ambiguous candidate 2');
assert(result.length === 3, `Should have 3 neighbors (1 known + 2 candidates), got ${result.length}`);
await page.unroute(`**/api/nodes/${testPubkey}/neighbors*`);
});
await browser.close();
const passed = results.filter(r => r.pass).length;
const failed = results.filter(r => !r.pass).length;
console.log(`\n${passed}/${results.length} tests passed${failed ? `, ${failed} failed` : ''}`);
process.exit(failed > 0 ? 1 : 0);
}
run().catch(err => {
console.error('Fatal error:', err);
process.exit(1);
});