mirror of
https://github.com/Kpa-clawbot/meshcore-analyzer.git
synced 2026-11-22 19:17:58 +00:00
Fixes #2290; addresses U6 of #1154. Full node details, the side preview and tablet slide-over offer Open in Map and View packets through existing deep links. A shared renderer validates coordinates, including zero, and encodes identifiers without extra fetches. Closing a preview preserves newly selected destinations and titles; manual close returns to Nodes. Tablet targets stay separate, and modified clicks retain native behavior. Refreshed at `538cb169` by normally merging current master `d1bf4ca0`, with zero conflicts. The original five commits and exact seven-file feature patch are preserved. The [original RED CI](https://github.com/Kpa-clawbot/CoreScope/actions/runs/40203064817) remains; the preserved RED also reproduces 39 assertions locally. Upstream #2333 now supplies the correction for the previous unrelated navigation-focus CI failure. Current validation: all 225 frontend suites; 52 focused unit checks; 31 shortcut browser cases in each theme; 24 additional title/native-click cases; navigation 60/60, branding 17/17 and slide-over 27/27. Parent independently reran 52 unit and 31 browser cases. Native server and ingestor suites pass. General browser smoke reports 149 passes and three existing fixture skips. Unchanged serial retries resolved two documented local test-server/navigation setup failures. Browser verified: disposable local Go fixture at `http://127.0.0.1:14954`. E2E assertion added: `tests/e2e/test-node-quick-actions-e2e.js`. Constant work for one detail view; no new requests, dependencies or settings. [Final refreshed CI](https://github.com/Kpa-clawbot/CoreScope/actions/runs/42318272198) passes. Independent adversarial, UI and test-quality reviews found no must-fixes; Kent Beck Gate: PASS. --------- Co-authored-by: n30nex <6686206+n30nex@users.noreply.github.com>
240 lines
14 KiB
JavaScript
240 lines
14 KiB
JavaScript
'use strict';
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
const { chromium } = require('playwright');
|
|
|
|
const BASE = process.env.BASE_URL || 'http://localhost:3000';
|
|
assert.ok(['localhost', '127.0.0.1', '[::1]'].includes(new URL(BASE).hostname), 'Use a local fixture server');
|
|
const surfaces = [
|
|
{ name: 'desktop-full', width: 1400, selector: '#nodeFullBody', full: true },
|
|
{ name: 'desktop-side', width: 1400, selector: '#nodesRight' },
|
|
{ name: 'tablet-slide-over', width: 820, selector: '.slide-over-content' },
|
|
{ name: 'phone-full', width: 390, selector: '#nodeFullBody', full: true, touch: true },
|
|
];
|
|
let passed = 0, failed = 0;
|
|
async function test(name, run) {
|
|
try { await run(); passed++; console.log('PASS ' + name); }
|
|
catch (error) { failed++; console.error('FAIL ' + name + ': ' + error.message); }
|
|
}
|
|
|
|
(async () => {
|
|
const browser = await chromium.launch({ headless: true, executablePath: process.env.CHROMIUM_PATH || undefined });
|
|
try {
|
|
const requestContext = await browser.newContext();
|
|
const response = await requestContext.request.get(BASE + '/api/nodes?limit=1');
|
|
assert.ok(response.ok(), 'fixture nodes API succeeds');
|
|
const node = (await response.json()).nodes[0];
|
|
assert.ok(node && node.public_key, 'fixture must contain a node');
|
|
const detailResponse = await requestContext.request.get(BASE + '/api/nodes/' + encodeURIComponent(node.public_key));
|
|
assert.ok(detailResponse.ok(), 'fixture detail API succeeds');
|
|
const detail = await detailResponse.json();
|
|
assert.ok(detail.node, 'actual detail response has a node field');
|
|
await requestContext.close();
|
|
|
|
async function open(surface, overrides = {}) {
|
|
const ctx = await browser.newContext({
|
|
viewport: { width: surface.width, height: 900 },
|
|
hasTouch: !!surface.touch, isMobile: surface.mobile == null ? !!surface.touch : surface.mobile,
|
|
});
|
|
await ctx.addInitScript(() => {
|
|
localStorage.setItem('meshcore-time-window', '60');
|
|
localStorage.setItem('map-view', JSON.stringify({ lat: 40, lng: -80, zoom: 3 }));
|
|
});
|
|
const page = await ctx.newPage();
|
|
page.setDefaultTimeout(10000);
|
|
page.setDefaultNavigationTimeout(30000); // index.html loads vendor scripts from a CDN
|
|
const current = { ...detail.node, lat: 12.5, lon: 34.5, ...overrides };
|
|
// Preserve the live API shape, replacing just the chosen node so edge
|
|
// cases are deterministic; all application scripts and routing are real.
|
|
await page.route(url => url.pathname === '/api/nodes', route => route.fulfill({ json: {
|
|
nodes: [current], total: 1, has_more: false,
|
|
counts: { repeaters: 1, rooms: 0, companions: 0, sensors: 0 },
|
|
} }));
|
|
await page.route(url => url.pathname === '/api/nodes/' + encodeURIComponent(node.public_key),
|
|
route => route.fulfill({ json: { ...detail, node: current } }));
|
|
await page.goto(BASE + '/#/nodes' + (surface.full ? '/' + encodeURIComponent(node.public_key) : ''), { waitUntil: 'domcontentloaded' });
|
|
// The startup theme response refreshes the Nodes renderer. Open the
|
|
// slide-over after that refresh, so it cannot replace a link mid-click.
|
|
await page.waitForFunction(() => window.SITE_CONFIG && window.SITE_CONFIG.timestamps && _themeRefreshTimer === null);
|
|
if (!surface.full) await page.locator('#nodesBody tr[data-action="select"]').first().click();
|
|
const host = page.locator(surface.selector);
|
|
const existing = surface.name === 'tablet-slide-over'
|
|
? host.getByRole('link', { name: 'Open full detail →', exact: true })
|
|
: host.getByRole('link', { name: 'Analytics', exact: true });
|
|
await existing.waitFor({ state: 'visible' });
|
|
return { ctx, page, host, current };
|
|
}
|
|
|
|
for (const surface of surfaces) {
|
|
for (const destination of ['map', 'packets']) {
|
|
await test(surface.name + ' opens ' + destination, async () => {
|
|
const { ctx, page, host, current } = await open(surface);
|
|
try {
|
|
const label = destination === 'map' ? 'Open in Map' : 'View packets';
|
|
const link = host.getByRole('link', { name: label, exact: true });
|
|
assert.equal(await link.count(), 1, label + ' must be present');
|
|
const rect = await link.boundingBox();
|
|
assert.ok(rect && rect.width > 0 && rect.x >= 0 && rect.x + rect.width <= surface.width,
|
|
label + ' fits within the viewport');
|
|
if (surface.touch) assert.ok(rect.height >= 44 && rect.width >= 44, 'phone actions have a 44px touch target');
|
|
if (process.env.SCREENSHOT_DIR && destination === 'map') {
|
|
fs.mkdirSync(process.env.SCREENSHOT_DIR, { recursive: true });
|
|
await page.screenshot({ path: path.join(process.env.SCREENSHOT_DIR, surface.name + '.png'), animations: 'disabled' });
|
|
}
|
|
const regionBefore = await page.evaluate(() => localStorage.getItem('meshcore-region-filter'));
|
|
const packetRequest = destination === 'packets'
|
|
? page.waitForRequest(request => {
|
|
const url = new URL(request.url());
|
|
return url.pathname === '/api/packets' && url.searchParams.get('node') === current.public_key;
|
|
}) : null;
|
|
// Native anchor keyboard behavior on desktop; actual tap on phone.
|
|
const activate = async () => {
|
|
if (surface.touch) await link.tap();
|
|
else if (surface.name === 'desktop-full') { await link.focus(); await page.keyboard.press('Enter'); }
|
|
else await link.click();
|
|
};
|
|
if (packetRequest) await Promise.all([packetRequest, activate()]);
|
|
else await activate();
|
|
await page.waitForURL(url => url.hash.startsWith('#/' + destination + '?'));
|
|
const params = new URLSearchParams(new URL(page.url()).hash.split('?')[1]);
|
|
assert.equal(params.get('node'), current.public_key);
|
|
if (destination === 'map') {
|
|
await page.locator('.leaflet-popup-content .map-popup').waitFor({ state: 'visible' });
|
|
assert.ok((await page.locator('.leaflet-popup-content').innerText()).includes(current.name), 'selected node popup opens');
|
|
const viewport = await page.evaluate(() => ({ center: window.__mc_map.getCenter(), zoom: window.__mc_map.getZoom() }));
|
|
assert.ok(Math.abs(viewport.center.lat - current.lat) < .001 && Math.abs(viewport.center.lng - current.lon) < .001);
|
|
assert.equal(viewport.zoom, 14);
|
|
} else {
|
|
await packetRequest;
|
|
await page.locator('#fNode').waitFor({ state: 'attached' });
|
|
if (surface.touch) await page.getByRole('button', { name: 'Filters ▾', exact: true }).tap();
|
|
await page.locator('#fNode').waitFor({ state: 'visible' });
|
|
assert.equal(await page.locator('#fNode').inputValue(), current.public_key.slice(0, 8));
|
|
assert.equal(await page.evaluate(() => localStorage.getItem('meshcore-time-window')), '60');
|
|
}
|
|
assert.equal(new URL(page.url()).hash.split('?')[0], '#/' + destination, 'closing the detail must preserve the destination');
|
|
assert.equal(await page.evaluate(() => localStorage.getItem('meshcore-region-filter')), regionBefore);
|
|
} finally { await ctx.close(); }
|
|
});
|
|
}
|
|
}
|
|
|
|
for (const surface of [surfaces[0], surfaces[1]]) {
|
|
for (const label of ['Analytics', 'Reach']) {
|
|
await test(surface.name + ' preserves ' + label, async () => {
|
|
const { ctx, page, host, current } = await open(surface);
|
|
try {
|
|
await host.getByRole('link', { name: label, exact: true }).click();
|
|
const destination = '#/nodes/' + encodeURIComponent(current.public_key) + '/' + label.toLowerCase();
|
|
await page.waitForURL(url => url.hash === destination);
|
|
await page.waitForFunction(expected => currentPage === expected, 'node-' + label.toLowerCase());
|
|
assert.equal(new URL(page.url()).hash, destination);
|
|
} finally { await ctx.close(); }
|
|
});
|
|
}
|
|
}
|
|
for (const method of ['Escape', 'backdrop']) {
|
|
await test('tablet preview ' + method + ' returns to the list', async () => {
|
|
const { ctx, page } = await open(surfaces[2]);
|
|
try {
|
|
if (method === 'Escape') await page.keyboard.press('Escape');
|
|
else await page.locator('.slide-over-backdrop').click({ position: { x: 20, y: 400 } });
|
|
await page.locator('.slide-over-panel').waitFor({ state: 'detached' });
|
|
assert.equal(new URL(page.url()).hash, '#/nodes');
|
|
assert.ok(await page.locator('#nodesBody tr[data-action="select"]').count());
|
|
} finally { await ctx.close(); }
|
|
});
|
|
}
|
|
await test('desktop preview Details still opens full detail', async () => {
|
|
const { ctx, page, host, current } = await open(surfaces[1]);
|
|
try {
|
|
await host.locator('.node-detail-btn').click();
|
|
await page.locator('#nodeFullBody').getByRole('link', { name: 'Analytics', exact: true }).waitFor();
|
|
assert.equal(new URL(page.url()).hash, '#/nodes/' + encodeURIComponent(current.public_key));
|
|
} finally { await ctx.close(); }
|
|
});
|
|
await test('tablet preview opens full detail without losing its hash', async () => {
|
|
const { ctx, page, host, current } = await open(surfaces[2]);
|
|
try {
|
|
await host.getByRole('link', { name: 'Open full detail →', exact: true }).click();
|
|
await page.locator('.slide-over-panel').waitFor({ state: 'detached' });
|
|
await page.locator('#nodeFullBody').getByRole('link', { name: 'Analytics', exact: true }).waitFor();
|
|
assert.equal(new URL(page.url()).hash, '#/nodes/' + encodeURIComponent(current.public_key));
|
|
await page.getByRole('button', { name: 'Back to nodes', exact: true }).click();
|
|
await page.locator('#nodesBody tr[data-action="select"]').waitFor();
|
|
assert.equal(new URL(page.url()).hash, '#/nodes');
|
|
} finally { await ctx.close(); }
|
|
});
|
|
await test('touch tablet actions have separate 44px targets', async () => {
|
|
const { ctx, page, host } = await open({ ...surfaces[2], touch: true, mobile: false });
|
|
try {
|
|
assert.equal(await page.evaluate(() => matchMedia('(pointer: coarse)').matches), true);
|
|
await host.evaluate(element => Promise.all(element.closest('.slide-over-panel').getAnimations().map(animation => animation.finished)));
|
|
const labels = ['Open full detail →', 'Open in Map', 'View packets'];
|
|
const bounds = [];
|
|
for (const label of labels) {
|
|
const rect = await host.getByRole('link', { name: label, exact: true }).boundingBox();
|
|
assert.ok(rect, label + ' must be visible');
|
|
bounds.push({ label, ...rect });
|
|
}
|
|
console.log('TABLET_ACTION_BOUNDS ' + JSON.stringify(bounds));
|
|
if (process.env.SCREENSHOT_DIR) {
|
|
fs.mkdirSync(process.env.SCREENSHOT_DIR, { recursive: true });
|
|
await page.screenshot({ path: path.join(process.env.SCREENSHOT_DIR, 'tablet-touch-actions.png'), animations: 'disabled' });
|
|
}
|
|
for (let i = 0; i < bounds.length; i++) {
|
|
for (let j = i + 1; j < bounds.length; j++) {
|
|
const a = bounds[i], b = bounds[j];
|
|
const overlap = Math.max(0, Math.min(a.x + a.width, b.x + b.width) - Math.max(a.x, b.x)) *
|
|
Math.max(0, Math.min(a.y + a.height, b.y + b.height) - Math.max(a.y, b.y));
|
|
assert.equal(overlap, 0, a.label + ' overlaps ' + b.label + ' by ' + overlap + 'px²');
|
|
}
|
|
}
|
|
for (const rect of bounds) assert.ok(rect.width >= 44 && rect.height >= 44, rect.label + ' must have a 44px touch target');
|
|
} finally { await ctx.close(); }
|
|
});
|
|
for (const surface of [surfaces[0], surfaces[1], surfaces[2], surfaces[3]]) {
|
|
for (const coords of [{ lat: null }, { lat: '12north' }, { lon: 181 }]) {
|
|
await test(surface.name + ' suppresses Map for ' + JSON.stringify(coords), async () => {
|
|
const { ctx, host } = await open(surface, coords);
|
|
try {
|
|
assert.equal(await host.getByRole('link', { name: 'Open in Map', exact: true }).count(), 0);
|
|
assert.equal(await host.getByRole('link', { name: 'View packets', exact: true }).count(), 1);
|
|
} finally { await ctx.close(); }
|
|
});
|
|
}
|
|
}
|
|
await test('zero coordinates override the saved map viewport', async () => {
|
|
const { ctx, page, host } = await open(surfaces[3], { lat: 0, lon: 0 });
|
|
try {
|
|
const link = host.getByRole('link', { name: 'Open in Map', exact: true });
|
|
assert.equal(await link.count(), 1);
|
|
await link.tap();
|
|
await page.waitForFunction(() => window.__mc_map && document.getElementById('leaflet-map'));
|
|
const viewport = await page.evaluate(() => ({ center: window.__mc_map.getCenter(), zoom: window.__mc_map.getZoom() }));
|
|
assert.ok(Math.abs(viewport.center.lat) < .001 && Math.abs(viewport.center.lng) < .001);
|
|
assert.equal(viewport.zoom, 14);
|
|
} finally { await ctx.close(); }
|
|
});
|
|
await test('hostile identifiers stay inside the node query parameter', async () => {
|
|
const key = 'node" onfocus="bad &/?#%\'<value>';
|
|
const { ctx, page, host } = await open(surfaces[0], { public_key: key });
|
|
try {
|
|
for (const label of ['Open in Map', 'View packets']) {
|
|
const link = host.getByRole('link', { name: label, exact: true });
|
|
assert.equal(await link.count(), 1);
|
|
const attrs = await link.evaluate(element => ({ href: element.getAttribute('href'), injected: element.hasAttribute('onfocus') }));
|
|
assert.equal(new URLSearchParams(attrs.href.split('?')[1]).get('node'), key);
|
|
assert.equal(attrs.injected, false);
|
|
}
|
|
await host.getByRole('link', { name: 'View packets', exact: true }).click();
|
|
await page.waitForURL(url => url.hash.startsWith('#/packets?'));
|
|
assert.equal(new URLSearchParams(new URL(page.url()).hash.split('?')[1]).get('node'), key);
|
|
} finally { await ctx.close(); }
|
|
});
|
|
} finally { await browser.close(); }
|
|
console.log(`${passed} passed, ${failed} failed`);
|
|
process.exitCode = failed ? 1 : 0;
|
|
})().catch(error => { console.error(error); process.exitCode = 1; });
|