mirror of
https://github.com/Kpa-clawbot/meshcore-analyzer.git
synced 2026-10-15 11:29:56 +00:00
Alex B
893773338e
Moves 290 root test-*.js into tests/unit (177, listed in test-all.sh) and tests/e2e (113, classified in scripts/non-unit-tests.json), per #1981 and PR-D of #1385. Root goes from 348 entries to 48. test-all.sh and test-fixtures/ stay put. The inventory guard now fails if a test reappears in the root or sits in the wrong folder.
Verified independently of the diff: the invoked sets are unchanged (test-all.sh 177 before and after, deploy.yml 96 before and after, both identical as sets), and a full local run of test-all.sh on master and on the branch produced 4702 output lines each whose only differences are absolute paths, stack-trace line numbers shifted by the REPO_ROOT line, the inventory wording and two perf ratios. The guard was mutation-checked: a test back in the root, a unit suite in tests/e2e, and a suite dropped from test-all.sh each make it exit 1. CI run 35246304316 ran 97 suites from tests/e2e and is green.
Follow-up 9335c51d finished the instruction files: no bare root test command is left in AGENTS.md, the squad charters, .github or docs, and every tests/ path they name resolves.
Merged by the interim maintainer without a second human reviewer: CI and the local runs above are the independent checks.
Known and deliberately out of scope: 18 of the 113 files in tests/e2e are invoked by no runner at all, and one of them cannot run anywhere because it requires jsdom, which is not a declared dependency. Tracked separately.
52 lines
1.9 KiB
JavaScript
52 lines
1.9 KiB
JavaScript
/**
|
|
* #1375 — regression(analytics): Scopes tab fetches `/api/api/scope-stats`
|
|
* (duplicate prefix) → 404 → SPA HTML → JSON.parse error.
|
|
*
|
|
* The `api()` helper already prepends `/api`. Other callers in
|
|
* public/analytics.js correctly pass `/scope-stats` style relative paths;
|
|
* the Scopes loader was the lone offender passing `/api/scope-stats`,
|
|
* producing the doubled prefix at runtime.
|
|
*
|
|
* Fix: drop the leading `/api` from the Scopes-tab call so the helper
|
|
* builds `/api/scope-stats?window=…`.
|
|
*
|
|
* Originally landed on the PR #915 branch (commit 2fd22cee) but that
|
|
* branch never merged, so the bug resurfaced in subsequent rebases.
|
|
*/
|
|
'use strict';
|
|
const REPO_ROOT = require('path').resolve(__dirname, '..', '..');
|
|
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
let passed = 0, failed = 0;
|
|
function assert(cond, msg) {
|
|
if (cond) { passed++; console.log(' ✓ ' + msg); }
|
|
else { failed++; console.error(' ✗ ' + msg); }
|
|
}
|
|
|
|
const src = fs.readFileSync(
|
|
path.join(REPO_ROOT, 'public', 'analytics.js'), 'utf8');
|
|
|
|
console.log('\n=== #1375: Scopes tab scope-stats fetch path ===');
|
|
|
|
// Regression guard: the buggy doubled-prefix form must never reappear.
|
|
const badRe = /api\(\s*['"]\/api\/scope-stats/g;
|
|
const badMatches = src.match(badRe) || [];
|
|
assert(badMatches.length === 0,
|
|
"ZERO `api('/api/scope-stats'` occurrences in analytics.js " +
|
|
'(regression guard for doubled /api prefix)');
|
|
|
|
// Positive: the corrected, helper-relative form is present exactly once.
|
|
const goodRe = /api\(\s*['"]\/scope-stats/g;
|
|
const goodMatches = src.match(goodRe) || [];
|
|
assert(goodMatches.length === 1,
|
|
"Exactly one `api('/scope-stats'` call exists (the fixed loader) — " +
|
|
'found ' + goodMatches.length);
|
|
|
|
console.log('\n=== Summary ===');
|
|
console.log(' Passed: ' + passed);
|
|
console.log(' Failed: ' + failed);
|
|
console.log('\n#1375 ' + (failed === 0 ? 'PASS' : 'FAIL'));
|
|
process.exit(failed === 0 ? 0 : 1);
|