mirror of
https://github.com/Kpa-clawbot/meshcore-analyzer.git
synced 2026-11-22 03:17:04 +00:00
## Summary `TestNodeAnalyticsWindowIgnoresLocalZone` set the zone by assigning the global `time.Local`. Every `time.Now()` reads that variable, so if a timer left over from an earlier test fires during this test, the race detector reports a data race. It counts as a failure of this test, whichever test left the timer. It showed up as an intermittent failure of the server race detector (shard 3/4) on a PR run (#2436). Three local runs of the same shard passed. The code under test is fine; only the test was racy. ## Change The test now re-runs itself in a child process with `TZ=Etc/GMT-2` (UTC+2) and writes nothing global: - **Embedded zone data:** `time/tzdata` is embedded in the test binary, so the zone resolves without the host's zoneinfo. - **Zone check:** the child first checks that its local offset really is +02:00. - **Test name:** the child's `-test.run` pattern is built from `t.Name()`. - **Vacuous pass guarded:** the parent requires `--- PASS: <name>` in the child's output, so a rename can't make it pass without running. - **Windows:** the test is skipped there before the re-exec. Go on Windows takes the local zone from the OS and ignores `TZ`, so the child cannot be put in UTC+2. - **Bounded child:** the child runs under a 60 s context, so a hung child fails with its output. This follows the existing re-exec pattern in `distance_background_fill_test.go`. `TestMain` is just `os.Exit(m.Run())`, so the child runs only this test. It works under the sharded `-test.run` in the race job, and in coverage builds. ## Testing - `go test -race -run TestNodeAnalyticsWindowIgnoresLocalZone`: pass. gofmt and vet are clean. - **Still guards the original bug:** with `time.Now().UTC()` changed back to `time.Now()` in `GetNodeAnalytics`, it fails as before. The 7d window holds 166 of 168 packets, and `From` is `...+02:00`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>