Zach and Claude Opus 5.5
9a57b2fca6
test(server): set the local zone in a child process, not via time.Local ( #2438 )
...
## Summary
`TestNodeAnalyticsWindowIgnoresLocalZone` set the zone by assigning the
global `time.Local`. Every `time.Now()` reads that variable, so if a
timer left over from an earlier test fires during this test, the race
detector reports a data race. It counts as a failure of this test,
whichever test left the timer.
It showed up as an intermittent failure of the server race detector
(shard 3/4) on a PR run (#2436 ). Three local runs of the same shard
passed. The code under test is fine; only the test was racy.
## Change
The test now re-runs itself in a child process with `TZ=Etc/GMT-2`
(UTC+2) and writes nothing global:
- **Embedded zone data:** `time/tzdata` is embedded in the test binary,
so the zone resolves without the host's zoneinfo.
- **Zone check:** the child first checks that its local offset really is
+02:00.
- **Test name:** the child's `-test.run` pattern is built from
`t.Name()`.
- **Vacuous pass guarded:** the parent requires `--- PASS: <name>` in
the child's output, so a rename can't make it pass without running.
- **Windows:** the test is skipped there before the re-exec. Go on
Windows takes the local zone from the OS and ignores `TZ`, so the child
cannot be put in UTC+2.
- **Bounded child:** the child runs under a 60 s context, so a hung
child fails with its output.
This follows the existing re-exec pattern in
`distance_background_fill_test.go`. `TestMain` is just
`os.Exit(m.Run())`, so the child runs only this test. It works under the
sharded `-test.run` in the race job, and in coverage builds.
## Testing
- `go test -race -run TestNodeAnalyticsWindowIgnoresLocalZone`: pass.
gofmt and vet are clean.
- **Still guards the original bug:** with `time.Now().UTC()` changed
back to `time.Now()` in `GetNodeAnalytics`, it fails as before. The 7d
window holds 166 of 168 packets, and `From` is `...+02:00`.
🤖 Generated with [Claude Code](https://claude.com/claude-code )
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com >
2026-11-21 22:26:05 +01:00
..
2026-04-21 09:09:39 -07:00
2026-10-10 18:20:49 +02:00
2026-11-17 11:40:05 +01:00
2026-11-17 11:40:05 +01:00
2026-10-26 09:50:20 +01:00
2026-10-07 09:25:29 +02:00
2026-10-26 15:42:01 +01:00
2026-10-22 21:20:42 +02:00
2026-10-08 21:38:30 +02:00
2026-10-08 21:38:30 +02:00
2026-10-10 18:20:49 +02:00
2026-10-08 22:02:39 +02:00
2026-10-08 21:38:30 +02:00
2026-11-17 11:40:05 +01:00
2026-10-08 21:38:30 +02:00
2026-10-03 12:16:55 +02:00
2026-04-03 13:51:13 -07:00
2026-10-26 15:42:01 +01:00
2026-10-03 12:16:55 +02:00
2026-10-03 12:16:55 +02:00
2026-10-03 12:16:55 +02:00
2026-10-11 09:51:48 +02:00
2026-09-22 07:55:37 +02:00
2026-05-21 14:00:15 -07:00
2026-10-11 09:51:48 +02:00
2026-09-13 19:59:37 +02:00
2026-09-13 19:59:37 +02:00
2026-09-04 16:02:59 +02:00
2026-10-17 11:46:18 +02:00
2026-10-07 09:25:29 +02:00
2026-10-08 22:02:39 +02:00
2026-10-08 22:02:39 +02:00
2026-10-08 21:38:30 +02:00
2026-10-07 09:25:29 +02:00
2026-10-20 14:53:26 +02:00
2026-10-10 18:08:51 +02:00
2026-10-08 21:38:30 +02:00
2026-10-08 22:02:39 +02:00
2026-10-26 09:50:20 +01:00
2026-11-16 16:15:36 +01:00
2026-11-16 16:15:36 +01:00
2026-10-20 14:53:26 +02:00
2026-11-17 11:40:05 +01:00
2026-11-17 11:40:05 +01:00
2026-10-10 18:20:49 +02:00
2026-11-17 11:40:05 +01:00
2026-05-03 17:56:42 -07:00
2026-05-03 17:56:42 -07:00
2026-10-10 18:20:49 +02:00
2026-10-08 16:26:10 +02:00
2026-09-16 09:02:13 +02:00
2026-05-18 22:51:23 -07:00
2026-05-18 22:51:23 -07:00
2026-05-18 22:51:23 -07:00
2026-10-26 15:42:29 +01:00
2026-10-17 11:46:18 +02:00
2026-06-04 03:21:26 -07:00
2026-09-03 18:52:03 +02:00
2026-10-09 19:58:42 +02:00
2026-10-09 19:58:42 +02:00
2026-06-04 13:14:09 +00:00
2026-09-03 18:52:03 +02:00
2026-10-26 15:42:01 +01:00
2026-10-29 18:33:59 +01:00
2026-10-29 18:33:59 +01:00
2026-10-26 15:42:01 +01:00
2026-10-29 18:33:59 +01:00
2026-10-29 18:33:59 +01:00
2026-10-17 11:46:18 +02:00
2026-04-20 21:46:34 -07:00
2026-10-05 20:32:40 +02:00
2026-09-13 20:36:34 +02:00
2026-09-03 18:52:03 +02:00
2026-05-25 22:16:14 -07:00
2026-06-07 03:43:29 -07:00
2026-09-16 09:02:13 +02:00
2026-09-16 09:02:13 +02:00
2026-09-03 18:52:03 +02:00
2026-11-17 23:31:45 +01:00
2026-06-03 13:58:04 -07:00
2026-06-06 22:45:05 -07:00
2026-10-26 09:50:20 +01:00
2026-11-16 16:15:36 +01:00
2026-11-16 16:15:36 +01:00
2026-11-16 16:15:36 +01:00
2026-11-16 16:15:36 +01:00
2026-10-21 15:17:58 +02:00
2026-10-21 15:17:58 +02:00
2026-11-11 00:25:32 +01:00
2026-09-02 09:50:18 +02:00
2026-09-03 18:52:03 +02:00
2026-09-02 09:50:18 +02:00
2026-05-18 12:27:44 -07:00
2026-09-03 18:52:03 +02:00
2026-09-13 19:59:37 +02:00
2026-05-21 14:00:15 -07:00
2026-10-10 18:20:49 +02:00
2026-10-10 18:20:49 +02:00
2026-10-10 18:20:49 +02:00
2026-10-10 18:20:49 +02:00
2026-05-21 11:39:49 -07:00
2026-05-21 11:39:49 -07:00
2026-05-21 11:39:49 -07:00
2026-09-03 18:52:03 +02:00
2026-10-10 21:20:40 +02:00
2026-10-13 08:44:49 +02:00
2026-10-13 08:44:49 +02:00
2026-10-13 08:44:49 +02:00
2026-10-13 08:44:49 +02:00
2026-06-06 22:45:05 -07:00
2026-11-16 16:15:36 +01:00
2026-10-10 18:20:49 +02:00
2026-05-30 13:22:41 -07:00
2026-11-08 17:46:17 +01:00
2026-05-30 13:22:41 -07:00
2026-11-08 17:46:17 +01:00
2026-11-08 17:46:17 +01:00
2026-06-19 11:37:16 -07:00
2026-06-27 22:03:05 -07:00
2026-10-26 15:42:29 +01:00
2026-10-17 11:46:18 +02:00
2026-06-04 14:41:00 -07:00
2026-09-02 13:10:43 +00:00
2026-09-23 10:05:59 +02:00
2026-11-15 12:24:27 +01:00
2026-11-18 18:16:29 +01:00
2026-10-15 10:30:28 +02:00
2026-06-12 19:10:44 -07:00
2026-05-15 22:34:21 -07:00
2026-09-03 18:52:03 +02:00
2026-09-03 18:52:03 +02:00
2026-10-10 18:20:49 +02:00
2026-10-10 18:20:49 +02:00
2026-10-21 12:17:33 +02:00
2026-10-21 12:17:33 +02:00
2026-05-05 01:16:57 -07:00
2026-09-03 18:52:03 +02:00
2026-10-26 15:42:42 +01:00
2026-10-25 12:11:09 +01:00
2026-09-17 21:58:34 +02:00
2026-11-15 12:24:43 +01:00
2026-11-16 16:15:36 +01:00
2026-11-16 16:15:36 +01:00
2026-04-16 00:09:36 -07:00
2026-09-20 15:12:36 +02:00
2026-11-15 12:24:43 +01:00
2026-11-15 12:24:43 +01:00
2026-10-17 11:46:18 +02:00
2026-06-04 16:27:48 -07:00
2026-05-05 01:58:52 -07:00
2026-05-19 23:53:41 -07:00
2026-03-31 01:10:56 -07:00
2026-09-05 09:57:44 +02:00
2026-10-26 21:09:01 +01:00
2026-10-26 21:09:01 +01:00
2026-10-26 15:42:29 +01:00
2026-10-26 15:42:29 +01:00
2026-10-26 15:42:29 +01:00
2026-11-18 18:16:29 +01:00
2026-10-26 15:42:15 +01:00
2026-10-26 15:42:15 +01:00
2026-09-03 18:52:03 +02:00
2026-10-26 15:42:15 +01:00
2026-11-16 14:56:09 +01:00
2026-06-19 11:37:16 -07:00
2026-09-16 09:02:13 +02:00
2026-06-11 10:10:12 -07:00
2026-06-11 10:10:12 -07:00
2026-10-12 12:42:17 +02:00
2026-05-15 16:21:14 +00:00
2026-05-16 19:55:00 +00:00
2026-09-03 18:52:03 +02:00
2026-05-15 20:24:55 -07:00
2026-05-15 22:46:25 -07:00
2026-09-16 09:02:13 +02:00
2026-09-06 21:00:44 +02:00
2026-10-12 12:41:46 +02:00
2026-10-13 08:37:54 +02:00
2026-09-16 09:02:13 +02:00
2026-05-21 14:00:15 -07:00
2026-10-09 19:58:42 +02:00
2026-05-02 20:35:15 -07:00
2026-05-17 16:13:11 +00:00
2026-05-19 08:08:28 -07:00
2026-05-18 23:19:27 -07:00
2026-09-16 09:02:13 +02:00
2026-06-25 05:05:46 -07:00
2026-09-16 09:02:13 +02:00
2026-06-11 07:38:36 -07:00
2026-09-03 18:52:03 +02:00
2026-06-11 07:38:36 -07:00
2026-06-06 22:44:59 -07:00
2026-09-16 09:02:13 +02:00
2026-09-16 09:02:13 +02:00
2026-10-12 11:13:53 +02:00
2026-09-16 09:02:13 +02:00
2026-09-16 09:02:13 +02:00
2026-11-16 16:15:36 +01:00
2026-11-16 16:15:36 +01:00
2026-11-16 16:15:36 +01:00
2026-11-16 16:15:36 +01:00
2026-10-11 11:28:20 +02:00
2026-10-11 11:28:20 +02:00
2026-11-18 18:16:29 +01:00
2026-09-03 18:52:03 +02:00
2026-09-16 09:02:13 +02:00
2026-09-16 09:02:13 +02:00
2026-09-02 10:27:48 +02:00
2026-06-30 15:16:31 -07:00
2026-06-12 08:11:02 -07:00
2026-09-02 10:27:48 +02:00
2026-10-08 15:58:07 +02:00
2026-09-16 09:02:13 +02:00
2026-05-03 08:56:09 -07:00
2026-05-21 14:00:15 -07:00
2026-11-18 18:35:41 +01:00
2026-11-20 16:25:51 +01:00
2026-11-20 16:25:51 +01:00
2026-09-16 09:02:13 +02:00
2026-10-21 12:17:37 +02:00
2026-04-02 23:45:03 -07:00
2026-09-03 18:52:03 +02:00
2026-09-03 18:52:03 +02:00
2026-05-29 02:42:21 -07:00
2026-05-29 02:42:21 -07:00
2026-05-29 02:42:21 -07:00
2026-10-21 12:17:37 +02:00
2026-05-16 10:14:44 -07:00
2026-10-21 12:17:37 +02:00
2026-11-16 16:15:36 +01:00
2026-10-21 12:17:33 +02:00
2026-10-21 12:17:37 +02:00
2026-09-16 09:02:13 +02:00
2026-10-17 11:46:23 +02:00
2026-09-16 09:02:13 +02:00
2026-05-19 23:53:41 -07:00
2026-11-21 22:26:05 +01:00
2026-10-10 11:03:56 +02:00
2026-10-10 11:03:56 +02:00
2026-09-03 18:52:03 +02:00
2026-09-13 21:09:51 +02:00
2026-09-22 07:55:37 +02:00
2026-09-22 07:55:37 +02:00
2026-10-16 10:53:10 +02:00
2026-10-15 16:31:00 +02:00
2026-09-13 19:59:56 +02:00
2026-10-16 09:27:21 +02:00
2026-09-16 09:02:13 +02:00
2026-06-09 03:23:48 -07:00
2026-10-25 12:10:58 +01:00
2026-10-29 22:50:59 +01:00
2026-10-29 22:50:59 +01:00
2026-10-29 22:50:59 +01:00
2026-09-16 09:02:13 +02:00
2026-10-19 00:36:51 +02:00
2026-10-19 00:36:51 +02:00
2026-10-09 21:20:34 +02:00
2026-10-29 22:50:59 +01:00
2026-10-29 22:50:59 +01:00
2026-06-19 11:37:16 -07:00
2026-10-21 15:17:58 +02:00
2026-10-17 11:46:18 +02:00
2026-11-16 16:15:36 +01:00
2026-11-16 16:15:36 +01:00
2026-09-23 09:45:18 +02:00
2026-05-18 09:22:27 -07:00
2026-09-03 18:52:03 +02:00
2026-10-10 21:21:50 +02:00
2026-10-26 09:50:20 +01:00
2026-10-26 09:50:20 +01:00
2026-10-10 20:54:35 +02:00
2026-10-10 20:54:35 +02:00
2026-10-26 09:50:20 +01:00
2026-10-26 09:50:20 +01:00
2026-10-22 21:20:42 +02:00
2026-10-26 09:50:20 +01:00
2026-10-22 19:11:30 +02:00
2026-10-22 21:20:42 +02:00
2026-10-26 15:42:01 +01:00
2026-10-26 15:42:01 +01:00
2026-10-13 09:01:57 +02:00
2026-09-22 11:08:17 +02:00
2026-10-28 19:10:41 +01:00
2026-10-26 09:50:20 +01:00
2026-10-28 19:10:41 +01:00
2026-10-28 19:10:41 +01:00
2026-10-14 21:07:20 +02:00
2026-10-14 21:07:20 +02:00
2026-09-03 18:52:03 +02:00
2026-10-20 10:41:01 +02:00
2026-09-03 18:52:03 +02:00
2026-09-02 09:50:26 +02:00
2026-10-28 19:10:41 +01:00
2026-10-28 19:10:41 +01:00
2026-10-28 19:10:41 +01:00
2026-10-28 19:10:41 +01:00
2026-10-29 06:25:42 +01:00
2026-10-29 06:25:42 +01:00
2026-05-29 01:08:12 -07:00
2026-05-29 01:08:12 -07:00
2026-10-31 12:01:19 +01:00
2026-10-29 22:36:53 +01:00
2026-10-13 08:37:54 +02:00
2026-05-29 02:42:21 -07:00
2026-05-29 02:42:21 -07:00
2026-09-03 18:52:03 +02:00
2026-11-17 23:31:33 +01:00
2026-09-03 18:52:03 +02:00
2026-10-26 15:41:05 +01:00
2026-10-31 11:59:20 +01:00
2026-11-17 23:31:21 +01:00
2026-11-17 23:31:33 +01:00
2026-10-29 18:33:41 +01:00
2026-07-07 00:12:44 -07:00
2026-10-29 18:34:06 +01:00
2026-09-03 18:52:03 +02:00
2026-11-20 16:25:51 +01:00
2026-10-20 10:41:01 +02:00
2026-10-29 18:34:06 +01:00
2026-05-17 16:13:11 +00:00
2026-05-25 22:32:00 -07:00
2026-06-04 23:48:47 -07:00
2026-10-05 20:32:40 +02:00
2026-05-15 22:46:28 -07:00
2026-05-15 22:46:28 -07:00
2026-05-15 22:46:28 -07:00
2026-05-15 22:46:28 -07:00
2026-05-15 22:46:28 -07:00
2026-09-02 09:50:09 +02:00
2026-09-03 18:52:03 +02:00
2026-10-12 12:45:41 +02:00
2026-10-26 15:42:01 +01:00
2026-10-08 14:34:31 +02:00
2026-10-26 15:42:01 +01:00
2026-09-02 14:34:20 +02:00
2026-10-26 15:42:01 +01:00
2026-10-09 19:58:42 +02:00
2026-10-21 11:58:28 +02:00
2026-09-30 11:39:25 +02:00
2026-10-09 19:58:42 +02:00
2026-09-30 11:39:25 +02:00
2026-09-30 11:39:25 +02:00
2026-09-30 11:39:25 +02:00
2026-09-03 18:52:03 +02:00
2026-09-03 18:52:03 +02:00
2026-05-08 16:29:23 -07:00
2026-05-08 16:29:23 -07:00
2026-06-07 09:28:51 -07:00
2026-05-05 17:56:56 -07:00
2026-09-16 09:02:13 +02:00
2026-04-01 19:26:11 -07:00
2026-11-17 23:19:49 +01:00
2026-11-17 23:19:49 +01:00
2026-11-17 23:19:49 +01:00
2026-11-17 23:19:49 +01:00
2026-11-16 16:15:36 +01:00
2026-11-16 16:15:36 +01:00
2026-11-16 16:15:36 +01:00
2026-11-16 16:15:36 +01:00
2026-11-16 16:15:36 +01:00
2026-11-17 23:19:49 +01:00
2026-11-17 23:19:49 +01:00
2026-11-17 23:19:49 +01:00
2026-11-18 23:06:06 +01:00
2026-11-17 23:19:49 +01:00
2026-06-06 22:45:05 -07:00
2026-05-15 09:16:39 -07:00
2026-09-16 09:02:13 +02:00
2026-10-10 18:20:49 +02:00
2026-10-08 21:51:42 +02:00
2026-10-08 21:51:42 +02:00
2026-10-26 21:08:40 +01:00
2026-10-26 21:08:40 +01:00
2026-11-16 16:15:36 +01:00
2026-11-18 18:16:29 +01:00
2026-06-27 22:03:05 -07:00
2026-06-27 22:03:05 -07:00
2026-05-03 19:50:01 -07:00
2026-10-10 21:21:50 +02:00
2026-10-15 16:31:00 +02:00
2026-10-10 21:23:05 +02:00
2026-10-03 12:16:55 +02:00
2026-10-17 11:46:18 +02:00
2026-10-03 12:16:55 +02:00
2026-10-13 15:42:18 +02:00
2026-05-21 11:39:43 -07:00
2026-05-20 20:57:02 -07:00
2026-09-03 18:52:03 +02:00
2026-05-28 15:01:58 -07:00
2026-10-08 14:34:31 +02:00
2026-06-06 20:46:42 -07:00
2026-06-06 20:46:42 -07:00
2026-11-17 11:40:05 +01:00
2026-11-20 16:25:51 +01:00
2026-07-08 15:13:39 -07:00
2026-09-02 18:34:59 +02:00
2026-11-17 11:40:05 +01:00
2026-11-20 16:25:51 +01:00
2026-10-12 12:41:46 +02:00
2026-05-20 20:57:02 -07:00
2026-10-08 14:34:31 +02:00
2026-10-21 15:17:58 +02:00
2026-10-21 15:17:58 +02:00
2026-10-07 09:25:29 +02:00
2026-05-15 16:21:14 +00:00
2026-05-15 09:16:39 -07:00
2026-09-03 18:52:03 +02:00
2026-09-03 18:52:03 +02:00
2026-10-17 11:46:18 +02:00
2026-11-15 12:24:43 +01:00
2026-10-09 19:58:42 +02:00
2026-11-15 12:24:43 +01:00
2026-10-17 11:46:23 +02:00
2026-10-13 09:01:57 +02:00
2026-09-13 20:37:14 +02:00
2026-10-29 22:39:02 +01:00
2026-10-04 22:11:34 +02:00
2026-10-29 22:39:02 +01:00
2026-10-25 12:10:47 +01:00
2026-10-21 15:18:14 +02:00
2026-10-21 15:18:14 +02:00
2026-10-21 15:18:14 +02:00
2026-10-25 12:10:47 +01:00
2026-10-25 12:10:47 +01:00
2026-05-18 07:36:28 -07:00
2026-05-03 17:56:12 -07:00
2026-09-03 18:52:03 +02:00
2026-11-15 12:24:27 +01:00
2026-11-18 18:16:29 +01:00
2026-10-15 10:30:08 +02:00
2026-10-25 12:11:09 +01:00
2026-06-19 11:37:16 -07:00
2026-10-10 17:39:33 +02:00
2026-10-10 17:39:33 +02:00
2026-10-10 18:20:49 +02:00
2026-10-04 17:15:50 +02:00
2026-10-10 17:39:33 +02:00
2026-10-10 18:20:49 +02:00
2026-10-29 22:39:02 +01:00
2026-05-15 16:21:14 +00:00
2026-10-11 11:17:12 +02:00
2026-09-19 11:44:47 +02:00
2026-10-11 11:17:12 +02:00
2026-09-11 15:07:31 +02:00
2026-09-11 15:07:31 +02:00
2026-09-19 11:44:47 +02:00
2026-10-10 21:22:02 +02:00
2026-10-11 11:17:12 +02:00
2026-09-09 17:58:09 +02:00
2026-09-10 22:30:24 +02:00
2026-10-07 11:20:44 +02:00
2026-10-07 11:20:44 +02:00
2026-10-07 11:20:44 +02:00
2026-10-07 11:20:44 +02:00
2026-05-03 17:40:54 -07:00
2026-11-08 17:46:17 +01:00
2026-06-03 13:58:04 -07:00
2026-06-30 18:21:21 -07:00
2026-11-17 23:31:45 +01:00
2026-04-20 23:10:33 -07:00
2026-10-20 11:04:07 +02:00
2026-10-09 19:58:42 +02:00
2026-10-20 11:04:07 +02:00
2026-10-26 15:42:01 +01:00
2026-11-18 18:16:29 +01:00
2026-04-21 09:09:39 -07:00
2026-11-18 18:16:29 +01:00
2026-05-29 02:42:21 -07:00
2026-10-12 12:41:46 +02:00
2026-10-13 08:35:16 +02:00
2026-10-12 12:41:46 +02:00
2026-10-10 21:21:13 +02:00
2026-11-16 16:15:36 +01:00
2026-11-16 16:15:36 +01:00
2026-11-16 16:15:36 +01:00
2026-11-16 16:15:36 +01:00
2026-05-03 17:41:22 -07:00
2026-05-03 17:41:22 -07:00
2026-09-16 09:02:13 +02:00
2026-10-12 12:41:46 +02:00
2026-06-27 22:03:05 -07:00
2026-09-02 18:34:59 +02:00
2026-10-13 08:35:20 +02:00
2026-10-13 08:35:20 +02:00
2026-11-16 16:15:36 +01:00
2026-06-27 22:03:05 -07:00
2026-06-27 22:03:05 -07:00
2026-06-27 22:03:05 -07:00
2026-06-27 22:03:05 -07:00
2026-10-28 19:10:41 +01:00
2026-10-28 19:10:41 +01:00
2026-10-10 18:20:49 +02:00
2026-10-08 22:16:49 +02:00
2026-10-08 22:16:49 +02:00
2026-06-29 05:48:58 -07:00
2026-11-16 14:56:09 +01:00
2026-11-17 23:31:45 +01:00
2026-09-06 21:11:29 +02:00
2026-11-16 16:15:36 +01:00
2026-09-02 14:21:42 +02:00