Merge pull request #3540 from Msprg/felica-argtable-longopt

hf felica liteauth: use NULL instead of "" for options without a long name

CHANGELOG.md

@@ -3,6 +3,7 @@ All notable changes to this project will be documented in this file.
 This project uses the changelog in accordance with [keepchangelog](http://keepachangelog.com/). Please use this to write notable changes, which is not the same as git commit log...
 
 ## [unreleased][unreleased]
+- Fixed `hf felica liteauth` - empty long option names for `-c` and `-k` made argtable read past the string (found by ASAN on `--fulltext`) (@Msprg)
 - Added `sim020.bin` - v4.60 of sim module firmware, better T=0 handling and clock etu handling (@iceman1001)
 - Fixed `hf seos sam` - now have a invalid pacs guard (@iceman1001)
 - Changed i2c comms to auto-negotiation and use ATR-keyed rate cache for speedier smart card comms (@iceman1001)

client/src/cmdhffelica.c

@@ -8999,9 +8999,9 @@ static int CmdHFFelicaAuthenticationLite(const char *Cmd) {
     void *argtable[] = {
         arg_param_begin,
         arg_str0(NULL, "key", "<hex>", "set card key, 16 bytes"),
-        arg_str0("c", "", "<hex>", "set random challenge, 16 bytes"),
+        arg_str0("c", NULL, "<hex>", "set random challenge, 16 bytes"),
         arg_str0(NULL, "idm", "<hex>", "set custom IDm"),
-        arg_lit0("k", "", "keep signal field ON after receive"),
+        arg_lit0("k", NULL, "keep signal field ON after receive"),
         arg_param_end
     };
     CLIExecWithReturn(ctx, Cmd, argtable, true);