22168 Commits

Author SHA1 Message Date
Iceman d0e8cf1861 Merge pull request #3413 from 0xDRRB/master
fix CMD_HF_MIFARE_READBL not working in Lua scripts since 2024-09-24...
2026-07-11 21:50:13 +07:00
Denis Bodor 4a891b3018 fix CMD_HF_MIFARE_READBL not working in Lua scripts after PacketResponseNGPreamble struct split (96d462ace) 2026-07-11 16:13:33 +02:00
Iceman 8728a62933 Merge pull request #3412 from munzzyy/fix-iclass-view-oob-read
Fix heap out-of-bounds read in hf iclass view on short dump files
2026-07-11 11:15:05 +07:00
Cole Munz 2d45e334fb Fix heap out-of-bounds read in hf iclass view on short dump files 2026-07-10 21:02:47 -05:00
Iceman ab11f8f6a7 Merge pull request #3411 from munzzyy/fix-ir56-wiegand-fc-mask
Fix IR56 wiegand decode leaking header sentinel bit into facility code
2026-07-11 03:26:44 +07:00
munzzyy d18d1c6713 Fix IR56 wiegand decode leaking header sentinel bit into facility code 2026-07-10 14:16:54 -05:00
Iceman e3ce59f1a5 Merge pull request #3410 from towelbyte/fix-improve-cotag-demod-auto-threshold
Fix/improve 'lf cotag demod' threshold estimation
2026-07-09 12:46:41 +07:00
towelbyte 2f6a767edf Fix/improve 'lf cotag demod'
Fix/improve 'lf cotag demod' auto threshold estimation
and demodulation of COTAG traces with high value spikes and
COTAG traces with very low amplitude values.
2026-07-09 01:04:35 +02:00
iceman1001 005f4abb1a texts 2026-07-07 22:50:22 +02:00
iceman1001 af2980c753 style 2026-07-06 23:21:00 +02:00
iceman1001 9256181945 updated annotations for some missing desfire commands 2026-07-06 23:20:30 +02:00
Iceman ee8a5cca87 Merge pull request #3409 from munzzyy/fix/em4x05-dump-corruption
Fix lf em 4x05 dump writing corrupted (byte-swapped) dump files
2026-07-07 01:04:26 +07:00
munzzyy 9f83c9307d Fix lf em 4x05 dump writing corrupted (byte-swapped) dump files
em4x05_print_blocks() byte-swaps its buffer in place to display the blocks.
In CmdEM4x05Dump() that call runs before pm3_save_dump(), so the buffer
handed to the saver has been swapped out of the canonical on-disk order and
the saved .bin/.json reloads with every block reversed.

The read loop stores each word as data[addr] = BSWAP_32(word), which is what
the loader in CmdEM4x05View() expects (it reads blocks MSB-first via
bytes_to_num()). The extra in-place swap in the print routine undoes that
right before the save. It also corrupts the auto-generated filename, which is
built from BSWAP_32(data[1]) after the print call. Symmetric words such as
0x00000000 survive the swap, so it's easy to miss.

Give em4x05_print_blocks() a private copy to swap and print, and take the
input as const so it can't mutate the caller's buffer. On-screen output is
unchanged; the dump path now saves the untouched buffer.

Fixes #3403
2026-07-04 18:31:02 -05:00
Iceman 871b40ed97 Merge pull request #3407 from dangerous-tac0s/more-umc-pack-updates
More umc pack updates
2026-07-04 03:31:50 +07:00
michael e04adc2fc9 Added notes to hf mfu restore/dump about UMC pw/pack issues 2026-07-03 11:46:17 -07:00
iceman1001 b8911a29a1 fix coverity findings 2026-07-03 18:08:02 +02:00
michael bef2afcccf Added version numbers to ginfo output. Also, fixed version detection for short version response and updated magic card notes. 2026-07-03 09:04:05 -07:00
iceman1001 87388b3897 Merge branch 'master' of github.com:RfidResearchGroup/proxmark3 2026-07-03 17:30:20 +02:00
iceman1001 dc5e213420 fix coverity #910754 2026-07-03 17:19:00 +02:00
Iceman 5a46bb5f69 Merge pull request #3405 from cirosec/feature/fix-android-cross-compilation
Fix build issues with Android NDK
2026-07-03 19:11:31 +07:00
iceman1001 b18c274612 fix coverity findings 2026-07-03 12:38:59 +02:00
iceman1001 07b3491346 fix coverity resource leak #910743 2026-07-03 11:51:45 +02:00
iceman1001 52fc106027 fix coverity #910570 2026-07-03 11:40:45 +02:00
iceman1001 546ec40dc6 fix coverity mem leaks 2026-07-03 11:37:57 +02:00
iceman1001 41ad752a95 fix coverity #290250 2026-07-03 11:33:35 +02:00
iceman1001 fc773ea230 fix coverity #910036 2026-07-03 11:26:32 +02:00
iceman1001 b5abc8b335 fix coverity #910704 2026-07-03 11:25:14 +02:00
iceman1001 bf082caab7 fix coverity #910690 2026-07-03 11:22:38 +02:00
iceman1001 2d43d4c021 fix coverity #910669 2026-07-03 11:20:33 +02:00
iceman1001 c118e1cf20 fix various coverity scan findings' 2026-07-03 11:16:44 +02:00
Iceman ccfd25cd9b Merge pull request #3404 from dangerous-tac0s/hf-mfu-esetblk
Hf mfu esetblk
2026-07-03 13:04:05 +07:00
dangerous-tac0s a0797e0530 Merge branch 'RfidResearchGroup:master' into hf-mfu-esetblk 2026-07-02 18:14:31 -07:00
michael f4214a0a83 Removing unecessary plans 2026-07-02 18:11:43 -07:00
michael b30bde22f6 fix(sim): load Amiibo PWD/PACK into emulator memory at init, serve from memory
For tagType 7, when the PWD page is unset (0000) the UID-derived Amiibo
password and its PACK (0x8080) are now written into emulator memory at sim
init, and the PWD_AUTH path reads PWD and PACK straight from emulator memory.
Removes the auth-time pwd substitution and the PACK 0x8080 override, so
eset/eview are authoritative (what's in memory is what the sim serves) while
Amiibo sims still work.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-02 16:44:27 -07:00
michael fd5ad55104 fix(sim): serve NTAG PACK live from emulator memory in PWD_AUTH
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-02 15:28:19 -07:00
michael 38a05621d4 fix(mfu): reject esetblk data larger than one command buffer 2026-07-02 15:03:48 -07:00
michael 48e7ae056b feat(mfu): add hf mfu esetblk to set emulator memory pages 2026-07-02 14:14:40 -07:00
michael 86a0f994e5 docs: implementation plan for hf mfu esetblk
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-02 14:02:28 -07:00
michael 50c8e8fac4 docs: design for hf mfu esetblk (MFU emulator page set)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-02 13:57:12 -07:00
michael 9ca0f9d16b Improved UMC version detection/reporting in the lua script, added notes about 6666 having the same PACK issue and a reminder than the Ultralight EV1 plays by the same rules (pw/pack wise). 2026-07-02 13:16:53 -07:00
iceman1001 6c3e3c7a44 fix several coverity findings 2026-07-02 16:48:17 +02:00
iceman1001 344e7de9a1 style 2026-07-02 16:30:03 +02:00
iceman1001 6fe58f8e3c several coverity fixes 2026-07-02 16:29:42 +02:00
iceman1001 3620739645 Merge branch 'master' of github.com:RfidResearchGroup/proxmark3 2026-07-02 16:28:50 +02:00
Iceman 4667c626a9 Merge pull request #3401 from thisiscamk/feature/iso14443b-dump
hf 14b dump: implement Standard ISO14443-B card dumping
2026-07-02 16:13:55 +07:00
Iceman 461e741d60 Merge branch 'master' into feature/iso14443b-dump
Signed-off-by: Iceman <iceman@iuse.se>
2026-07-02 16:13:42 +07:00
iceman1001 2e98d23faa fix coverity #910782 2026-07-01 22:51:28 +02:00
iceman1001 b05bb68e24 fix coverity #910785 2026-07-01 22:44:45 +02:00
iceman1001 fd6dd10806 fix coverity #910783 2026-07-01 22:40:29 +02:00
iceman1001 07c6b396ba fix coverity #910786 2026-07-01 22:39:25 +02:00