Files
pyxis/lib/tdeck_ui/Hardware/TDeck/SDLogger.cpp
torlando-tech d03f0b308f Add shared SPI bus mutex for SD card, display, and LoRa coexistence
The T-Deck Plus shares HSPI across the display (CS=12), LoRa (CS=9),
and SD card (CS=39). Previously SD logging was disabled because
SD.begin() reconfigured the SPI bus and blanked the display.

This introduces a FreeRTOS mutex created in main.cpp and injected into
Display, SX1262Interface, and a new SDAccess class so all three
peripherals serialize their SPI transactions safely.

- Add SDAccess class wrapping SD.begin() and file ops with mutex
- Add set_spi_mutex() to Display and SX1262Interface
- Wrap Display flush, fill, draw, and power ops in mutex
- Refactor SDLogger to use SDAccess mutex instead of owning SD.begin()
- Wire up mutex creation and injection order in setup()

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-04 00:19:10 -05:00

205 lines
5.4 KiB
C++

// Copyright (c) 2024 microReticulum contributors
// SPDX-License-Identifier: MIT
#include "SDLogger.h"
#ifdef ARDUINO
#include <Arduino.h>
#endif
using namespace Hardware::TDeck;
// Static member initialization
bool SDLogger::_active = false;
bool SDLogger::_initialized = false;
uint32_t SDLogger::_bytes_written = 0;
uint32_t SDLogger::_last_flush = 0;
uint32_t SDLogger::_line_count = 0;
#ifdef ARDUINO
File SDLogger::_logFile;
bool SDLogger::init() {
if (_initialized) {
return _active;
}
_initialized = true;
// SDAccess must already be initialized (handles SD.begin with mutex)
if (!SDAccess::is_ready()) {
Serial.println("[SDLogger] SDAccess not ready, skipping SD logging");
return false;
}
// Open log file with mutex protection
if (!SDAccess::acquire_bus(1000)) {
Serial.println("[SDLogger] Failed to acquire SPI mutex for log file open");
return false;
}
_logFile = SD.open(CURRENT_LOG, FILE_APPEND);
if (!_logFile) {
SDAccess::release_bus();
Serial.println("[SDLogger] Failed to open log file");
return false;
}
// Write boot marker
_logFile.println("\n========================================");
_logFile.println("=== BOOT - SD LOGGING STARTED ===");
_logFile.printf("=== Free heap: %lu bytes ===\n", ESP.getFreeHeap());
_logFile.printf("=== Min free heap: %lu bytes ===\n", ESP.getMinFreeHeap());
_logFile.println("========================================\n");
_logFile.flush();
SDAccess::release_bus();
_bytes_written = 0;
_last_flush = millis();
_line_count = 0;
_active = true;
// Set log callback to capture all logs
RNS::setLogCallback(logCallback);
Serial.println("[SDLogger] SD card logging active");
return true;
}
void SDLogger::logCallback(const char* msg, RNS::LogLevel level) {
// Always print to serial as well
Serial.print(RNS::getTimeString());
Serial.print(" [");
Serial.print(RNS::getLevelName(level));
Serial.print("] ");
Serial.println(msg);
Serial.flush();
// Write to SD if active
if (_active && _logFile) {
writeToFile(msg, level);
}
}
void SDLogger::writeToFile(const char* msg, RNS::LogLevel level) {
if (!SDAccess::acquire_bus(50)) {
return; // Skip this log line rather than block the caller
}
// Format: timestamp [LEVEL] message
int written = _logFile.printf("%s [%s] %s\n",
RNS::getTimeString(),
RNS::getLevelName(level),
msg);
if (written > 0) {
_bytes_written += written;
_line_count++;
}
// Flush periodically or after critical messages
uint32_t now = millis();
bool should_flush = false;
// Always flush errors and warnings immediately
if (level <= RNS::LOG_WARNING) {
should_flush = true;
}
// Flush every N lines
else if (_line_count >= FLUSH_AFTER_LINES) {
should_flush = true;
}
// Flush every N milliseconds
else if (now - _last_flush >= FLUSH_INTERVAL_MS) {
should_flush = true;
}
if (should_flush) {
_logFile.flush();
_last_flush = now;
_line_count = 0;
}
// Check if we need to rotate (still holding mutex)
if (_bytes_written >= MAX_LOG_SIZE) {
rotateIfNeeded();
}
SDAccess::release_bus();
}
void SDLogger::flush() {
if (_active && _logFile) {
if (!SDAccess::acquire_bus(100)) return;
_logFile.flush();
_last_flush = millis();
_line_count = 0;
SDAccess::release_bus();
}
}
void SDLogger::marker(const char* msg) {
if (_active && _logFile) {
if (!SDAccess::acquire_bus(200)) return;
_logFile.println("----------------------------------------");
_logFile.printf(">>> MARKER: %s <<<\n", msg);
_logFile.printf(">>> Heap: %lu / Min: %lu <<<\n",
ESP.getFreeHeap(), ESP.getMinFreeHeap());
_logFile.println("----------------------------------------");
_logFile.flush();
SDAccess::release_bus();
}
}
void SDLogger::rotateIfNeeded() {
if (!_active || !_logFile) return;
// Close current log
_logFile.close();
// Rotate: delete old B, rename A to B, rename current to A
if (SD.exists(LOG_FILE_B)) {
SD.remove(LOG_FILE_B);
}
if (SD.exists(LOG_FILE_A)) {
SD.rename(LOG_FILE_A, LOG_FILE_B);
}
if (SD.exists(CURRENT_LOG)) {
SD.rename(CURRENT_LOG, LOG_FILE_A);
}
// Open new current log
_logFile = SD.open(CURRENT_LOG, FILE_WRITE);
if (!_logFile) {
_active = false;
Serial.println("[SDLogger] Failed to create new log file after rotation");
return;
}
_logFile.println("=== LOG ROTATED ===\n");
_logFile.flush();
_bytes_written = 0;
}
void SDLogger::close() {
if (_active && _logFile) {
if (SDAccess::acquire_bus(500)) {
_logFile.println("\n=== LOG CLOSED CLEANLY ===");
_logFile.flush();
_logFile.close();
SDAccess::release_bus();
}
_active = false;
}
// Restore default logging
RNS::setLogCallback(nullptr);
}
#else
// Native build stubs
bool SDLogger::init() { return false; }
void SDLogger::flush() {}
void SDLogger::marker(const char*) {}
void SDLogger::close() {}
#endif