Throw proper error when emoji isnt found

This commit is contained in:
Rory&
2026-07-01 19:46:31 +02:00
parent 15dae644a9
commit 11fa9d2180
@@ -74,11 +74,13 @@ router.get(
if (!app) throw DiscordApiErrors.UNKNOWN_APPLICATION;
if (req.user_id != app?.id && req.user_id != app?.owner_id) throw DiscordApiErrors.ACTION_NOT_AUTHORIZED_ON_APPLICATION;
const emoji = await Emoji.findOneOrFail({
const emoji = await Emoji.findOne({
where: { application_id: application_id, id: emoji_id },
relations: { user: true },
});
if (!emoji) throw DiscordApiErrors.UNKNOWN_EMOJI;
return res.json(emoji);
},
);
@@ -160,9 +162,10 @@ router.patch(
if (body.name?.includes("-")) body.name = body.name?.replaceAll("-", ""); // Dashes are invalid apparently
await Emoji.findOneOrFail({
const oldEmoji = await Emoji.findOne({
where: { id: emoji_id, application_id: application_id },
});
if (!oldEmoji) throw DiscordApiErrors.UNKNOWN_EMOJI;
const emoji = await Emoji.create({
...body,
@@ -191,6 +194,8 @@ router.delete(
if (!app) throw DiscordApiErrors.UNKNOWN_APPLICATION;
if (req.user_id != app?.id && req.user_id != app?.owner_id) throw DiscordApiErrors.ACTION_NOT_AUTHORIZED_ON_APPLICATION;
if (!(await Emoji.existsBy({ id: emoji_id, application_id }))) throw DiscordApiErrors.UNKNOWN_EMOJI;
await Emoji.delete({
id: emoji_id,
application_id: application_id,