Dont use promises for dummy endpoints

src/api/routes/applications/#application_id/skus.ts

@@ -30,7 +30,7 @@ router.get(
             },
         },
     }),
-    async (req: Request, res: Response) => {
+    (req: Request, res: Response) => {
         res.json([]).status(200);
     },
 );

src/api/routes/attachments/refresh-urls.ts

@@ -35,7 +35,7 @@ router.post(
             },
         },
     }),
-    async (req: Request, res: Response) => {
+    (req: Request, res: Response) => {
         const { attachment_urls } = req.body as RefreshUrlsRequestSchema;
 
         const refreshed_urls = attachment_urls.map((url) => {

src/api/routes/channels/#channel_id/directory-entries.ts

@@ -33,7 +33,7 @@ router.get(
             },
         },
     }),
-    async (req: Request, res: Response) => {
+    (req: Request, res: Response) => {
         res.json([] as HubDirectoryEntriesResponse);
     },
 );

src/api/routes/channels/#channel_id/messages/#message_id/index.ts

@@ -142,7 +142,7 @@ router.patch(
 router.put(
     "/",
     messageUpload.single("file"),
-    async (req, res, next) => {
+    (req, res, next) => {
         if (req.body.payload_json) {
             req.body = JSON.parse(req.body.payload_json);
         }

src/api/routes/channels/preload-messages.ts

@@ -45,12 +45,11 @@ router.post(
 
         const messages = (
             await Promise.all(
-                body.channels.map(
-                    async (channelId) =>
-                        await Message.findOne({
-                            where: { channel_id: channelId },
-                            order: { timestamp: "DESC" },
-                        }),
+                body.channels.map((channelId) =>
+                    Message.findOne({
+                        where: { channel_id: channelId },
+                        order: { timestamp: "DESC" },
+                    }),
                 ),
             )
         ).filter((x) => x !== null) as Message[];

src/api/routes/connections/#connection_name/#connection_id/refresh.ts

@@ -20,7 +20,7 @@ import { route } from "@spacebar/api";
 import { Request, Response, Router } from "express";
 const router = Router({ mergeParams: true });
 
-router.post("/", route({}), async (req: Request, res: Response) => {
+router.post("/", route({}), (req: Request, res: Response) => {
     // TODO:
     // const { connection_name, connection_id } = req.params;
     res.sendStatus(204);

src/api/routes/guilds/#guild_id/audit-logs.ts

@@ -21,7 +21,7 @@ import { route } from "@spacebar/api";
 const router = Router({ mergeParams: true });
 
 //TODO: implement audit logs
-router.get("/", route({}), async (req: Request, res: Response) => {
+router.get("/", route({}), (req: Request, res: Response) => {
     res.json({
         audit_log_entries: [],
         users: [],

src/api/routes/guilds/#guild_id/discovery-requirements.ts

@@ -30,7 +30,7 @@ router.get(
             },
         },
     }),
-    async (req: Request, res: Response) => {
+    (req: Request, res: Response) => {
         const { guild_id } = req.params;
         // TODO:
         // Load from database

src/api/routes/guilds/#guild_id/integrations.ts

@@ -21,7 +21,7 @@ import { route } from "@spacebar/api";
 const router = Router({ mergeParams: true });
 
 //TODO: implement integrations list
-router.get("/", route({}), async (req: Request, res: Response) => {
+router.get("/", route({}), (req: Request, res: Response) => {
     res.json([]);
 });
 export default router;

src/api/routes/guilds/#guild_id/member-verification.ts

@@ -29,7 +29,7 @@ router.get(
             },
         },
     }),
-    async (req: Request, res: Response) => {
+    (req: Request, res: Response) => {
         // TODO: member verification
 
         res.status(404).json({

src/api/routes/guilds/#guild_id/premium.ts

@@ -20,7 +20,7 @@ import { Router, Request, Response } from "express";
 import { route } from "@spacebar/api";
 const router = Router({ mergeParams: true });
 
-router.get("/subscriptions", route({}), async (req: Request, res: Response) => {
+router.get("/subscriptions", route({}), (req: Request, res: Response) => {
     // TODO:
     res.json([]);
 });

src/api/routes/guilds/#guild_id/widget.png.ts

@@ -134,7 +134,7 @@ async function drawIcon(canvas: any, x: number, y: number, scale: number, icon:
     canvas.restore();
 }
 
-async function drawText(canvas: any, x: number, y: number, color: string, font: string, text: string, maxcharacters?: number) {
+function drawText(canvas: any, x: number, y: number, color: string, font: string, text: string, maxcharacters?: number) {
     canvas.fillStyle = color;
     canvas.font = font;
     if (text.length > (maxcharacters || 0) && maxcharacters) text = text.slice(0, maxcharacters) + "...";

src/api/routes/guilds/automations/email-domain-lookup.ts

@@ -38,7 +38,7 @@ router.post(
             },
         },
     }),
-    async (req: Request, res: Response) => {
+    (req: Request, res: Response) => {
         const { email } = req.body as EmailDomainLookupSchema;
 
         const [_, tld] = email.split("@");
@@ -73,7 +73,7 @@ router.post(
             501: {},
         },
     }),
-    async (req: Request, res: Response) => {
+    (req: Request, res: Response) => {
         const { email } = req.body as EmailDomainLookupVerifyCodeSchema;
 
         const [_, tld] = email.split("@");

src/api/routes/guilds/templates/index.ts

@@ -87,7 +87,7 @@ async function getTemplate(code: string) {
             headers: { "Content-Type": "application/json" },
         });
 
-        return await discordTemplateData.json();
+        return (await discordTemplateData.json()) as Template;
     }
 
     if (code.startsWith("external:")) {

src/api/routes/hub-waitlist.ts

@@ -34,7 +34,7 @@ router.post(
             },
         },
     }),
-    async (req: Request, res: Response) => {
+    (req: Request, res: Response) => {
         const { email, school } = req.body as HubWaitlistSignupSchema;
 
         res.json({

src/api/routes/oauth2/tokens.ts

@@ -20,7 +20,7 @@ import { Router, Request, Response } from "express";
 import { route } from "@spacebar/api";
 const router = Router({ mergeParams: true });
 
-router.get("/", route({}), async (req: Request, res: Response) => {
+router.get("/", route({}), (req: Request, res: Response) => {
     //TODO
     res.json([]);
 });

src/api/routes/outbound-promotions.ts

@@ -21,7 +21,7 @@ import { route } from "@spacebar/api";
 
 const router: Router = Router({ mergeParams: true });
 
-router.get("/", route({}), async (req: Request, res: Response) => {
+router.get("/", route({}), (req: Request, res: Response) => {
     //TODO
     res.json([]).status(200);
 });

src/api/routes/partners/#guild_id/requirements.ts

@@ -21,7 +21,7 @@ import { route } from "@spacebar/api";
 
 const router = Router({ mergeParams: true });
 
-router.get("/", route({}), async (req: Request, res: Response) => {
+router.get("/", route({}), (req: Request, res: Response) => {
     const { guild_id } = req.params;
     // TODO:
     // Load from database

src/api/routes/policies/instance/domains.ts

@@ -30,7 +30,7 @@ router.get(
             },
         },
     }),
-    async (req: Request, res: Response) => {
+    (req: Request, res: Response) => {
         const { cdn, gateway, api } = Config.get();
 
         res.json({

src/api/routes/policies/instance/index.ts

@@ -30,7 +30,7 @@ router.get(
             },
         },
     }),
-    async (req: Request, res: Response) => {
+    (req: Request, res: Response) => {
         const { general } = Config.get();
         res.json(general);
     },

src/api/routes/policies/instance/limits.ts

@@ -30,7 +30,7 @@ router.get(
             },
         },
     }),
-    async (req: Request, res: Response) => {
+    (req: Request, res: Response) => {
         const { limits } = Config.get();
         res.json(limits);
     },

src/api/routes/scheduled-maintenances/upcoming.json.ts

@@ -20,7 +20,7 @@ import { Router, Request, Response } from "express";
 import { route } from "@spacebar/api";
 const router = Router({ mergeParams: true });
 
-router.get("/", route({}), async (req: Request, res: Response) => {
+router.get("/", route({}), (req: Request, res: Response) => {
     res.json({
         page: {},
         scheduled_maintenances: {},

src/api/routes/stage-instances.ts

@@ -21,7 +21,7 @@ import { route } from "@spacebar/api";
 
 const router: Router = Router({ mergeParams: true });
 
-router.get("/", route({}), async (req: Request, res: Response) => {
+router.get("/", route({}), (req: Request, res: Response) => {
     //TODO
     res.json([]).status(200);
 });

src/api/routes/stop.ts

@@ -32,7 +32,7 @@ router.post(
             },
         },
     }),
-    async (req: Request, res: Response) => {
+    (req: Request, res: Response) => {
         console.log(`/stop was called by ${req.user_id} at ${new Date()}`);
         res.sendStatus(200);
         process.kill(process.pid, "SIGTERM");

src/api/routes/store/published-listings/applications/#application_id/index.ts

@@ -21,7 +21,7 @@ import { route } from "@spacebar/api";
 
 const router: Router = Router({ mergeParams: true });
 
-router.get("/", route({}), async (req: Request, res: Response) => {
+router.get("/", route({}), (req: Request, res: Response) => {
     //TODO
     // const id = req.params.id;
     res.json({

src/api/routes/store/published-listings/applications/#application_id/subscription-plans.ts

@@ -21,7 +21,7 @@ import { route } from "@spacebar/api";
 
 const router: Router = Router({ mergeParams: true });
 
-router.get("/", route({}), async (req: Request, res: Response) => {
+router.get("/", route({}), (req: Request, res: Response) => {
     //TODO
     res.json([
         {

src/api/routes/store/published-listings/skus.ts

@@ -21,7 +21,7 @@ import { route } from "@spacebar/api";
 
 const router: Router = Router({ mergeParams: true });
 
-router.get("/:sku_id", route({}), async (req: Request, res: Response) => {
+router.get("/:sku_id", route({}), (req: Request, res: Response) => {
     //TODO
     // const id = req.params.id;
     res.json({

src/api/routes/store/published-listings/skus/#sku_id/subscription-plans.ts

@@ -316,7 +316,7 @@ const skus = new Map([
     ],
 ]);
 
-router.get("/", route({}), async (req: Request, res: Response) => {
+router.get("/", route({}), (req: Request, res: Response) => {
     // TODO: add the ability to add custom
     const { sku_id } = req.params;
 

src/api/routes/users/@me/applications/#application_id/entitlements.ts

@@ -21,7 +21,7 @@ import { route } from "@spacebar/api";
 
 const router: Router = Router({ mergeParams: true });
 
-router.get("/", route({}), async (req: Request, res: Response) => {
+router.get("/", route({}), (req: Request, res: Response) => {
     //TODO
     res.json([]).status(200);
 });

src/api/routes/users/@me/billing/country-code.ts

@@ -21,7 +21,7 @@ import { route } from "@spacebar/api";
 
 const router: Router = Router({ mergeParams: true });
 
-router.get("/", route({}), async (req: Request, res: Response) => {
+router.get("/", route({}), (req: Request, res: Response) => {
     //TODO
     res.json({ country_code: "US" }).status(200);
 });

src/api/routes/users/@me/billing/location-info.ts

@@ -21,7 +21,7 @@ import { route } from "@spacebar/api";
 
 const router: Router = Router({ mergeParams: true });
 
-router.get("/", route({}), async (req: Request, res: Response) => {
+router.get("/", route({}), (req: Request, res: Response) => {
     //TODO
     // TODO: subdivision_code (optional)
     res.json({ country_code: "US" }).status(200);

src/api/routes/users/@me/billing/subscriptions.ts

@@ -21,7 +21,7 @@ import { route } from "@spacebar/api";
 
 const router: Router = Router({ mergeParams: true });
 
-router.get("/", route({}), async (req: Request, res: Response) => {
+router.get("/", route({}), (req: Request, res: Response) => {
     //TODO
     res.json([]).status(200);
 });

src/api/routes/users/@me/collectibles-marketing.ts

@@ -39,7 +39,7 @@ router.get(
             },
         },
     }),
-    async (req: Request, res: Response) => {
+    (req: Request, res: Response) => {
         res.send({
             marketings: {},
         } as CollectiblesMarketingResponse);

src/api/routes/users/@me/collectibles-purchases.ts

@@ -38,7 +38,7 @@ router.get(
             },
         },
     }),
-    async (req: Request, res: Response) => {
+    (req: Request, res: Response) => {
         res.send([]);
     },
 );

src/util/dtos/DmChannelDTO.ts

@@ -43,8 +43,8 @@ export class DmChannelDTO {
             await Promise.all(
                 channel.recipients
                     ?.filter((r) => !excluded_recipients.includes(r.user_id))
-                    .map(async (r) => {
-                        return await User.findOneOrFail({
+                    .map((r) => {
+                        return User.findOneOrFail({
                             where: { id: r.user_id },
                             select: PublicUserProjection,
                         });

src/util/util/WebAuthn.ts

@@ -55,7 +55,7 @@ export async function generateWebAuthnTicket(challenge: string): Promise<string>
 export async function verifyWebAuthnToken(token: string) {
     return new Promise((res, rej) => {
         loadOrGenerateKeypair().then((kp) =>
-            jwt.verify(token, kp.publicKey, jwtVerifyOptions, async (err, decoded) => {
+            jwt.verify(token, kp.publicKey, jwtVerifyOptions, (err, decoded) => {
                 if (err) return rej(err);
                 return res(decoded);
             }),

src/util/util/networking/ipdata/IpDataClient.ts

@@ -16,11 +16,12 @@ export class IpDataClient {
         if (this.ipInfoCache.get(ip)?.expires ?? 0 > Date.now()) return this.ipInfoCache.get(ip)!.data;
 
         console.log(`[IpData] Fetching info for IP address ${ip}...`);
-        const resp = (await (await fetch(`https://eu-api.ipdata.co/${ip}?api-key=${ipdataApiKey}`)).json()) as Promise<IpDataIpLookupResponse>;
+        const response = await fetch(`https://eu-api.ipdata.co/${ip}?api-key=${ipdataApiKey}`);
+        const data = (await response.json()) as IpDataIpLookupResponse;
         this.ipInfoCache.set(ip, {
-            data: await resp,
+            data: data,
             expires: new DateBuilder().addHours(12).buildTimestamp(),
         });
-        return await resp;
+        return data;
     }
 }

src/webrtc/Server.ts

@@ -79,7 +79,7 @@ export class Server {
     }
 
     async stop() {
-        closeDatabase();
+        await closeDatabase();
         this.server.close();
         mediaServer?.stop();
     }