dandri/simplex-chat
1
0
Fork 0
mirror of https://github.com/simplex-chat/simplex-chat.git synced 2026-07-29 14:10:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

desktop: document two-stage verification, exit icon asymmetry and cache guard rationale in hover cursor fix

Browse Source
This commit is contained in:
Narasimha-sc
2026-07-15 09:54:07 +00:00
parent 2ad80d576d
commit 09ed427c2b
2 changed files with 18 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/multiplatform/common/src/commonMain/kotlin/chat/simplex/common/views/chat/item/TextItemView.kt
+3 -1
View File
@@ -363,7 +363,9 @@ fun MarkdownText (
desktopSetHoverCursor(newIcon)
},
onHoverExit = {
// also reset icon.value, or the pointerHoverIcon node re-displays a stale Hand on its next Enter
// also reset icon.value, or the pointerHoverIcon node re-displays a stale Hand on its next Enter;
// values differ on purpose: Text is this node's neutral icon, Default is what the cursor
// should be outside the text
icon.value = PointerIcon.Text
desktopSetHoverCursor(PointerIcon.Default)
},
plans/2026-07-13-fix-command-hover-cursor.md
+15 -5
View File
@@ -102,15 +102,25 @@ hover.
## Performance
- `detectCursorMove` is now cheaper per event than before (no scope teardown/re-entry per event).
- `detectCursorMove` is now cheaper per event than before (no scope teardown/re-entry per event);
the pressed check allocates one list iterator per event.
- `desktopSetHoverCursor` runs at mouse-move rate: steady-state cost is a cached component
reference check (parent-chain walk, no allocations) plus an int comparison; the native
`setCursor` call fires only when the cursor type actually changes. The canvas component lookup
(recursive tree walk) runs once per window and is cached.
(recursive tree walk) runs once per window and is cached, including negative results (a miss is
unreachable in practice — pointer events originate from the rendered canvas — kept as a guard).
- No new recompositions: the icon state logic is unchanged; Android is a no-op.
Framework line numbers cited above are from the official `ui-desktop-1.8.2`/`foundation-desktop-1.8.2`
sources jars on Maven Central; they will drift on upgrade.
## Testing
Verified on Linux (AppImage): hovering commands after clicking several in a row, clicking stacked
`/join` commands without moving the mouse, and sweeping across commands quickly — the hand cursor
now tracks correctly in all cases.
Verified on Linux (AppImage), in two stages:
1. A build with only the detection-layer fix (lossless `detectCursorMove`) was tested first and
the stale-cursor symptom **still reproduced** — this is the empirical justification for the
imperative display-layer workaround; the declarative-only fix is not sufficient.
2. With both layers: hovering commands after clicking several in a row, clicking stacked `/join`
commands without moving the mouse, and sweeping across commands quickly — the hand cursor
tracks correctly in all cases.