dandri/simplex-chat
1
0
Fork 0
mirror of https://github.com/simplex-chat/simplex-chat.git synced 2026-09-07 14:24:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

android, desktop: don't stack two create-profile forms on a double tap

Browse Source
This commit is contained in:
Narasimha-sc
2026-09-05 11:35:02 +00:00
parent 9ab265af3c
commit 0cfbebfbb2
2 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/multiplatform/common/src/commonMain/kotlin/chat/simplex/common/views/WelcomeView.kt
+1
View File
@@ -357,6 +357,7 @@ private fun CreateFirstProfileDesktop(chatModel: ChatModel, close: () -> Unit) {
fun createProfileForInvitation(rhId: Long?, onCreated: (User) -> Unit) {
val modalManager = ModalManager.fullscreen
if (modalManager.isLastModalOpen(ModalViewId.CONTEXT_USER_PICKER_NEW_PROFILE)) return
modalManager.showModalCloseable(id = ModalViewId.CONTEXT_USER_PICKER_NEW_PROFILE) { close ->
CreateProfile(chatModel, close, createProfile = { displayName, shortDescr, image ->
withBGApi {
plans/2026-07-30-new-profile-for-invitation.md
+5 -5
View File
@@ -175,11 +175,11 @@ workaround here:
`CreateProfile` and shown on the form, which stays open. Fixing this needs either a fixed
delay after dismissal or the presenting controller's completion handler, which is not
reachable from where these alerts are raised.
- **The back-out guard has a ~250ms residual.** `closeModal` leaves a dismissed modal in
`modalViews` until its close animation ends, so `isLastModalOpen` still reports it open
for that window. Backing out and having the create land inside it still reassigns. Closing
that needs a `toRemove`-aware variant of the check, which is more machinery than the
remaining window is worth.
- **Both `isLastModalOpen` guards have a ~250ms residual.** `closeModal` leaves a dismissed
modal in `modalViews` until its close animation ends, so the check still reports it open
for that window: backing out and having the create land inside it still reassigns, and
re-opening the form within it is swallowed. Closing that needs a `toRemove`-aware variant
of the check, which is more machinery than the remaining windows are worth.
- **Surface 2's `filteredProfiles` is `remember`ed on the search text only**, so on desktop
(where the picker is not disposed under the form) a profile created while it is open is
not listed. Invisible today because `selectProfile`