android, desktop: a report stays active in an open support chat after its message is moderated (#7908)

* android, desktop: do not throw when a deleted group item was sent by the user

* android, desktop: update the open support chat when its reports are deleted

* plans: moderated report stays active in the open support chat

* plans: correct the trigger and the exception location

* plans: correct statements found by fact-checking

* plans: align with the verified behaviour of the iOS handler

* plans: correct statements found by a second fact-check

* plans: correct statements found by a third fact-check

* plans: record the Android verification

apps/multiplatform/common/src/commonMain/kotlin/chat/simplex/common/model/SimpleXAPI.kt

@@ -3786,7 +3786,7 @@ object ChatController {
             generalGetString(MR.strings.marked_deleted_description)
           )
         }
-        val deleted = if (r.member_ != null && (cItem.chatDir as CIDirection.GroupRcv?)?.groupMember?.groupMemberId != r.member_.groupMemberId) {
+        val deleted = if (r.member_ != null && (cItem.chatDir as? CIDirection.GroupRcv)?.groupMember?.groupMemberId != r.member_.groupMemberId) {
           CIDeleted.Moderated(Clock.System.now(), r.member_)
         } else {
           CIDeleted.Deleted(Clock.System.now())
@@ -3803,12 +3803,12 @@ object ChatController {
             // Stop voice playback only inside a chat, allow to play in a chat list
             AudioPlayer.stop(cItem)
           }
-          val deleted = if (r.member_ != null && (cItem.chatDir as CIDirection.GroupRcv?)?.groupMember?.groupMemberId != r.member_.groupMemberId) {
+          val deleted = if (r.member_ != null && (cItem.chatDir as? CIDirection.GroupRcv)?.groupMember?.groupMemberId != r.member_.groupMemberId) {
             CIDeleted.Moderated(Clock.System.now(), r.member_)
           } else {
             CIDeleted.Deleted(Clock.System.now())
           }
-          chatsCtx.upsertChatItem(rhId, cInfo, cItem.copy(meta = cItem.meta.copy(itemDeleted = deleted)))
+          chatsCtx.upsertChatItem(rhId, cInfo.copy(groupChatScope = chatsCtx.groupScopeInfo), cItem.copy(meta = cItem.meta.copy(itemDeleted = deleted)))
         }
       }
     }

plans/2026-10-27-moderated-report-stays-active-in-support-chat.md

@@ -0,0 +1,63 @@
+# A reported message is moderated: the report stays active in the open support chat (Android, desktop)
+
+## Problem
+
+A member reports a message and keeps "Chat with admins" open. A moderator then moderates the reported message. The core marks the member's report as deleted and sends `CEvtGroupChatItemsDeleted` with the report's id, but the report stays shown as active until the chat is reopened. The same happens to a moderator who has a member's support chat open (group info → Chats with members) when another moderator moderates the reported message.
+
+Reproduced on master with the desktop app as the reporting member (a `ClassCastException` in the log) and as the viewing moderator (no exception, report not updated).
+
+## Cause
+
+Two defects in `groupChatItemsDeleted` (`SimpleXAPI.kt`), the only handler of this event:
+
+1. `(cItem.chatDir as CIDirection.GroupRcv?)` is not a safe cast. `as T?` returns null only for a null value; for a sent item (`CIDirection.GroupSnd`) it throws `ClassCastException`. A member's own report is a sent item, and `markMessageReportsDeleted` has no `item_sent` filter, so the event contains it. The receiver loop catches and logs the exception, so the rest of the event is not processed: the remaining ids in the secondary-context loop and `messagesChannel.trySend`. A member's report is sent in the member-support scope, so it is found by the secondary-context loop, where the exception is thrown. A report sent before group scopes existed is stored in the main scope and throws in the primary loop instead; the fix covers both sites.
+2. The secondary-context update passes `ChatInfo.Group(..., groupChatScope = null)` to `upsertChatItem`. A support chat's `ChatsContext` has a `GroupChatScopeContext` filter, and `chatItemBelongsToScope` returns false for a null scope there, so the item is found in the list but never replaced.
+
+## Fix
+
+Two commits, one per defect, in the one function:
+
+1. `as? CIDirection.GroupRcv` instead of `as CIDirection.GroupRcv?` at both sites. A sent item gets `CIDeleted.Moderated(member_)`, which is what the core returns when the chat is reloaded (`item_deleted_by_group_member_id` maps to `CIModerated` for any direction).
+2. The secondary-context upsert uses `cInfo.copy(groupChatScope = chatsCtx.groupScopeInfo)`. In a support chat the item has just been found by id in that context's own `chatItems`, so the context's scope is the item's scope. For the Reports view `groupScopeInfo` is null, so that view is unchanged.
+
+## Alternatives considered
+
+- Match iOS (`is GroupRcv` check, so a sent item becomes plain `Deleted`): rejected. A sent report archived by a moderator would show "archived report" when the event arrives and "archived report by <moderator>" after a reload.
+- Extract the duplicated `val deleted = ...` expression: rejected: the duplication predates this change, and `docs/contributing/CODE.md` rules out refactoring that does not substantially reduce cost.
+- Filter sent ids out of the event in the core: rejected. The sent report must be updated, and the filter needs a core change and a rebuilt library.
+- Build the scoped `ChatInfo` with a local `when` on `secondaryContextFilter`: rejected in favour of `ChatsContext.groupScopeInfo`, which already computes it and is read for the context's scope in `ChatItemsLoader.kt`, `ComposeView.kt` and `ChatView.kt`.
+
+## Scope
+
+- `commonMain`: Android and desktop share the path. Nothing platform-specific.
+- Core unchanged.
+- On desktop, the chat-list menu item "Archive reports" calls the same handler through `archiveAllReportsForMe`, and a member support chat can stay open beside the chat list, so that chat is now updated at once there too (read from the code, not tested). On Android the support chat covers the chat list, so this case does not arise.
+
+## Not fixed
+
+- iOS's handler sets `.deleted` for a sent item where Android and desktop now set `Moderated`, and it only iterates over the primary `ItemsModel`, so an open support chat or the Reports view is not updated there at all (read from the code, not run). iOS shows "archived report" for both values, so nothing differs on screen.
+- The reports counter is decremented once per id, including ids of sent reports. It is clamped at 0, and a member who reported and was later promoted to moderator can see it drop too far. This handler did the same before this change.
+- When the item's author is the moderator, the UI sets `Deleted` where a reload shows `Moderated`.
+- For the Reports view context the handler passes a null scope, so the first update adds a chat entry to that context's chat list, as the new-item and item-update handlers already do. That list is read only for the unread count (`ChatView.kt`), which is 0 with or without the entry.
+- Other nullable casts of the same form in `commonMain` (`FramedItemView.kt`, `ComposeView.kt`, `ChatInfoView.kt`) are guarded by earlier checks and cannot throw.
+
+## Verification
+
+Desktop AppImage on Linux, master compared with this branch, group with an owner, two members and the app as a member or a moderator; the owner moderates through `/_delete member item`, except where the app user moderates.
+
+| Case | master | this branch |
+|---|---|---|
+| Member's own report, Chat with admins open, reported message moderated | report stays active; `ClassCastException` in the log | archived at once; no exception |
+| Two reports, both moderated 4 s apart | both stay active; two exceptions | both archived |
+| Moderator, member's support chat open, reported message moderated | report stays active | archived at once |
+| Chat with admins closed while moderating, then reopened | archived | archived |
+| Moderator, Member reports view | archived | archived |
+| The app user, a moderator, moderates the reported message (result seen in the Reports view) | archived | archived |
+| Unreported message moderated | moderated, no exception | moderated, no exception |
+| Restart | archived | archived |
+
+Also tried on this branch: moderating while another member's support chat is open, three moderations in quick succession, moderating while scrolling, and opening Chat with admins only after the moderation. No exception, stale or duplicate item in any of them.
+
+Android (arm64 debug APKs on Waydroid, master compared with this branch): the member's own report and the moderator's open support chat show the same result as on desktop (master: report stays active, one `ClassCastException` for the member's own report; this branch: archived at once, no exception), and the control, two-report, closed-chat, moderator-moderates and relaunch cases pass on this branch.
+
+Not tested: iOS and "Archive reports" from the chat list on desktop while a member support chat of that group is open.