plans: profile picker bottom bar: entry points and size of the hidden part

This commit is contained in:
Narasimha-sc committed 2026-10-19 14:27:56 +00:00
1 parent d570d718bb
commit a26aff9aea
1 file changed
+7 -7
@@ -1,7 +1,7 @@
# The profile picker's last row is hidden under the bottom app bar
`ActiveProfilePicker` in `newchat/NewChatView.kt` — the "Select chat profile" screen,
reached from an invitation link and from the share sheet.
reached from New chat → 1-time link → "Share profile" (Android and desktop) and from the share sheet (Android).
## The defect
@@ -18,13 +18,13 @@ Against that, the list's only bottom clearance is its trailing spacer:
| | |
|---|---|
| obscured by the bar | `AppBarHeight` 56.dp + navigation bar |
| obscured by the bar | `AppBarHeight` 56.dp × √(app font scale) + navigation bar |
| clearance in the list | `DEFAULT_BOTTOM_PADDING` 48.dp |
| `LazyColumnWithScrollBar` `contentPadding` | `0.dp` (default, not overridden) |
The shortfall is `8.dp` plus the navigation bar — commonly 32–56.dp, and the rows are
`DEFAULT_MIN_SECTION_ITEM_HEIGHT + 8 = 58.dp`, so roughly one whole row is unreachable.
It only shows once the list is long enough to scroll; with few profiles nothing is hidden,
The shortfall is `8.dp` (more at larger app font scales) plus the navigation bar — commonly 32–56.dp, and the rows are
`DEFAULT_MIN_SECTION_ITEM_HEIGHT + 8 = 58.dp`, so on Android with 3-button navigation nearly a whole row stays hidden; on desktop (no navigation bar) about 8.dp of it.
It only shows once the list nearly fills the screen; with few profiles nothing is hidden,
which is why it survived.
`oneHandUI` defaults to **true**, so this is the default layout on Android rather than an
@@ -40,7 +40,7 @@ fully functional, so nothing draws attention to it.
#7329 adds an **"Add profile"** row at the end of this list. That moves a deliberately
sought affordance into the broken position: on a default Android install with enough
profiles to scroll, the button the feature exists for cannot be reached at all. The feature
profiles to scroll, the button the feature exists for is mostly hidden (fully with 3-button navigation). The feature
is unusable on Android without this fix, so #7329 depends on it.
Splitting it out anyway, because the defect is entirely pre-existing and worth fixing on
@@ -63,7 +63,7 @@ moves. No change when one-hand UI is off.
## Testing
Open "Select chat profile" from an invitation link on Android with one-hand UI on and
Open "Select chat profile" from New chat → 1-time link → "Share profile" on desktop and Android with one-hand UI on and
enough profiles that the list scrolls; the last row must be fully visible above the search
bar. Repeat with one-hand UI off — the layout must be unchanged. Repeat from the share
sheet, which uses the same picker with `contactConnection = null`.