This commit is contained in:
epoberezkin committed 2026-11-21 17:35:43 +00:00
1 parent 8e84322826
commit c210281873
2 files changed
+4 -2

No files matched your search

+2 -1
View File
@@ -1132,13 +1132,14 @@ window.addEventListener('click',(e)=>{
<p>For some complex features we create feature branches that will be merged once ready - do not make commits directly to them, make PRs to feature branches.</p>
<h2 id="pull-requests-and-ci" tabindex="-1">Pull requests and CI</h2>
<ol>
<li>Open a pull request to <code>master</code> as a draft. On a draft, CI runs the reduced build: one Linux job that builds and tests the changed scopes, and one macOS job only when iOS code changed (CI guide: scripts/ci/README.md).</li>
<li>Open a pull request to <code>master</code> as a draft. On a draft, CI runs the reduced build: one Linux job that builds and tests the changed scopes, one Linux job that runs the core tests on PostgreSQL when core code changed, and one macOS job only when iOS code changed (CI guide: scripts/ci/README.md).</li>
<li>Select the core tests in a <code>ci-tests</code> block in the description, one hspec match pattern per line. <code>/</code> runs all tests; without a block, the reduced build runs no core tests.</li>
<li>Push further changes to the same branch; on a draft, each push runs the reduced build.</li>
<li>Mark the pull request ready for review once it is ready. CI then runs the full matrix on each push, and the code owners are requested for review.</li>
<li>Mark it as a draft again when more work is needed. After the approval, the pull request is merged by squash once CI passes.</li>
<li>A change to a scope without CI tests adds its build and tests to CI in the same pull request.</li>
<li>A change of the apps' code adds, in the same pull request, app tests of all its changes on the core's real responses: core tests record the responses and events in tests/fixtures/api, and the Kotlin and iOS tests run the app code on them, with any platform service the code calls mocked (CI guide: &quot;App test fixtures&quot;).</li>
<li>Files that tests generate (schema dumps, query plans, API docs) are committed as CI generates them: when a test changes one, the step &quot;Check generated files&quot; fails, and the run's artifact <code>generated-files-&lt;job&gt;</code> holds the change as a patch.</li>
</ol>
<h2 id="differences-between-ghc-8107-and-ghc-963" tabindex="-1">Differences between GHC 8.10.7 and GHC 9.6.3</h2>
<ol>
+2 -1
View File
@@ -84,13 +84,14 @@ For some complex features we create feature branches that will be merged once re
## Pull requests and CI
1. Open a pull request to `master` as a draft. On a draft, CI runs the reduced build: one Linux job that builds and tests the changed scopes, and one macOS job only when iOS code changed (CI guide: scripts/ci/README.md).
1. Open a pull request to `master` as a draft. On a draft, CI runs the reduced build: one Linux job that builds and tests the changed scopes, one Linux job that runs the core tests on PostgreSQL when core code changed, and one macOS job only when iOS code changed (CI guide: scripts/ci/README.md).
2. Select the core tests in a `ci-tests` block in the description, one hspec match pattern per line. `/` runs all tests; without a block, the reduced build runs no core tests.
3. Push further changes to the same branch; on a draft, each push runs the reduced build.
4. Mark the pull request ready for review once it is ready. CI then runs the full matrix on each push, and the code owners are requested for review.
5. Mark it as a draft again when more work is needed. After the approval, the pull request is merged by squash once CI passes.
6. A change to a scope without CI tests adds its build and tests to CI in the same pull request.
7. A change of the apps' code adds, in the same pull request, app tests of all its changes on the core's real responses: core tests record the responses and events in tests/fixtures/api, and the Kotlin and iOS tests run the app code on them, with any platform service the code calls mocked (CI guide: "App test fixtures").
8. Files that tests generate (schema dumps, query plans, API docs) are committed as CI generates them: when a test changes one, the step "Check generated files" fails, and the run's artifact `generated-files-<job>` holds the change as a patch.
## Differences between GHC 8.10.7 and GHC 9.6.3