dandri/simplex-chat
1
0
Fork 0
mirror of https://github.com/simplex-chat/simplex-chat.git synced 2026-07-12 20:29:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

chat: clarify groups.simplex_name stopgap comment

Browse Source 
Drop the asymmetric toContact comment (the mirror is now obvious post-Task-1)
and rewrite the toGroupInfo stopgap comment to reflect the actual semantics:
groups.simplex_name is per-user locally-known, mirrored into groupProfile as a
stopgap until group_profiles.simplex_name lands.
This commit is contained in:
shum
2026-06-04 16:19:21 +00:00
parent cf3c7d152a
commit d083feaeb2
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Simplex/Chat/Store/Shared.hs
+7 -7
View File
@@ -501,9 +501,6 @@ type ContactRow = Only ContactId :. ContactRow'
toContact :: VersionRangeChat -> User -> [ChatTagId] -> ContactRow :. MaybeConnectionRow -> Contact
toContact vr user chatTags ((Only contactId :. (profileId, localDisplayName, displayName, fullName, shortDescr, image, contactLink, peerType, localAlias, BI contactUsed, contactStatus) :. (enableNtfs_, sendRcpts, BI favorite, preferences, userPreferences, createdAt, updatedAt, chatTs) :. preparedContactRow :. (contactRequestId, contactGroupMemberId, BI contactGrpInvSent) :. groupDirectInvRow :. (uiThemes, BI chatDeleted, customData, chatItemTTL, simplexNameRaw)) :. connRow) =
let simplexName = decodeSimplexName simplexNameRaw
-- simplexName is mirrored into the embedded LocalProfile so that downstream
-- consumers that only see the profile (e.g., redactedMemberProfile forwarding)
-- carry the same value as Contact.simplexName.
profile = LocalProfile {profileId, displayName, fullName, shortDescr, image, contactLink, simplexName, peerType, preferences, localAlias}
activeConn = toMaybeConnection vr connRow
chatSettings = ChatSettings {enableNtfs = fromMaybe MFAll enableNtfs_, sendRcpts = unBI <$> sendRcpts, favorite}
@@ -695,10 +692,13 @@ toGroupInfo vr userContactId chatTags ((groupId, localDisplayName, displayName,
publicGroup = toPublicGroupProfile groupType_ groupLink_ publicGroupId_ (toPublicGroupAccess accessRow)
groupKeys = toGroupKeys publicGroupId_ groupKeysRow
simplexName = decodeSimplexName simplexNameRaw
-- groups.simplex_name is also surfaced via groupProfile.simplexName so that
-- outgoing wire GroupProfile (e.g., XGrpInfo, XGrpInv) carries the host's
-- canonical name. Task 3 will introduce group_profiles.simplex_name for the
-- peer-claimed value; until then both consumers read from groups.simplex_name.
-- groups.simplex_name is the per-user locally-known group name (set by the
-- prepare-via-name path; see prior plan Task 7). Mirrored into
-- groupProfile.simplexName as a stopgap until group_profiles.simplex_name
-- is introduced for the peer-claimed/canonical name. The mirror reads
-- NULL today (no writer yet) so XGrpInfo carries Nothing — the leak risk
-- of broadcasting the user's locally-resolved label as canonical only
-- materialises once the prepare path starts writing the column.
groupProfile = GroupProfile {displayName, fullName, shortDescr, description, image, publicGroup, simplexName, groupPreferences, memberAdmission}
businessChat = toBusinessChatInfo businessRow
preparedGroup = toPreparedGroup preparedGroupRow