dandri/simplexmq
1
0
Fork 0
mirror of https://github.com/simplex-chat/simplexmq.git synced 2026-04-25 09:52:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: handle setFilePath error in receiveServerFile

Browse Source 
setFilePath result was discarded with void. If it failed (file deleted
concurrently, or double-upload where file_path IS NULL guard rejected
the second write), the server still reported FROk, incremented stats,
and left usedStorage permanently inflated. Now the error is checked:
on failure, reserved storage is released and AUTH is returned.
This commit is contained in:
shum
2026-04-02 12:42:16 +00:00
parent dd395b4a06
commit 0d28333919
1 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/Simplex/FileTransfer/Server.hs
View File

@@ -560,12 +560,17 @@ processXFTPRequest HTTP2Body {bodyPart} = \case
Right () -> do
stats <- asks serverStats
st <- asks store
withFileLog $ \sl -> logPutFile sl senderId fPath
void $ liftIO $ setFilePath st senderId fPath
incFileStat filesUploaded
incFileStat filesCount
liftIO $ atomicModifyIORef'_ (filesSize stats) (+ fromIntegral size)
pure FROk
liftIO (setFilePath st senderId fPath) >>= \case
Right () -> do
withFileLog $ \sl -> logPutFile sl senderId fPath
incFileStat filesUploaded
incFileStat filesCount
liftIO $ atomicModifyIORef'_ (filesSize stats) (+ fromIntegral size)
pure FROk
Left _e -> do
us <- asks usedStorage
atomically $ modifyTVar' us $ subtract (fromIntegral size)
pure $ FRErr AUTH
Left e -> do
us <- asks usedStorage
atomically $ modifyTVar' us $ subtract (fromIntegral size)