Merge pull request #4133 from matrix-org/travis/fix-terms-auth

Fix logic error that prevented guests from seeing the privacy policy
2026-08-03 13:29:27 +00:00 · 2018-11-02 10:50:43 +00:00
parent b199534518 552f090f62
commit 00f12e00f8
2 changed files with 2 additions and 1 deletions
@@ -0,0 +1 @@
+Add `m.login.terms` to the registration flow when consent tracking is enabled. **This makes the template arguments conditionally optional on a new `public_version` variable - update your privacy templates to support this.**
@@ -141,7 +141,7 @@ class ConsentResource(Resource):
        username = parse_string(request, "u", required=False, default="")
        userhmac = None
        has_consented = False
-        public_version = username != ""
+        public_version = username == ""
        if not public_version:
            userhmac = parse_string(request, "h", required=True, encoding=None)
				`@@ -0,0 +1 @@`
				Add `m.login.terms` to the registration flow when consent tracking is enabled. This makes the template arguments conditionally optional on a new `public_version` variable - update your privacy templates to support this.