dandri/synapse
1
0
Fork 0
mirror of https://github.com/element-hq/synapse.git synced 2026-05-30 11:14:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Allow 'article' and 'profile' opengraph fields on URL previews. (#19659)

Browse Source
This commit is contained in:
Will Hunt
2026-04-10 18:04:11 +01:00
committed by GitHub
parent a7b87e26ab
commit 2439990efc
3 changed files with 31 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
changelog.d/19659.feature
+1
View File
@@ -0,0 +1 @@
Passthrough 'article' and 'profile' opengraph metadata on url preview requests.
synapse/media/preview_html.py
+8 -10
View File
@@ -278,17 +278,15 @@ def parse_html_to_open_graph(tree: "etree._Element") -> dict[str, str | None]:
# "og:video:height" : "720",
# "og:video:secure_url": "https://www.youtube.com/v/LXDBoHyjmtw?version=3",
og = _get_meta_tags(tree, "property", "og")
ogRoot = _get_meta_tags(tree, "property", "og")
# TODO: Search for properties specific to the different Open Graph types,
# such as article: meta tags, e.g.:
#
# "article:publisher" : "https://www.facebook.com/thethudonline" />
# "article:author" content="https://www.facebook.com/thethudonline" />
# "article:tag" content="baby" />
# "article:section" content="Breaking News" />
# "article:published_time" content="2016-03-31T19:58:24+00:00" />
# "article:modified_time" content="2016-04-01T18:31:53+00:00" />
# https://ogp.me/#type_article
ogArticle = _get_meta_tags(tree, "property", "article")
# https://ogp.me/#type_profile
ogProfile = _get_meta_tags(tree, "property", "profile")
# Merge as-is
og = ogRoot | ogArticle | ogProfile
# Search for Twitter Card (twitter:) meta tags, e.g.:
#
tests/media/test_html_preview.py
+22
View File
@@ -433,6 +433,28 @@ class OpenGraphFromHtmlTestCase(unittest.TestCase):
},
)
def test_extended_opengraph(self) -> None:
"""Ensure we pull in profile and article data from opengraph."""
html = b"""
<html>
<meta property="og:description" content="My description" />
<meta property="profile:username" content="myname">
<meta property="article:published_time" content="2026-04-07T10:07:37Z">
</html>
"""
tree = decode_body(html, "http://example.com/test.html")
assert tree is not None
og = parse_html_to_open_graph(tree)
self.assertEqual(
og,
{
"og:title": None,
"og:description": "My description",
"profile:username": "myname",
"article:published_time": "2026-04-07T10:07:37Z",
},
)
def test_nested_nodes(self) -> None:
"""A body with some nested nodes. Tests that we iterate over children
in the right order (and don't reverse the order of the text)."""